Skip to contentSkip to conversation

support/testing: test_atf: bump the custom version to v2.5

PATCH In review Romain Naour 4 participants 5 messages Aug 22, 2021 – Sep 7, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/testing: test_atf: bump the custom version to v2.5

This version bump is needed to pass the ATF test with hardening option enabled (-fstack-protector-strong)

With the version v2.2, ATF fail due to undefined references:

./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to __stack_chk_fail'

---
 support/testing/tests/boot/test_atf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/testing/tests/boot/test_atf.py +1 -1
index a9d5b67ac7..4fcb9b241c 100644
@@ -10,7 +10,7 @@ class TestATFVexpress(infra.basetest.BRTest):
         BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware.git"
-        BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.2"
+        BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.5"
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="juno"
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP=y
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33=y
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw
Quoted 5 lines · On Sun, 22 Aug 2021 21:46:44 +0200 Romain Naour <[email protected]> wrote:

This version bump is needed to pass the ATF test with hardening option enabled (-fstack-protector-strong)

With the version v2.2, ATF fail due to undefined references:

Quoted 7 lines

./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to __stack_chk_fail'

Isn't this fixed since ccac9a5bbbd7374187a0f0017101ece0c202851d perhaps ?

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#2 lore raw

Hello Thomas,

Le 25/08/2021 à 00:02, Thomas Petazzoni a écrit :

Quoted 14 lines
Quoted 11 lines · On Sun, 22 Aug 2021 21:46:44 +0200 Romain Naour <[email protected]> wrote:

This version bump is needed to pass the ATF test with hardening option enabled (-fstack-protector-strong)

With the version v2.2, ATF fail due to undefined references:

./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to __stack_chk_fail'

Quoted 3 lines
Quoted 1 line

Isn't this fixed since ccac9a5bbbd7374187a0f0017101ece0c202851d perhaps ?

No, it was reproduced with this pipeline after this commit:
https://gitlab.com/kubu93/buildroot/-/pipelines/357079960/

Best regards,
Romain

Quoted 3 lines

Thomas

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#3 lore raw
In reply to Romain Naour
Quoted 5 lines · Romain Naour

This version bump is needed to pass the ATF test with hardening option enabled (-fstack-protector-strong)

With the version v2.2, ATF fail due to undefined references:

Quoted 7 lines

./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to __stack_chk_fail'

I've added a reference to the build failure
(https://gitlab.com/buildroot.org/buildroot/-/jobs/1524842591), explained a bit why it fails, and applied to master, thanks.

Regards,
Arnout

Quoted 10 lines
---
 support/testing/tests/boot/test_atf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/testing/tests/boot/test_atf.py +0 -0
index a9d5b67ac7..4fcb9b241c 100644

support/testing/tests/boot/test_atf.py class TestATFVexpress(infra.basetest.BRTest): · line 16

Quoted 8 lines
support/testing/tests/boot/test_atf.py +1 -1
@@ -10,7 +10,7 @@ class TestATFVexpress(infra.basetest.BRTest):
         BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware.git"
-        BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.2"
+        BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.5"
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="juno"
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP=y
         BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33=y

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw
In reply to Romain Naour
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

This version bump is needed to pass the ATF test with hardening option enabled (-fstack-protector-strong)

With the version v2.2, ATF fail due to undefined references:

Quoted 7 lines

./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to __stack_chk_guard' arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to __stack_chk_fail'

Committed to 2021.02.x and 2021.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot