stack: remove duplicated include of atomic
PATCH 1/1 stack: remove duplicated include of atomic
In stack module, remove the duplicated header file rte_atomic.h as it has been included in rte_spinlock.h/rte_pause.h
--- app/test/test_stack.c | 1 - lib/stack/rte_stack.c | 1 - lib/stack/rte_stack.h | 1 - 3 files changed, 3 deletions(-)
app/test/test_stack.c +0 -1
@@ -4,7 +4,6 @@#include <string.h> -#include <rte_atomic.h> #include <rte_lcore.h> #include <rte_malloc.h> #include <rte_random.h>
lib/stack/rte_stack.c +0 -1
@@ -5,7 +5,6 @@#include <string.h> #include <rte_string_fns.h> -#include <rte_atomic.h> #include <rte_eal.h> #include <rte_eal_memconfig.h> #include <rte_errno.h>
lib/stack/rte_stack.h +0 -1
@@ -19,7 +19,6 @@extern "C" {#endif -#include <rte_atomic.h> #include <rte_compat.h> #include <rte_debug.h> #include <rte_errno.h>
Signature · 1 line
2.17.1
Hi Joyce,
Quoted 5 lines · Joyce Kong
In stack module, remove the duplicated header file
rte_atomic.has it has been included inrte_spinlock.h/rte_pause.hSigned-off-by Joyce Kong <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>
Sorry for the late feedback.
No objection about the patch itself, but I don't think the commit log should say that rte_atomic.h is indirectly included by rte_spinlock.h/rte_pause.h.
To me, it is not a good reason to remove an include. However, it looks that no function from rte_atomic.h is used in these files, especially since commit c51e67c2ee18 ("test/stack: remove thread synchronisation") for the test app.
Thanks,
Olivier
PATCH v2 1/1 stack: remove duplicated include of atomic
In reply to Joyce KongFrom: Joyce Kong <[email protected]>
In stack module, remove the header file rte_atomic.h as it is not being used.
---
v2:
Change commit message (Olivier)
--- app/test/test_stack.c | 1 - lib/stack/rte_stack.c | 1 - lib/stack/rte_stack.h | 1 - 3 files changed, 3 deletions(-)
app/test/test_stack.c +0 -1
@@ -4,7 +4,6 @@#include <string.h> -#include <rte_atomic.h> #include <rte_lcore.h> #include <rte_malloc.h> #include <rte_random.h>
lib/stack/rte_stack.c +0 -1
@@ -6,7 +6,6 @@#include <sys/queue.h> #include <rte_string_fns.h> -#include <rte_atomic.h> #include <rte_eal.h> #include <rte_eal_memconfig.h> #include <rte_errno.h>
lib/stack/rte_stack.h +0 -1
@@ -19,7 +19,6 @@extern "C" {#endif -#include <rte_atomic.h> #include <rte_compat.h> #include <rte_debug.h> #include <rte_errno.h>
Signature · 1 line
2.25.1
Quoted 8 lines · Dharmik Thakkar
From: Joyce Kong <[email protected]>
In stack module, remove the header file
rte_atomic.has it is not being used.Signed-off-by Joyce Kong <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>
Thanks
David Marchand
AppliedQuoted 11 lines · Olivier Matz
Quoted 8 lines · Dharmik Thakkar
From: Joyce Kong <[email protected]>
In stack module, remove the header file
rte_atomic.has it is not being used.Signed-off-by Joyce Kong <[email protected]>Signed-off-by Dharmik Thakkar <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Acked-by Olivier Matz <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand