Skip to contentSkip to conversation

stack: remove duplicated include of atomic

PATCH In review Joyce Kong 4 participants 5 messages Aug 23, 2021 – Oct 19, 2021

lore
Share & tools
lore

Joyce Kong

author
#0 lore raw

PATCH 1/1 stack: remove duplicated include of atomic

In stack module, remove the duplicated header file rte_atomic.h as it has been included in rte_spinlock.h/rte_pause.h

---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)
app/test/test_stack.c +0 -1
index 00efb38e2a..bc38961433 100644
@@ -4,7 +4,6 @@
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
lib/stack/rte_stack.c +0 -1
index f1cbb9803f..d3bfc57955 100644
@@ -5,7 +5,6 @@
 #include <string.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
lib/stack/rte_stack.h +0 -1
index 27640f87b2..321f4cec1a 100644
@@ -19,7 +19,6 @@
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>
Signature · 1 line
2.17.1
#1 lore raw

Hi Joyce,

Quoted 5 lines · Joyce Kong

In stack module, remove the duplicated header file rte_atomic.h as it has been included in rte_spinlock.h/rte_pause.h

Sorry for the late feedback.

No objection about the patch itself, but I don't think the commit log should say that rte_atomic.h is indirectly included by rte_spinlock.h/rte_pause.h.

To me, it is not a good reason to remove an include. However, it looks that no function from rte_atomic.h is used in these files, especially since commit c51e67c2ee18 ("test/stack: remove thread synchronisation") for the test app.

Thanks,
Olivier

#2 lore raw

PATCH v2 1/1 stack: remove duplicated include of atomic

In reply to Joyce Kong

From: Joyce Kong <[email protected]>

In stack module, remove the header file rte_atomic.h as it is not being used.

---
v2:
Change commit message (Olivier)

---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)
app/test/test_stack.c +0 -1
index 00efb38e2ab8..bc3896143334 100644
@@ -4,7 +4,6 @@
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
lib/stack/rte_stack.c +0 -1
index 5e56cd9f0cd3..56bf2c8d6d3d 100644
@@ -6,7 +6,6 @@
 #include <sys/queue.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
lib/stack/rte_stack.h +0 -1
index 27640f87b245..321f4cec1a10 100644
@@ -19,7 +19,6 @@
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>
Signature · 1 line
2.25.1