Skip to contentSkip to conversation

tests/i915/gem_sync: igt_require to check availability of engine in list_engines

PATCH In review Arjun Melkaveri 3 participants 6 messages Aug 22, 2021 – Aug 23, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/i915/gem_sync: igt_require to check availability of engine in list_engines

Replaced igt_assert with igt_require in list_engines , to avoid false failure of test case if engine is not supported or found .
Test will return Test requirement not met.

Cc Ashutosh Dixit <[email protected]>
Cc Zbigniew Kempczyński <[email protected]>
---
 tests/i915/gem_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/i915/gem_sync.c +2 -2
index 6cb00c40..4ad264a2 100644
@@ -106,9 +106,9 @@ list_engines(int fd, const intel_ctx_t *ctx, unsigned ring)
 		ied = intel_engine_list_for_ctx_cfg(fd, &ctx->cfg);
 	} else {
 		if (ctx->cfg.num_engines)
-			igt_assert(ring < ctx->cfg.num_engines);
+			igt_require(ring < ctx->cfg.num_engines);
 		else
-			igt_assert(gem_has_ring(fd, ring));
+			igt_require(gem_has_ring(fd, ring));
 
 		ied.engines[ied.nengines].flags = ring;
 		strcpy(ied.engines[ied.nengines].name, " ");
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_sync: igt_require to check availability of engine in list_engines

== Series Details ==

== Series Details ==

Series: tests/i915/gem_sync: igt_require to check availability of engine in list_engines
URL : https://patchwork.freedesktop.org/series/93903/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10505 -> IGTPW_6144
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/index.html

Known issues
------------

Here are the changes found in IGTPW_6144 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-rkl-guc/igt@amdgpu/[email protected]

* igt@amdgpu/amd_prime@i915-to-amd:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-kbl-soraka/igt@amdgpu/[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-kbl-8809g/igt@[email protected]
- fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][5] ([i915#1155])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-tgl-1115g4: NOTRUN -> [INCOMPLETE][6] ([i915#4006])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@kms_addfb_basic@too-wide:
- fi-tgl-1115g4: NOTRUN -> [DMESG-WARN][7] ([i915#4002]) +91 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][8] ([fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-kbl-8809g/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([fdo#109285])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-8809g: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-kbl-8809g/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][12] ([fdo#109271]) +35 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html

* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([i915#1072]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html

* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([i915#3301])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

* igt@runner@aborted:
- fi-tgl-1115g4: NOTRUN -> [FAIL][15] ([i915#2722] / [i915#3834])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-tgl-1115g4/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-kbl-8809g: [DMESG-WARN][16] ([i915#3848]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/fi-kbl-8809g/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-kbl-8809g/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [INCOMPLETE][18] ([i915#3920]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/fi-rkl-guc/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/fi-rkl-guc/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3834]: https://gitlab.freedesktop.org/drm/intel/issues/3834
[i915#3848]: https://gitlab.freedesktop.org/drm/intel/issues/3848
[i915#3920]: https://gitlab.freedesktop.org/drm/intel/issues/3920
[i915#4002]: https://gitlab.freedesktop.org/drm/intel/issues/4002
[i915#4006]: https://gitlab.freedesktop.org/drm/intel/issues/4006
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Participating hosts (40 -> 33)
------------------------------

Additional (1): fi-tgl-1115g4
Missing (8): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-bsw-cyan fi-apl-guc fi-bdw-samus fi-ehl-2 bat-jsl-1

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6181 -> IGTPW_6144

CI-20190529: 20190529
CI_DRM_10505: 7c36ed237585ed2f645439e62dafccac070d5e33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6144: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/index.html
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/index.html

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_sync: igt_require to check availability of engine in list_engines

In reply to Arjun Melkaveri
== Series Details ==

== Series Details ==

Series: tests/i915/gem_sync: igt_require to check availability of engine in list_engines
URL : https://patchwork.freedesktop.org/series/93903/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10505_full -> IGTPW_6144_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/index.html

Known issues
------------

Here are the changes found in IGTPW_6144_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@display-2x:
- shard-tglb: NOTRUN -> [SKIP][1] ([i915#1839])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb2/igt@[email protected]

* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb2/igt@[email protected]
- shard-snb: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-snb2/igt@[email protected]
- shard-kbl: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl3/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][5] ([i915#3002])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb8/igt@[email protected]
- shard-glk: NOTRUN -> [DMESG-WARN][6] ([i915#3002])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk4/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][7] ([i915#3002])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl2/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099]) +6 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-snb2/igt@[email protected]

* igt@gem_eio@in-flight-contexts-immediate:
- shard-tglb: [PASS][9] -> [TIMEOUT][10] ([i915#3063])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-tglb1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb7/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: NOTRUN -> [FAIL][11] ([i915#2846])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl1/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-tglb3/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-tglb: NOTRUN -> [FAIL][15] ([i915#2842]) +4 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk4/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl3/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][21] -> [SKIP][22] ([i915#2190])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-tglb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb6/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#307])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb2/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][25] ([i915#2658])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl1/igt@[email protected]

* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271]) +13 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk5/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][27] ([i915#3318])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl8/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][28] ([i915#3318])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk6/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][29] -> [DMESG-WARN][30] ([i915#1436] / [i915#716])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk5/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109293] / [fdo#109506])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109506] / [i915#2411])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb5/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271]) +123 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl4/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: NOTRUN -> [DMESG-WARN][34] ([i915#180]) +5 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl7/igt@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111614]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb8/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#110725] / [fdo#111614])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3777])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl1/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3777])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk9/igt@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +19 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl8/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl2/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk6/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3689] / [i915#3886])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb7/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278] / [i915#3886])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb7/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb3/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_ccs.html

* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271]) +358 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-snb6/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html

* igt@kms_chamelium@hdmi-audio-edid:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-snb: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +17 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-snb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +25 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl7/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][52] ([i915#1319])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
- shard-kbl: NOTRUN -> [FAIL][53] ([i915#3444])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl1/igt@[email protected]
- shard-iclb: [PASS][54] -> [FAIL][55] ([i915#3444])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb6/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb6/igt@[email protected]
- shard-glk: [PASS][56] -> [FAIL][57] ([i915#3444]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk5/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk8/igt@[email protected]
- shard-tglb: [PASS][58] -> [FAIL][59] ([i915#2124])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-tglb3/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x10-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3359])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#111825]) +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109274] / [fdo#109278])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb8/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl7/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-iclb: [PASS][64] -> [SKIP][65] ([i915#3788])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb1/igt@kms_dither@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb2/igt@kms_dither@[email protected]

* igt@kms_dsc@xrgb8888-dsc-compression:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#3828])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#3828])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb3/igt@[email protected]

* igt@kms_flip@2x-busy-flip:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109274])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb3/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][69] -> [DMESG-WARN][70] ([i915#180]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl7/igt@kms_flip@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][71] -> [DMESG-WARN][72] ([i915#180]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-apl3/igt@kms_flip@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109280])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render.html

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][74] -> [SKIP][75] ([i915#433])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-tglb7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb2/igt@[email protected]
- shard-iclb: [PASS][76] -> [SKIP][77] ([i915#433])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb6/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb5/igt@[email protected]

* igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#109289])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109289])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb5/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl7/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-glk: [PASS][81] -> [INCOMPLETE][82] ([i915#2828])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk4/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][83] ([fdo#108145] / [i915#265]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][84] ([i915#265])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl4/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#3536])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb1/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2733])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl7/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658]) +5 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl6/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][89] -> [SKIP][90] ([fdo#109441]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb7/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271]) +290 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl6/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2437]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2437])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk4/igt@[email protected]

* igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#2530])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb3/igt@[email protected]

* igt@prime_nv_pcopy@test1_macro:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#109291])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb5/igt@prime_nv_pcopy@test1_macro.html

* igt@sysfs_clients@create:
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#2994])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb1/igt@[email protected]

* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl6/igt@[email protected]

* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994]) +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [SKIP][99] ([fdo#109271]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-apl3/igt@gem_exec_fair@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][101] ([i915#2842]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk6/igt@gem_exec_fair@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][103] ([i915#2842]) -> [PASS][104] +4 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl6/igt@gem_exec_fair@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglb: [FAIL][105] ([i915#2842]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-tglb2/igt@gem_exec_fair@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [SKIP][107] ([fdo#109271]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl6/igt@gem_exec_fair@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][109] ([i915#118] / [i915#95]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk5/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][111] ([i915#1436] / [i915#716]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-glk7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-glk7/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-kbl: [FAIL][113] ([i915#79]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl7/igt@kms_flip@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [DMESG-WARN][115] ([i915#180]) -> [PASS][116] +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-apl3/igt@kms_flip@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][117] ([i915#180] / [i915#1982]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl4/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl7/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-kbl4/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-kbl4/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][121] ([fdo#109441]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

#### Warnings ####

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][123] ([i915#2920]) -> [SKIP][124] ([i915#658]) +3 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb2/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb3/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][125] ([i915#658]) -> [SKIP][126] ([i915#2920]) +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10505/shard-iclb5/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/shard-iclb2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2124]: https://gitlab.freedesktop.org/drm/intel/issues/2124
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3444]: https://gitlab.freedesktop.org/drm/intel/issues/3444
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3788]: https://gitlab.freedesktop.org/drm/intel/issues/3788
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3976]: https://gitlab.freedesktop.org/drm/intel/issues/3976
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/i

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6144/index.html

#3 lore raw
In reply to Arjun Melkaveri
Quoted 17 lines · Arjun Melkaveri

Replaced igt_assert with igt_require in list_engines , to avoid false failure of test case if engine is not supported or found .
Test will return Test requirement not met.

Cc Ashutosh Dixit <[email protected]>
Cc Zbigniew Kempczyński <[email protected]>
---
 tests/i915/gem_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/i915/gem_sync.c +0 -0
index 6cb00c40..4ad264a2 100644

tests/i915/gem_sync.c list_engines(int fd, const intel_ctx_t *ctx, unsigned ring) · line 111

Quoted 8 lines
tests/i915/gem_sync.c +2 -2
@@ -106,9 +106,9 @@ list_engines(int fd, const intel_ctx_t *ctx, unsigned ring)
 		ied = intel_engine_list_for_ctx_cfg(fd, &ctx->cfg);
 	} else {
 		if (ctx->cfg.num_engines)
-			igt_assert(ring < ctx->cfg.num_engines);
+			igt_require(ring < ctx->cfg.num_engines);
 		else
-			igt_assert(gem_has_ring(fd, ring));
+			igt_require(gem_has_ring(fd, ring));

To be honest I don't like this change. If we have invalid ring here it smells like bug in the code. If caller is passed ctx it should be created over cfg, so it contains valid (imo) engine set. Thus if someone passed invalid ring I would assume this is bug in the code and assert is correct bahavior here.

What are scenarios you're trying to handle?

--
Zbigniew

Quoted 6 lines
tests/i915/gem_sync.c +0 -0
 		ied.engines[ied.nengines].flags = ring;
 		strcpy(ied.engines[ied.nengines].name, " ");
Signature · 1 line
2.25.1
#4 lore raw
Quoted 33 lines · Zbigniew Kempczyński
Quoted 17 lines · Arjun Melkaveri

Replaced igt_assert with igt_require in list_engines , to avoid false failure of test case if engine is not supported or found .
Test will return Test requirement not met.

Cc Ashutosh Dixit <[email protected]>
Cc Zbigniew Kempczyński <[email protected]>
---
 tests/i915/gem_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/i915/gem_sync.c +0 -0
index 6cb00c40..4ad264a2 100644

tests/i915/gem_sync.c list_engines(int fd, const intel_ctx_t *ctx, unsigned ring) · line 111

Quoted 8 lines
tests/i915/gem_sync.c +2 -2
@@ -106,9 +106,9 @@ list_engines(int fd, const intel_ctx_t *ctx, unsigned ring)
 		ied = intel_engine_list_for_ctx_cfg(fd, &ctx->cfg);
 	} else {
 		if (ctx->cfg.num_engines)
-			igt_assert(ring < ctx->cfg.num_engines);
+			igt_require(ring < ctx->cfg.num_engines);
 		else
-			igt_assert(gem_has_ring(fd, ring));
+			igt_require(gem_has_ring(fd, ring));

To be honest I don't like this change. If we have invalid ring here it smells like bug in the code. If caller is passed ctx it should be created over cfg, so it contains valid (imo) engine set. Thus if someone passed invalid ring I would assume this is bug in the code and assert is correct bahavior here.

Quoted 4 lines

What are scenarios you're trying to handle?

--
Zbigniew

This test is asserting for render engine in platform that doesnt support it. It used to skip before test was converted to use intel_ctx_t .
(https://patchwork.freedesktop.org/patch/442850/)

-Arjun

Quoted 7 lines
Quoted 7 lines
tests/i915/gem_sync.c +0 -0
 		ied.engines[ied.nengines].flags = ring;
 		strcpy(ied.engines[ied.nengines].name, " ");
Signature · 1 line
2.25.1
#5 lore raw
Quoted 34 lines · Arjun
Quoted 33 lines · Zbigniew Kempczyński
Quoted 17 lines · Arjun Melkaveri

Replaced igt_assert with igt_require in list_engines , to avoid false failure of test case if engine is not supported or found .
Test will return Test requirement not met.

Cc Ashutosh Dixit <[email protected]>
Cc Zbigniew Kempczyński <[email protected]>
---
 tests/i915/gem_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/i915/gem_sync.c +0 -0
index 6cb00c40..4ad264a2 100644

tests/i915/gem_sync.c list_engines(int fd, const intel_ctx_t *ctx, unsigned ring) · line 111

Quoted 8 lines
tests/i915/gem_sync.c +2 -2
@@ -106,9 +106,9 @@ list_engines(int fd, const intel_ctx_t *ctx, unsigned ring)
 		ied = intel_engine_list_for_ctx_cfg(fd, &ctx->cfg);
 	} else {
 		if (ctx->cfg.num_engines)
-			igt_assert(ring < ctx->cfg.num_engines);
+			igt_require(ring < ctx->cfg.num_engines);
 		else
-			igt_assert(gem_has_ring(fd, ring));
+			igt_require(gem_has_ring(fd, ring));

To be honest I don't like this change. If we have invalid ring here it smells like bug in the code. If caller is passed ctx it should be created over cfg, so it contains valid (imo) engine set. Thus if someone passed invalid ring I would assume this is bug in the code and assert is correct bahavior here.

Quoted 7 lines
Quoted 4 lines

What are scenarios you're trying to handle?

--
Zbigniew

This test is asserting for render engine in platform that doesnt support it. It used to skip before test was converted to use intel_ctx_t .
(https://patchwork.freedesktop.org/patch/442850/)

I think render engine should be excluded in DRM_I915_QUERY_ENGINE_INFO query. If it is not imo this is a bug. Kernel shouldn't return render engine if it is not available on some platform.

--
Zbigniew

Quoted 9 lines

-Arjun

Quoted 7 lines
Quoted 7 lines
tests/i915/gem_sync.c +0 -0
 		ied.engines[ied.nengines].flags = ring;
 		strcpy(ied.engines[ied.nengines].name, " ");
Signature · 1 line
2.25.1