Skip to contentSkip to conversation

Minor doc correction: tls-crypt-v2 key generation

PATCH In review [email protected]... 3 participants 5 messages Aug 22, 2021 – Aug 23, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Minor doc correction: tls-crypt-v2 key generation

From: Selva Nair <[email protected]...>

---
 doc/tls-crypt-v2.txt  | 4 ++--
 src/openvpn/options.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
doc/tls-crypt-v2.txt +2 -2
index 3798791f..f6a6a139 100644
@@ -58,7 +58,7 @@ Implementation
 When setting up a tls-crypt-v2 group (similar to generating a tls-crypt or
 tls-auth key previously):
 
-1. Generate a tls-crypt-v2 server key using OpenVPN's ``--tls-crypt-v2-genkey server``.
+1. Generate a tls-crypt-v2 server key using OpenVPN's ``--genkey tls-crypt-v2-server``.
    This key contains 2 512-bit keys, of which we use:
 
    * the first 256 bits of key 1 as AES-256-CTR encryption key ``Ke``
@@ -73,7 +73,7 @@ tls-auth key previously):
 
 When provisioning a client, create a client-specific tls-crypt key:
 
-1. Generate 2048 bits client-specific key ``Kc`` using OpenVPN's ``--tls-crypt-v2-genkey client``
+1. Generate 2048 bits client-specific key ``Kc`` using OpenVPN's ``--genkey tls-crypt-v2-client``
 
 2. Optionally generate metadata
 
src/openvpn/options.c +1 -1
index 7e146db9..0e398c0f 100644
@@ -614,7 +614,7 @@ static const char usage_message[] =
     "                  see --secret option for more info.\n"
     "--tls-crypt-v2 key : For clients: use key as a client-specific tls-crypt key.\n"
     "                  For servers: use key to decrypt client-specific keys.  For\n"
-    "                  key generation (--tls-crypt-v2-genkey): use key to\n"
+    "                  key generation (--genkey tls-crypt-v2-client): use key to\n"
     "                  encrypt generated client-specific key.  (See --tls-crypt.)\n"
     "--genkey tls-crypt-v2-client [keyfile] [base64 metadata]: Generate a\n"
     "                  fresh tls-crypt-v2 client key, and store to\n"
Signature · 1 line
2.20.1
#2 lore raw
In reply to [email protected]...

Hi,

Quoted 7 lines · On Sun, Aug 22, 2021 at 11:28:20AM -0400, [email protected]... wrote:

From: Selva Nair <[email protected]...>

---
 doc/tls-crypt-v2.txt  | 4 ++--
 src/openvpn/options.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

I assume this is for master and 2.5?

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...
author
#3 lore raw

Hi,

Quoted 5 lines · Gert Doering

Hi,

Quoted 2 lines · On Sun, Aug 22, 2021 at 11:28:20AM -0400, [email protected]... wrote:

From: Selva Nair <[email protected]...>

Quoted 8 lines
Quoted 5 lines
---
 doc/tls-crypt-v2.txt  | 4 ++--
 src/openvpn/options.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

I assume this is for master and 2.5?

Yes, please. I forgot to indicate that in the submission.

Selva

#4 lore raw
In reply to [email protected]...

Documentation is good, correct documentation is better :-) - thanks.

Your patch has been applied to the master and release/2.5 branch.

commit 6ee1a272d9ce9b7863487146c3ce141a98f16773 (master) commit 96083a9150edd90a6641477d123324cf0885853e (release/2.5)

Author: Selva Nair
Date:   Sun Aug 22 11:28:20 2021 -0400
     Minor doc correction: tls-crypt-v2 key generation

     Signed-off-by: Selva Nair <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg22747.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering