Skip to contentSkip to conversation

dio: add missing iounmap() after ioremap()

PATCH In review [email protected] 2 participants 2 messages Aug 23, 2021 – Aug 27, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dio: add missing iounmap() after ioremap()

From: xu xin <[email protected]>

If kzalloc() fails, the 'va' needs to be unmapped before returning -ENOMEM.

---
 drivers/dio/dio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletions(-)
drivers/dio/dio.c +4 -1
index 4c06c93..7d19250 100644
@@ -218,9 +218,11 @@ static int __init dio_init(void)
 
        /* Found a board, allocate it an entry in the list */
        dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
-       if (!dev)
+       if (!dev) {
+           if (scode >= DIOII_SCBASE)
+               iounmap(va);
            return -ENOMEM;
+       }
        dev->bus = &dio_bus;
        dev->dev.parent = &dio_bus.dev;
        dev->dev.bus = &dio_bus_type;
Signature · 1 line
2.15.2
#1 lore raw
Quoted 29 lines · On Mon, Aug 23, 2021 at 08:45:47PM +0800, [email protected] wrote:

From: xu xin <[email protected]>

If kzalloc() fails, the 'va' needs to be unmapped before returning -ENOMEM.

---
 drivers/dio/dio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletions(-)
drivers/dio/dio.c +4 -1
index 4c06c93..7d19250 100644
@@ -218,9 +218,11 @@ static int __init dio_init(void)
 
        /* Found a board, allocate it an entry in the list */
        dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
-       if (!dev)
+       if (!dev) {
+           if (scode >= DIOII_SCBASE)
+               iounmap(va);
            return -ENOMEM;
+       }
        dev->bus = &dio_bus;
        dev->dev.parent = &dio_bus.dev;
        dev->dev.bus = &dio_bus_type;
Signature · 1 line
2.15.2

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool.

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot