netfilter: x_tables: handle xt_register_template() returning an error value
Subsystems (4)
PATCH 1/1 netfilter: x_tables: handle xt_register_template() returning an error value
Commit fdacd57c79b7 ("netfilter: x_tables: never register tables by default") introduces the function xt_register_template(), and in one case, a call to that function was missing the error-case handling.
Handle when xt_register_template() returns an error value.
This was identified with the clang-analyzer's Dead-Store analysis.
--- net/ipv4/netfilter/iptable_mangle.c | 2 ++ 1 file changed, 2 insertions(+)
net/ipv4/netfilter/iptable_mangle.c +2 -0
@@ -112,6 +112,8 @@ static int __init iptable_mangle_init(void) {int ret =xt_register_template (&packet_mangler, iptable_mangle_table_init); +if (ret <0 ) +return ret; mangle_ops =xt_hook_ops_alloc (&packet_mangler, iptable_mangle_hook);if (IS_ERR (mangle_ops)) {
Signature · 1 line
2.26.2
Quoted 7 lines · Lukas Bulwahn
Commit
fdacd57c79b7("netfilter:x_tables: never register tables by default") introduces the functionxt_register_template(), and in one case, a call to that function was missing the error-case handling.Handle when
xt_register_template()returns an error value.This was identified with the clang-analyzer's Dead-Store analysis.
This needs to go to nf-next.
Quoted 7 lines · Lukas Bulwahn
Commit
fdacd57c79b7("netfilter:x_tables: never register tables by default") introduces the functionxt_register_template(), and in one case, a call to that function was missing the error-case handling.Handle when
xt_register_template()returns an error value.This was identified with the clang-analyzer's Dead-Store analysis.
Applied, thanks.