Skip to contentSkip to conversation

file: fix close_on_exec for multithreaded decompression

PATCH New Changqing Li 1 participant 1 message Aug 24, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 file: fix close_on_exec for multithreaded decompression

From: Changqing Li <[email protected]>

It is not safe to call the 'file' command from multiple threads. When a file is checked with multiple threads in parallel, the file descriptors might get shared which makes the pipe handling lock up, leading to lock up in rpmbuild. And may lead to rarely deadlock on random recipes's do_package task.

---
 meta/recipes-devtools/file/file_5.39.bb       |   3 +-
 ...ec-multithreaded-decompression-issue.patch | 220 ++++++++++++++++++
 2 files changed, 222 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/file/files/0001-Fix-close_on_exec-multithreaded-decompression-issue.patch
meta/recipes-devtools/file/file_5.39.bb +2 -1
index abaa8149a3..c0c7253688 100644
@@ -12,7 +12,8 @@ DEPENDS = "file-replacement-native"
 DEPENDS_class-native = "bzip2-replacement-native"
 
 SRC_URI = "git://github.com/file/file.git \
-           file://0001-src-compress.c-correct-header-define-for-xz-lzma.patch"
+           file://0001-src-compress.c-correct-header-define-for-xz-lzma.patch \
+           file://0001-Fix-close_on_exec-multithreaded-decompression-issue.patch"
 
 SRCREV = "87731415de945660b00f02207d8e9d986ef9b82e"
 S = "${WORKDIR}/git"
meta/recipes-devtools/file/files/0001-Fix-close_on_exec-multithreaded-decompression-issue.patch new file +220 -0

220 lines not on this page · raw message

Signature · 1 line
2.17.1