pinctrl: mediatek: moore: check if pin_desc is valid before use
Subsystems (8)
PATCH v3 4/12 pinctrl: mediatek: moore: check if pin_desc is valid before use
Certain SoC are missing the middle part gpios in consecutive pins, it's better to check if mtk_pin_desc is a valid pin for the extensibility
---
v3: added an Acked-by tag.
v2: applied the comment suggested by reviewers:
- for the pins not ballout, we can fill .name in struct mtk_pin_desc as NULL and return -ENOTSUPP in gpio/pinconf ops.
--- drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/pinctrl/mediatek/pinctrl-moore.c +18 -0
@@ -60,6 +60,8 @@ static int mtk_pinmux_set_mux(struct pinctrl_dev *pctldev,int pin = grp->pins[i]; desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin]; +if (!desc->name) +return -ENOTSUPP ;mtk_hw_set_value (hw, desc,PINCTRL_PIN_REG_MODE , pin_modes[i]);
@@ -76,6 +78,8 @@ static int mtk_pinmux_gpio_request_enable(struct pinctrl_dev *pctldev,const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin]; +if (!desc->name) +return -ENOTSUPP ;return mtk_hw_set_value (hw, desc,PINCTRL_PIN_REG_MODE , hw->soc->gpio_m);
@@ -89,6 +93,8 @@ static int mtk_pinmux_gpio_set_direction(struct pinctrl_dev *pctldev,const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin]; +if (!desc->name) +return -ENOTSUPP ;/* hardware would take 0 as input direction */ return mtk_hw_set_value (hw, desc,PINCTRL_PIN_REG_DIR , !input);
@@ -103,6 +109,8 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin]; +if (!desc->name) +return -ENOTSUPP ;switch (param) {case PIN_CONFIG_BIAS_DISABLE :
@@ -218,6 +226,8 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,int cfg, err =0 ; desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin]; +if (!desc->name) +return -ENOTSUPP ;for (cfg =0 ; cfg < num_configs; cfg++) { param =pinconf_to_config_param (configs[cfg]);
@@ -435,6 +445,8 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)int value, err; desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; +if (!desc->name) +return -ENOTSUPP ; err =mtk_hw_get_value (hw, desc,PINCTRL_PIN_REG_DI , &value);if (err)
@@ -449,6 +461,10 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value)const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; +if (!desc->name) { +dev_err (hw->dev,"Failed to set gpio %d\n" , gpio); +return ; + }mtk_hw_set_value (hw, desc,PINCTRL_PIN_REG_DO , !!value); }
@@ -490,6 +506,8 @@ static int mtk_gpio_set_config(struct gpio_chip *chip, unsigned int offset,u32 debounce; desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset]; +if (!desc->name) +return -ENOTSUPP ; if (!hw->eint || pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE ||
Signature · 1 line
2.29.2
PATCH v3 6/12 pinctrl: mediatek: add support for MT7986 SoC
This commit includes pinctrl driver for Mediatek MT7986
The difference of pinctrl between mt7986a and mt7986b is that pin-41 to pin-65 do not exist on mt7986b
---
v3: applied the comment suggested by reviewers:
- merge the consecutive entries into one to reduce the table size
- set .name to NULL to indicate the pin is not ball out
v2: applied the comment suggested by reviewers:
- for the pins not ballout, we can fill .name in struct mtk_pin_desc as NULL and return -ENOTSUPP in gpio/pinconf ops.
--- drivers/pinctrl/mediatek/Kconfig | 7 + drivers/pinctrl/mediatek/Makefile | 1 + drivers/pinctrl/mediatek/pinctrl-mt7986.c | 928 ++++++++++++++++++++++ 3 files changed, 936 insertions(+) create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt7986.c
drivers/pinctrl/mediatek/Kconfig +7 -0
@@ -119,6 +119,13 @@ config PINCTRL_MT7622 default ARM64 && ARCH_MEDIATEK select PINCTRL_MTK_MOORE +config PINCTRL_MT7986 + bool "Mediatek MT7986 pin control" + depends on OF + depends on ARM64 || COMPILE_TEST + default ARM64 && ARCH_MEDIATEK + select PINCTRL_MTK_MOORE + config PINCTRL_MT8167 bool "Mediatek MT8167 pin control" depends on OF
drivers/pinctrl/mediatek/Makefile +1 -0
@@ -17,6 +17,7 @@ obj-$(CONFIG_PINCTRL_MT6797) += pinctrl-mt6797.o obj-$(CONFIG_PINCTRL_MT7622) += pinctrl-mt7622.o obj-$(CONFIG_PINCTRL_MT7623) += pinctrl-mt7623.o obj-$(CONFIG_PINCTRL_MT7629) += pinctrl-mt7629.o +obj-$(CONFIG_PINCTRL_MT7986) += pinctrl-mt7986.o obj-$(CONFIG_PINCTRL_MT8167) += pinctrl-mt8167.o obj-$(CONFIG_PINCTRL_MT8173) += pinctrl-mt8173.o obj-$(CONFIG_PINCTRL_MT8183) += pinctrl-mt8183.o
drivers/pinctrl/mediatek/pinctrl-mt7986.c new file +928 -0
928 lines not on this page · raw message
Signature · 1 line
2.29.2