iavf: fix double unlock of crit_lock
Subsystems (3)
PATCH 1/1 iavf: fix double unlock of crit_lock
The crit_lock mutex could be unlocked twice as reported here
https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20210823/025525.html
Remove the superfluous unlock. Technically the problem was already present before 5ac49f3c2702 as that commit only replaced the locking primitive, but no functional change.
Reported-by Dan Carpenter <[email protected]>
Fixes 5ac49f3c2702 ("iavf: use mutexes for locking of critical sections")
Fixes bac8486116b0 ("iavf: Refactor the watchdog state machine")
Signed-off-by Stefan Assmann <[email protected]>
--- drivers/net/ethernet/intel/iavf/iavf_main.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/intel/iavf/iavf_main.c +0 -1
@@ -1965,7 +1965,6 @@ static void iavf_watchdog_task(struct work_struct *work) } adapter->aq_required =0 ; adapter->current_op =VIRTCHNL_OP_UNKNOWN ; -mutex_unlock (&adapter->crit_lock);queue_delayed_work (iavf_wq, &adapter->watchdog_task,msecs_to_jiffies (10 ));
Signature · 1 line
2.31.1