ARM: dts: keystone-k2*-evm: Fix mdio and dss node status
v2 cover ARM: dts: keystone-k2*-evm: Fix mdio and dss node status
Hi Santosh,
This series fixes mdio and dss status nodes from "ok" to "okay"
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
cheers,
-roger
Roger Quadros (2):
ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/2 ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
--- arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/keystone-k2e-evm.dts +1 -1
@@ -159,7 +159,7 @@ }; &mdio { - status = "ok"; + status = "okay"; ethphy0: ethernet-phy@0 { compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22"; reg = <0>;
arch/arm/boot/dts/keystone-k2hk-evm.dts +1 -1
@@ -183,7 +183,7 @@ }; &mdio { - status = "ok"; + status = "okay"; ethphy0: ethernet-phy@0 { compatible = "marvell,88E1111", "ethernet-phy-ieee802.3-c22"; reg = <0>;
arch/arm/boot/dts/keystone-k2l-evm.dts +1 -1
@@ -132,7 +132,7 @@ }; &mdio { - status = "ok"; + status = "okay"; ethphy0: ethernet-phy@0 { compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22"; reg = <0>;
Signature · 1 line
2.17.1
Re: [PATCH v2 1/2] ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
Quoted 8 lines · Roger Quadros
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
Quoted 7 lines
Cc Grygorii Strashko <[email protected]>Signed-off-by Roger Quadros <[email protected]>--- arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Thank you.
Signature · 2 lines
Best regards, grygorii
PATCH v2 2/2 ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
In reply to Roger QuadrosAs per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
--- arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/keystone-k2g-evm.dts +1 -1
@@ -534,7 +534,7 @@ &dss { pinctrl-names = "default"; pinctrl-0 = <&vout_pins>; - status = "ok"; + status = "okay"; port { dpi_out: endpoint {
Signature · 1 line
2.17.1
Quoted 19 lines · Roger Quadros
Hi Santosh,
This series fixes mdio and dss status nodes from "ok" to "okay"
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
cheers,
-rogerRoger Quadros (2):
ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
Quoted 6 lines
arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Changes in this version:
- updated commit message to point to DT spec instead of schema.
Quoted 9 lines · Roger Quadros
Hi Santosh,
This series fixes mdio and dss status nodes from "ok" to "okay"
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
^^ I suspect the above comment in the patches is to indicate side effect of non-compliance.
Quoted 9 lines
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
cheers,
-rogerRoger Quadros (2):
ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Hi Santosh
Quoted 20 lines · Nishanth Menon
Quoted 9 lines · Roger Quadros
Hi Santosh,
This series fixes mdio and dss status nodes from "ok" to "okay"
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
^^ I suspect the above comment in the patches is to indicate side effect of non-compliance.
Quoted 6 lines
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
cheers,
-roger
Quoted 7 lines
Quoted 3 lines
Roger Quadros (2):
ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"Reviewed-by Nishanth Menon <[email protected]>
Is there a chance to still pull these in for -next? Thanks.
cheers,
-roger
Hi Santosh
Quoted 11 lines · Roger Quadros
Hi Santosh,
This series fixes mdio and dss status nodes from "ok" to "okay"
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
Could you please queue these trivial fixes for 5.15? Thanks
Quoted 8 lines
cheers,
-rogerRoger Quadros (2):
ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
Quoted 6 lines
arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
cheers,
-roger