Skip to contentSkip to conversation

drm/i915/gt: do_idle_maps on gen8 and later platform.

PATCH New Lee Shawn C 2 participants 3 messages Aug 25, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gt: do_idle_maps on gen8 and later platform.

We are seeing "DMAR faults [reason 7, next page table ptr is invalid]" on TGL while running suspend stress test. Refer to 'commit 84361529ee85 ("drm/i915: Sleep around performing iommu unmaps on Tigerlake")'. Driver check needs_idle_maps() in i915_gmch_probe() but it applicable for gen5 and earlier generations. Add needs_idle_maps() in gen8_gmch_probe() then it will benifit gen8 and later platform.

Cc Chris Wilson <[email protected]>
Cc Mika Kuoppala <[email protected]>
Cc Ville Syrjala <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Cooper Chiou <[email protected]>
Cc Huang Derek <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/gt/intel_ggtt.c +6 -0
index de3ac58fceec..9510da0ae6b5 100644
@@ -911,6 +911,12 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
 
 	ggtt->vm.alloc_pt_dma = alloc_pt_dma;
 
+	if (needs_idle_maps(i915)) {
+		drm_notice(&i915->drm,
+			   "Flushing DMA requests before IOMMU unmaps; performance may be degraded\n");
+		ggtt->do_idle_maps = true;
+	}
+
 	ggtt->vm.total = (size / sizeof(gen8_pte_t)) * I915_GTT_PAGE_SIZE;
 	ggtt->vm.cleanup = gen6_gmch_remove;
 	ggtt->vm.insert_page = gen8_ggtt_insert_page;
Signature · 1 line
2.17.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: do_idle_maps on gen8 and later platform.

== Series Details ==

== Series Details ==

Series: drm/i915/gt: do_idle_maps on gen8 and later platform.
URL : https://patchwork.freedesktop.org/series/93982/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9bafb3e2db7c drm/i915/gt: do_idle_maps on gen8 and later platform.
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
for gen5 and earlier generations. Add needs_idle_maps() in gen8_gmch_probe()

total: 0 errors, 1 warnings, 0 checks, 12 lines checked

#2 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: do_idle_maps on gen8 and later platform.

In reply to Lee Shawn C
== Series Details ==

== Series Details ==

Series: drm/i915/gt: do_idle_maps on gen8 and later platform.
URL : https://patchwork.freedesktop.org/series/93982/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10518 -> Patchwork_20883
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_20883 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_20883, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_20883:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_parallel@engines@contexts:
- fi-rkl-11600: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10518/fi-rkl-11600/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-rkl-11600/igt@gem_exec_parallel@[email protected]

* igt@runner@aborted:
- fi-rkl-11600: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-rkl-11600/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_20883 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-kbl-soraka/igt@amdgpu/[email protected]

* igt@core_hotunplug@unbind-rebind:
- fi-rkl-guc: [PASS][5] -> [DMESG-WARN][6] ([i915#3925])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10518/fi-rkl-guc/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-rkl-guc/igt@[email protected]

* igt@gem_exec_parallel@engines@userptr:
- fi-pnv-d510: [PASS][7] -> [INCOMPLETE][8] ([i915#299])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10518/fi-pnv-d510/igt@gem_exec_parallel@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-pnv-d510/igt@gem_exec_parallel@[email protected]

* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][9] ([i915#2403] / [i915#2722])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-pnv-d510/igt@[email protected]
- fi-rkl-guc: NOTRUN -> [FAIL][10] ([i915#1602])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-rkl-guc/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [SKIP][11] ([fdo#109271]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10518/fi-kbl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-kbl-guc/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][13] ([i915#2291] / [i915#541]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10518/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][15] ([i915#2868]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10518/fi-kbl-7500u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#3925]: https://gitlab.freedesktop.org/drm/intel/issues/3925
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (40 -> 33)
------------------------------

Missing (7): fi-ilk-m540 bat-adls-5 fi-hsw-4200u fi-tgl-1115g4 fi-bsw-cyan fi-bdw-samus bat-jsl-1

Build changes
-------------

* Linux: CI_DRM_10518 -> Patchwork_20883

CI-20190529: 20190529
CI_DRM_10518: 7e90f75d257e7cc6865cab2cfed1d8534b2ccd20 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6185: 5dca04416f50576f464ebbd9aea96edccd7e4eab @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20883: 9bafb3e2db7c493bb8c85e7fcdf4ef1c3d86fe42 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

9bafb3e2db7c drm/i915/gt: do_idle_maps on gen8 and later platform.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20883/index.html