Skip to contentSkip to conversation

libcgroup: remove static pam library

PATCH In review kai 2 participants 3 messages Aug 25, 2021 – Aug 26, 2021

lore
Share & tools
lore

kai

author
#0 lore raw

PATCH 1/1 libcgroup: remove static pam library

From: Kai Kang <[email protected]>

libpam disables static build by default, so remove static pam library of libcgroup. Otherwise it complains QA issue:

| ERROR: libcgroup-2.0-r0 do_package: QA Issue: libcgroup:
Files/directories were installed but not shipped in any package:
| /lib/security/pam_cgroup.a

---
 meta/recipes-core/libcgroup/libcgroup_2.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/libcgroup/libcgroup_2.0.bb +1 -0
index bc0a75d46c..f48b8ece9b 100644
@@ -31,4 +31,5 @@ FILES:${PN}-dev += "${base_libdir}/security/*.la"
 do_install:append() {
 	# Until we ship the test suite, this library isn't useful
 	rm -f ${D}${libdir}/libcgroupfortesting.*
+	rm -f ${D}${base_libdir}/security/pam_cgroup.a
 }
Signature · 1 line
2.17.1
#1 lore raw
Quoted 20 lines · kai

From: Kai Kang <[email protected]>

libpam disables static build by default, so remove static pam library of libcgroup. Otherwise it complains QA issue:

| ERROR: libcgroup-2.0-r0 do_package: QA Issue: libcgroup:
Files/directories were installed but not shipped in any package:
| /lib/security/pam_cgroup.a

---
  meta/recipes-core/libcgroup/libcgroup_2.0.bb | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-core/libcgroup/libcgroup_2.0.bb +0 -0
index bc0a75d46c..f48b8ece9b 100644

meta/recipes-core/libcgroup/libcgroup_2.0.bb FILES:${PN}-dev += "${base_libdir}/security/*.la" · line 35

Quoted 5 lines
meta/recipes-core/libcgroup/libcgroup_2.0.bb +1 -0
@@ -31,4 +31,5 @@ FILES:${PN}-dev += "${base_libdir}/security/*.la"
  do_install:append() {
  	# Until we ship the test suite, this library isn't useful
  	rm -f ${D}${libdir}/libcgroupfortesting.*
+	rm -f ${D}${base_libdir}/security/pam_cgroup.a
  }

should this be simply packaged into FILES_${PN}-staticdev instead ?

Quoted 4 lines
author
#2 lore raw
Quoted 17 lines · Khem Raj
Quoted 14 lines · kai

From: Kai Kang <[email protected]>

libpam disables static build by default, so remove static pam library of libcgroup. Otherwise it complains QA issue:

| ERROR: libcgroup-2.0-r0 do_package: QA Issue: libcgroup:
          Files/directories were installed but not shipped in any package:
|  /lib/security/pam_cgroup.a

---
  meta/recipes-core/libcgroup/libcgroup_2.0.bb | 1 +

  1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 11 lines
meta/recipes-core/libcgroup/libcgroup_2.0.bb +0 -0
index bc0a75d46c..f48b8ece9b 100644
@@ -31,4 +31,5 @@ FILES:${PN}-dev += "${base_libdir}/security/*.la"
   do_install:append() {
       # Until we ship the test suite, this library isn't useful

      rm -f ${D}${libdir}/libcgroupfortesting.* +    rm -f ${D}${base_libdir}/security/pam_cgroup.a }

should this be simply packaged into FILES_${PN}-staticdev instead ?

OK. v2 will send.

Regards,
Kai

Quoted 5 lines
Quoted 5 lines
Signature · 2 lines
Kai Kang
Wind River Linux