Skip to contentSkip to conversation

iio: ltc2983: add support for optional reset gpio

PATCH In review Nuno Sá 2 participants 3 messages Aug 25, 2021 – Aug 30, 2021

Subsystems (2)
lore
Share & tools
lore

Nuno Sá

author maintainer
#0 lore raw

PATCH v2 1/2 iio: ltc2983: add support for optional reset gpio

Check if an optional reset gpio is present and if so, make sure to reset the device.

---
Changes in v2:

* Increased the 'usleep_range()' upper limit so that we get better chances for not having an IRQ triggered by the hrtimers.

 drivers/iio/temperature/ltc2983.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/iio/temperature/ltc2983.c +11 -0
index 3b4a0e60e605..22e6a26ce6b1 100644
@@ -1470,6 +1470,7 @@ static int ltc2983_probe(struct spi_device *spi)
 {
 	struct ltc2983_data *st;
 	struct iio_dev *indio_dev;
+	struct gpio_desc *gpio;
 	const char *name = spi_get_device_id(spi)->name;
 	int ret;
 
@@ -1494,6 +1495,16 @@ static int ltc2983_probe(struct spi_device *spi)
 	if (ret)
 		return ret;
 
+	gpio = devm_gpiod_get_optional(&st->spi->dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(gpio))
+		return PTR_ERR(gpio);
+
+	if (gpio) {
+		/* bring the device out of reset */
+		usleep_range(1000, 1200);
+		gpiod_set_value_cansleep(gpio, 0);
+	}
+
 	ret = ltc2983_setup(st, true);
 	if (ret)
 		return ret;
Signature · 1 line
2.33.0
author maintainer
#1 lore raw

PATCH v2 2/2 iio: ltc2983: fail probe if no channels are given

If there are no channels defined in the devicetree, there's no point in probing the device. We were actually requesting a zero sized 'kmalloc' array but since we were not touching the ZERO_SIZE_PTR afterwards, nothing bad was actually happening. Hence this is not really a fix but rather an improvement.

---
Nothing changed in v2.

 drivers/iio/temperature/ltc2983.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/iio/temperature/ltc2983.c +5 -0
index 22e6a26ce6b1..301c3f13fb26 100644
@@ -1275,6 +1275,11 @@ static int ltc2983_parse_dt(struct ltc2983_data *st)
 			     &st->filter_notch_freq);
 
 	st->num_channels = of_get_available_child_count(dev->of_node);
+	if (!st->num_channels) {
+		dev_err(&st->spi->dev, "At least one channel must be given!");
+		return -EINVAL;
+	}
+
 	st->sensors = devm_kcalloc(dev, st->num_channels, sizeof(*st->sensors),
 				   GFP_KERNEL);
 	if (!st->sensors)
Signature · 1 line
2.33.0
maintainer
#2 lore raw

Re: [PATCH v2 2/2] iio: ltc2983: fail probe if no channels are given

Quoted 8 lines · On Wed, 25 Aug 2021 10:41:49 +0200 Nuno Sá <[email protected]> wrote:

If there are no channels defined in the devicetree, there's no point in probing the device. We were actually requesting a zero sized 'kmalloc' array but since we were not touching the ZERO_SIZE_PTR afterwards, nothing bad was actually happening. Hence this is not really a fix but rather an improvement.

Both applied.

Thanks,

J

Quoted 22 lines

---
Nothing changed in v2.

 drivers/iio/temperature/ltc2983.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/iio/temperature/ltc2983.c +5 -0
index 22e6a26ce6b1..301c3f13fb26 100644
@@ -1275,6 +1275,11 @@ static int ltc2983_parse_dt(struct ltc2983_data *st)
 			     &st->filter_notch_freq);
 
 	st->num_channels = of_get_available_child_count(dev->of_node);
+	if (!st->num_channels) {
+		dev_err(&st->spi->dev, "At least one channel must be given!");
+		return -EINVAL;
+	}
+
 	st->sensors = devm_kcalloc(dev, st->num_channels, sizeof(*st->sensors),
 				   GFP_KERNEL);
 	if (!st->sensors)