USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions
Subsystems (2)
PATCH 1/1 USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions
This fixed the below checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
--- drivers/usb/serial/iuu_phoenix.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/usb/serial/iuu_phoenix.c +5 -5
@@ -1188,20 +1188,20 @@ MODULE_AUTHOR("Alain Degreffe [email protected]");MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL" ); -module_param (xmas, bool,S_IRUGO |S_IWUSR ); +module_param (xmas, bool,0644 );MODULE_PARM_DESC (xmas,"Xmas colors enabled or not" ); -module_param (boost, int,S_IRUGO |S_IWUSR ); +module_param (boost, int,0644 );MODULE_PARM_DESC (boost,"Card overclock boost (in percent 100-500)" ); -module_param (clockmode, int,S_IRUGO |S_IWUSR ); +module_param (clockmode, int,0644 );MODULE_PARM_DESC (clockmode,"Card clock mode (1=3.579 MHz, 2=3.680 MHz, " "3=6 Mhz)" ); -module_param (cdmode, int,S_IRUGO |S_IWUSR ); +module_param (cdmode, int,0644 );MODULE_PARM_DESC (cdmode,"Card detect mode (0=none, 1=CD, 2=!CD, 3=DSR, " "4=!DSR, 5=CTS, 6=!CTS, 7=RING, 8=!RING)" ); -module_param (vcc_default, int,S_IRUGO |S_IWUSR ); +module_param (vcc_default, int,0644 );MODULE_PARM_DESC (vcc_default,"Set default VCC (either 3 for 3.3V or 5 " "for 5V). Default to 5." );
Signature · 1 line
2.17.1
Johan Hovold
maintainerQuoted 3 lines · Utkarsh Verma
This fixed the below checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO|S_IWUSR' are not preferred. Consider using octal permissions '0644'.
Please do not run checkpatch.pl on code that's already in the tree. Use it for your own patches before submitting them and always use your own judgement when considering its suggestions.
This code does not need to be changed.
Johan
Quoted 9 lines · Johan Hovold
Quoted 3 lines · Utkarsh Verma
This fixed the below checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO|S_IWUSR' are not preferred. Consider using octal permissions '0644'.Please do not run checkpatch.pl on code that's already in the tree. Use it for your own patches before submitting them and always use your own judgement when considering its suggestions.
Okay, I will not run checkpatch on the code that's already in the tree.
Quoted 2 lines
This code does not need to be changed.
But using the octal permission bits makes the code more readable. So I made the change.
But if you don't want such changes, I will refrain from doing it in the future.
Anyway thanks for the review.
Regards,
Utkarsh Verma
Johan Hovold
maintainerQuoted 11 lines · Utkarsh Verma
Quoted 9 lines · Johan Hovold
Quoted 3 lines · Utkarsh Verma
This fixed the below checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO|S_IWUSR' are not preferred. Consider using octal permissions '0644'.Please do not run checkpatch.pl on code that's already in the tree. Use it for your own patches before submitting them and always use your own judgement when considering its suggestions.
Quoted 6 lines
Okay, I will not run checkpatch on the code that's already in the tree.
Quoted 1 line
This code does not need to be changed.
But using the octal permission bits makes the code more readable. So I made the change.
Then put that in the commit message since that may be a valid motivation for the change (unlike shutting up checkpatch.pl).
But if you want to do this then do it subsystem wide in one patch rather than change only one of the seven usb-serial drivers that use the permission macros.
Johan
PATCH v2 1/1 USB: serial: Replace symbolic permissions by octal permissions
Replace symbolic permission macros with octal permission numbers because, octal permission numbers are easier to read and understand instead of their symbolic macro names.
No functional change.
--- drivers/usb/serial/cypress_m8.c | 6 +++--- drivers/usb/serial/ftdi_sio.c | 2 +- drivers/usb/serial/garmin_gps.c | 2 +- drivers/usb/serial/io_ti.c | 4 ++-- drivers/usb/serial/ipaq.c | 4 ++-- drivers/usb/serial/iuu_phoenix.c | 10 +++++----- drivers/usb/serial/sierra.c | 2 +- 7 files changed, 15 insertions(+), 15 deletions(-)
drivers/usb/serial/cypress_m8.c +3 -3
@@ -1199,9 +1199,9 @@ MODULE_AUTHOR(DRIVER_AUTHOR);MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL" ); -module_param (stats, bool,S_IRUGO |S_IWUSR ); +module_param (stats, bool,0644 );MODULE_PARM_DESC (stats,"Enable statistics or not" ); -module_param (interval, int,S_IRUGO |S_IWUSR ); +module_param (interval, int,0644 );MODULE_PARM_DESC (interval,"Overrides interrupt interval" ); -module_param (unstable_bauds, bool,S_IRUGO |S_IWUSR ); +module_param (unstable_bauds, bool,0644 );MODULE_PARM_DESC (unstable_bauds,"Allow unstable baud rates" );
drivers/usb/serial/ftdi_sio.c +1 -1
@@ -2938,5 +2938,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL" ); -module_param (ndi_latency_timer, int,S_IRUGO |S_IWUSR ); +module_param (ndi_latency_timer, int,0644 );MODULE_PARM_DESC (ndi_latency_timer,"NDI device latency timer override" );
drivers/usb/serial/garmin_gps.c +1 -1
@@ -1444,5 +1444,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL" ); -module_param (initial_mode, int,S_IRUGO ); +module_param (initial_mode, int,0444 );MODULE_PARM_DESC (initial_mode,"Initial mode" );
drivers/usb/serial/io_ti.c +2 -2
@@ -2746,9 +2746,9 @@ MODULE_DESCRIPTION(DRIVER_DESC);MODULE_LICENSE ("GPL" );MODULE_FIRMWARE ("edgeport/down3.bin" ); -module_param (ignore_cpu_rev, bool,S_IRUGO |S_IWUSR ); +module_param (ignore_cpu_rev, bool,0644 );MODULE_PARM_DESC (ignore_cpu_rev,"Ignore the cpu revision when connecting to a device" ); -module_param (default_uart_mode, int,S_IRUGO |S_IWUSR ); +module_param (default_uart_mode, int,0644 );MODULE_PARM_DESC (default_uart_mode,"Default uart_mode, 0=RS232, ..." );
drivers/usb/serial/ipaq.c +2 -2
@@ -599,10 +599,10 @@ MODULE_AUTHOR(DRIVER_AUTHOR);MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL" ); -module_param (connect_retries, int,S_IRUGO |S_IWUSR ); +module_param (connect_retries, int,0644 );MODULE_PARM_DESC (connect_retries,"Maximum number of connect retries (one second each)" ); -module_param (initial_wait, int,S_IRUGO |S_IWUSR ); +module_param (initial_wait, int,0644 );MODULE_PARM_DESC (initial_wait,"Time to wait before attempting a connection (in seconds)" );
drivers/usb/serial/iuu_phoenix.c +5 -5
@@ -1188,20 +1188,20 @@ MODULE_AUTHOR("Alain Degreffe [email protected]");MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL" ); -module_param (xmas, bool,S_IRUGO |S_IWUSR ); +module_param (xmas, bool,0644 );MODULE_PARM_DESC (xmas,"Xmas colors enabled or not" ); -module_param (boost, int,S_IRUGO |S_IWUSR ); +module_param (boost, int,0644 );MODULE_PARM_DESC (boost,"Card overclock boost (in percent 100-500)" ); -module_param (clockmode, int,S_IRUGO |S_IWUSR ); +module_param (clockmode, int,0644 );MODULE_PARM_DESC (clockmode,"Card clock mode (1=3.579 MHz, 2=3.680 MHz, " "3=6 Mhz)" ); -module_param (cdmode, int,S_IRUGO |S_IWUSR ); +module_param (cdmode, int,0644 );MODULE_PARM_DESC (cdmode,"Card detect mode (0=none, 1=CD, 2=!CD, 3=DSR, " "4=!DSR, 5=CTS, 6=!CTS, 7=RING, 8=!RING)" ); -module_param (vcc_default, int,S_IRUGO |S_IWUSR ); +module_param (vcc_default, int,0644 );MODULE_PARM_DESC (vcc_default,"Set default VCC (either 3 for 3.3V or 5 " "for 5V). Default to 5." );
drivers/usb/serial/sierra.c +1 -1
@@ -1056,5 +1056,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);MODULE_DESCRIPTION (DRIVER_DESC );MODULE_LICENSE ("GPL v2" ); -module_param (nmea, bool,S_IRUGO |S_IWUSR ); +module_param (nmea, bool,0644 );MODULE_PARM_DESC (nmea,"NMEA streaming" );
Signature · 1 line
2.17.1
Johan Hovold
maintainerRe: [PATCH v2] USB: serial: Replace symbolic permissions by octal permissions
Quoted 8 lines · Utkarsh Verma
Replace symbolic permission macros with octal permission numbers because, octal permission numbers are easier to read and understand instead of their symbolic macro names.
No functional change.
Suggested-by Lukas Bulwahn <[email protected]>Signed-off-by Utkarsh Verma <[email protected]>
Thanks for the update. Now applied.
Johan