Skip to contentSkip to conversation

perf tools: Fix *probe_vfs_getname.sh test failures

PATCH Applied James Clark 2 participants 2 messages Aug 25, 2021 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tools: Fix *probe_vfs_getname.sh test failures

The commit 4d6101f5fd5d ("perf probe: Clarify error message about not finding kernel modules debuginfo") changed the error message "Failed to find the path for kernel" to "Failed to find the path for the kernel".

Update the regex so that the tests still skip rather than fail when kernel debug symbols aren't present.

---
 tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/lib/probe_vfs_getname.sh +1 -1
index c2cc42daf924..5b17d916c555 100644
@@ -19,6 +19,6 @@ add_probe_vfs_getname() {
 }
 
 skip_if_no_debuginfo() {
-	add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for kernel|Debuginfo-analysis is not supported)" && return 2
+	add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)" && return 2
 	return 1
 }
Signature · 1 line
2.28.0
maintainer Applied
#1 lore raw

Em Wed, Aug 25, 2021 at 05:42:59PM +0100, James Clark escreveu:

Quoted 6 lines

The commit 4d6101f5fd5d ("perf probe: Clarify error message about not finding kernel modules debuginfo") changed the error message "Failed to find the path for kernel" to "Failed to find the path for the kernel".

Update the regex so that the tests still skip rather than fail when kernel debug symbols aren't present.

Thanks, applied.

- Arnaldo

Quoted 19 lines
---
 tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/lib/probe_vfs_getname.sh +1 -1
index c2cc42daf924..5b17d916c555 100644
@@ -19,6 +19,6 @@ add_probe_vfs_getname() {
 }
 
 skip_if_no_debuginfo() {
-	add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for kernel|Debuginfo-analysis is not supported)" && return 2
+	add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)" && return 2
 	return 1
 }
Signature · 1 line
2.28.0
Signature · 1 line
- Arnaldo