perf bpf: Fix memory leak during synthesis.
Ian Rogers
reviewerPATCH 1/1 perf bpf: Fix memory leak during synthesis.
BTF needs to be freed with btf_free.
--- tools/perf/util/bpf-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/bpf-event.c +1 -1
@@ -296,7 +296,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, out:free (info_linear); -free (btf); +btf__free (btf);return err ?-1 :0 ; }
Signature · 1 line
2.33.0.rc2.250.ged5fa647cd-goog
Quoted 12 lines · Ian Rogers
BTF needs to be freed with
btf_free.Signed-off-by Ian Rogers <[email protected]>--- tools/perf/util/bpf-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/bpf-event.c +0
-0
tools/perf/util/bpf-event.c static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, · line 299
Quoted 5 lines
tools/perf/util/bpf-event.c +1
-1@@ -296,7 +296,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, out:free (info_linear); -free (btf); +btf__free (btf);
Hi Ian,
Patch looks good to me. I can see in one more place we are using free(btf) in the
same file. Can you correct that as well.
Thanks,
Kajol Jain
Quoted 4 lines
tools/perf/util/bpf-event.c +0
-0return err ?-1 :0 ; }
Ian Rogers
reviewerQuoted 17 lines · kajoljain
Quoted 13 lines · Ian Rogers
BTF needs to be freed with
btf_free.Signed-off-by Ian Rogers <[email protected]>--- tools/perf/util/bpf-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/bpf-event.c +0
-0@@ -296,7 +296,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,
Quoted 8 lines
tools/perf/util/bpf-event.c static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, · line 299
Quoted 4 lines
tools/perf/util/bpf-event.c +1
-1out:free (info_linear); -free (btf); +btf__free (btf);Hi Ian,
Patch looks good to me. I can see in one more place we are using free(btf) in the
same file. Can you correct that as well.
Done. Also found 1 more in annotate :-)
https://lore.kernel.org/lkml/[email protected]/T/#u
Thanks,
Ian
Quoted 7 lines
Thanks,
Kajol JainQuoted 4 lines
tools/perf/util/bpf-event.c +0
-0return err ?-1 :0 ; }