exec: fix typo and grammar mistake in comment
Subsystems (2)
PATCH 1/1 exec: fix typo and grammar mistake in comment
From: Adrian Huang <[email protected]>
1. backwords -> backwards
2. Remove 'and'
--- fs/exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/exec.c +2 -2
@@ -533,7 +533,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,if (!valid_arg_len (bprm, len)) goto out; -/* We're going to work our way backwords. */ +/* We're going to work our way backwards. */ pos = bprm->p; str += len; bprm->p -= len;
@@ -600,7 +600,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv, }/* -* Copy and argument/environment string from the kernel to the processes stack. +* Copy argument/environment strings from the kernel to the processe's stack. */ int copy_string_kernel (const char *arg,struct linux_binprm *bprm) {
Signature · 1 line
2.27.0
Quoted 4 lines · Adrian Huang
From: Adrian Huang <[email protected]>
1. backwords -> backwards
2. Remove 'and'
3. correct the possessive form of "process"
Quoted 11 lines
Signed-off-by Adrian Huang <[email protected]>--- fs/exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/exec.c +0
-0
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 536
Quoted 4 lines
fs/exec.c +0
-1@@ -533,7 +533,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,if (!valid_arg_len (bprm, len)) goto out; -/* We're going to work our way backwords. */
That could just be a pun. Maybe Al knows...
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 603
Quoted 10 lines
fs/exec.c +2
-1+/* We're going to work our way backwards. */ pos = bprm->p; str += len; bprm->p -= len;@@ -600,7 +600,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv, }/* -* Copy and argument/environment string from the kernel to the processes stack. +* Copy argument/environment strings from the kernel to the processe's stack.
Either process's stack or process' stack. Not what is typed there. I prefer process's, just as this reference does:
https://forum.wordreference.com/threads/process-or-processs.1704502/
Quoted 4 lines
fs/exec.c +0
-0*/ int copy_string_kernel (const char *arg,struct linux_binprm *bprm) {
Signature · 1 line
~Randy
Quoted 23 lines · Randy Dunlap
Quoted 4 lines · Adrian Huang
From: Adrian Huang <[email protected]>
1. backwords -> backwards
2. Remove 'and'3. correct the possessive form of "process"
Quoted 14 lines
Signed-off-by Adrian Huang <[email protected]>--- fs/exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/exec.c +0
-0@@ -533,7 +533,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,if (!valid_arg_len (bprm, len)) goto out;
Quoted 3 lines
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 536
Quoted 1 line
fs/exec.c +0
-1-/* We're going to work our way backwords. */ That could just be a pun. Maybe Al knows...
Another comment in line 615 has the same sentence with 'backwards'.
(https://github.com/torvalds/linux/blob/master/fs/exec.c#L615).
So, one of them should be corrected.
Quoted 8 lines
Quoted 8 lines
fs/exec.c +1
-0+/* We're going to work our way backwards. */ pos = bprm->p; str += len; bprm->p -= len;@@ -600,7 +600,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv, }
Quoted 7 lines
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 603
Quoted 3 lines
fs/exec.c +1
-1/* -* Copy and argument/environment string from the kernel to the processes stack. +* Copy argument/environment strings from the kernel to the processe's stack. Either process's stack or process' stack. Not what is typed there. I prefer process's, just as this reference does:
https://forum.wordreference.com/threads/process-or-processs.1704502/
Oh, my bad. I should have deleted the letter 'e'. Thanks for this.
After Al confirms 'backwords', I'll also change "processes's" to "process's" in v2.
(https://github.com/torvalds/linux/blob/master/fs/exec.c#L507)
Quoted 9 lines
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 606
Quoted 4 lines
fs/exec.c +0
-0*/ int copy_string_kernel (const char *arg,struct linux_binprm *bprm) {--
~Randy
Quoted 24 lines · Huang Adrian
Quoted 23 lines · Randy Dunlap
Quoted 4 lines · Adrian Huang
From: Adrian Huang <[email protected]>
1. backwords -> backwards
2. Remove 'and'3. correct the possessive form of "process"
Quoted 14 lines
Signed-off-by Adrian Huang <[email protected]>--- fs/exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/exec.c +0
-0@@ -533,7 +533,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,if (!valid_arg_len (bprm, len)) goto out;
Quoted 8 lines
Quoted 3 lines
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 536
Quoted 1 line
fs/exec.c +0
-1-/* We're going to work our way backwords. */ That could just be a pun. Maybe Al knows...
Another comment in line 615 has the same sentence with 'backwards'.
(https://github.com/torvalds/linux/blob/master/fs/exec.c#L615).So, one of them should be corrected.
OK.
Quoted 11 lines
Quoted 11 lines
fs/exec.c static int copy_strings(int argc, struct user_arg_ptr argv, · line 603
Quoted 11 lines
fs/exec.c +2
-1+/* We're going to work our way backwards. */ pos = bprm->p; str += len; bprm->p -= len;@@ -600,7 +600,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv, }/* -* Copy and argument/environment string from the kernel to the processes stack. +* Copy argument/environment strings from the kernel to the processe's stack.
I think this one should be:
* Copy an argument/environment string from the kernel to the process's stack.
Quoted 13 lines
Quoted 3 lines
Either process's stack or process' stack. Not what is typed there. I prefer process's, just as this reference does:
https://forum.wordreference.com/threads/process-or-processs.1704502/Oh, my bad. I should have deleted the letter 'e'. Thanks for this.
After Al confirms 'backwords', I'll also change "processes's" to "process's" in v2.
(https://github.com/torvalds/linux/blob/master/fs/exec.c#L507)Quoted 3 lines
Quoted 3 lines
fs/exec.c +0
-0*/ int copy_string_kernel (const char *arg,struct linux_binprm *bprm) {
Signature · 1 line
~Randy