Skip to contentSkip to conversation

arm64: dts: renesas: beacon: Fix usb2_clksel

PATCH In review Adam Ford 2 participants 2 messages Aug 26, 2021 – Sep 21, 2021

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 arm64: dts: renesas: beacon: Fix usb2_clksel

The clock driver only sets the bit when extal is available and xtal is not. Remove the xtal references to properly set the clock selection bit.

Fixes 56bc54496f5d ("arm64: dts: renesas: beacon: Fix USB extal reference")
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +3 -1
index 090dc9c4f57b..9908ad90d398 100644
@@ -323,7 +323,9 @@ &sdhi3 {
 
 &usb2_clksel {
 	clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>,
-		  <&versaclock5 3>, <&usb3s0_clk>;
+		  <&versaclock5 3>;
+	clock-names = "ehci_ohci", "hs-usb-if",
+		      "usb_extal";
 	status = "okay";
 };
 
Signature · 1 line
2.25.1
#1 lore raw

Hi Adam,

Quoted 6 lines · Adam Ford

The clock driver only sets the bit when extal is available and xtal is not. Remove the xtal references to properly set the clock selection bit.

Fixes 56bc54496f5d ("arm64: dts: renesas: beacon: Fix USB extal reference")

Thanks for your patch!

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &sdhi3 { · line 328

Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +3 -1
@@ -323,7 +323,9 @@ &sdhi3 {
 
 &usb2_clksel {
        clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>,
-                 <&versaclock5 3>, <&usb3s0_clk>;
+                 <&versaclock5 3>;
+       clock-names = "ehci_ohci", "hs-usb-if",
+                     "usb_extal";

According to the bindings, there must be 4 clocks/clock-names.

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &sdhi3 { · line 330

Quoted 2 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0 -0
        status = "okay";
 };

Looking at the driver implementation, it determines the presence of the usb_extal and usb_xtal clocks by checking the clock rates. According to the schematics, USB_XTAL is left unconnected. Hence shouldn't you just remove the usb3s0_clk clock-frequency override from arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi instead?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds