Skip to contentSkip to conversation

drm/amdgpu: Enable S/G for Yellow Carp

PATCH In review Aaron Liu 2 participants 3 messages Aug 27, 2021

Subsystems (3)
lore
Share & tools
lore

Aaron Liu

author
#0 lore raw

PATCH 1/2 drm/amdgpu: Enable S/G for Yellow Carp

From: Nicholas Kazlauskas <[email protected]>

Missing code for Yellow Carp to enable scatter gather - follows how DCN21 support was added.

Tested that 8k framebuffer allocation and display can now succeed after applying the patch.

v2: Add hookup in DM

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +1 -0
index 8e5a7ac8c36f..7a7316731911 100644
@@ -522,6 +522,7 @@ uint32_t amdgpu_display_supported_domains(struct amdgpu_device *adev,
 			break;
 		case CHIP_RENOIR:
 		case CHIP_VANGOGH:
+		case CHIP_YELLOW_CARP:
 			domain |= AMDGPU_GEM_DOMAIN_GTT;
 			break;
 
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 drm/amd/display: setup system context for APUs

Scatter/gather is APU feature starting from carrizo. adev->apu_flags is not used for all APUs. adev->flags & AMD_IS_APU can be used for all APUs.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index e1e57e7465a7..7f311bba9735 100644
@@ -1327,7 +1327,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 	dc_hardware_init(adev->dm.dc);
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
-	if (adev->apu_flags) {
+	if ((adev->flags & AMD_IS_APU) && (adev->asic_type >= CHIP_CARRIZO)) {
 		struct dc_phy_addr_space_config pa_config;
 
 		mmhub_read_system_context(adev, &pa_config);
Signature · 1 line
2.25.1
#2 lore raw

RE: [PATCH 2/2] drm/amd/display: setup system context for APUs

[AMD Official Use Only]

Nice catch!

Series are Reviewed-by: Huang Rui <[email protected]>

Thanks,
Ray

-----Original Message-----
From: Liu, Aaron <[email protected]>
Sent: Friday, August 27, 2021 9:29 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Huang, Ray <[email protected]>; Kazlauskas, Nicholas <[email protected]>; Liu, Aaron <[email protected]>
Subject: [PATCH 2/2] drm/amd/display: setup system context for APUs

Scatter/gather is APU feature starting from carrizo. adev->apu_flags is not used for all APUs. adev->flags & AMD_IS_APU can be used for all APUs.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index e1e57e7465a7..7f311bba9735 100644
@@ -1327,7 +1327,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 	dc_hardware_init(adev->dm.dc);
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
-	if (adev->apu_flags) {
+	if ((adev->flags & AMD_IS_APU) && (adev->asic_type >= CHIP_CARRIZO)) {
 		struct dc_phy_addr_space_config pa_config;
 
 		mmhub_read_system_context(adev, &pa_config);
Signature · 1 line
2.25.1