Skip to contentSkip to conversation

dt-bindings: PCI: mediatek-gen3: Add support for MT8195

PATCH In review Jianjun Wang 2 participants 3 messages Aug 27, 2021 – Sep 2, 2021

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: PCI: mediatek-gen3: Add support for MT8195

MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.

---
 Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +3 -1
index 742206dbd965..93e09c3029b7 100644
@@ -48,7 +48,9 @@ allOf:
 
 properties:
   compatible:
-    const: mediatek,mt8192-pcie
+    enum:
+      - mediatek,mt8192-pcie
+      - mediatek,mt8195-pcie
 
   reg:
     maxItems: 1
Signature · 1 line
2.18.0
#1 lore raw
Quoted 13 lines · Jianjun Wang

MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.

---
 Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +0 -0
index 742206dbd965..93e09c3029b7 100644

Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml allOf: · line 53

Quoted 7 lines
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +3 -1
@@ -48,7 +48,9 @@ allOf:
 
 properties:
   compatible:
-    const: mediatek,mt8192-pcie
+    enum:
+      - mediatek,mt8192-pcie
+      - mediatek,mt8195-pcie

I thought you wanted to support 8192 as the fallback:

compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";

The above schema doesn't allow this.

Rob

#2 lore raw
Quoted 29 lines · Rob Herring
Quoted 17 lines · Jianjun Wang

MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.

---
 Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
+++-
 1 file changed, 3 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- gen3.yaml
index 742206dbd965..93e09c3029b7 100644

Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml allOf: · line 53

Quoted 7 lines
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +3 -1
@@ -48,7 +48,9 @@ allOf:
 
 properties:
   compatible:
-    const: mediatek,mt8192-pcie
+    enum:
+      - mediatek,mt8192-pcie
+      - mediatek,mt8195-pcie

I thought you wanted to support 8192 as the fallback:

Quoted 5 lines

compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";

The above schema doesn't allow this.

Rob

Hi Rob,

Yes, I want this fallback to support MT8195, but there are some un- documented warnings if I don't add its compatible string to the yaml file.

Do you have any suggestions in this case?

Thanks.