Remove unsupported features in SNR CPU model
v2 cover Remove unsupported features in SNR CPU model
Patch 1: https://lore.kernel.org/qemu-devel/[email protected]/
Patch 2 removes one more feature (core-capability) in Snowridge-v4 CPU model based on previous patch.
Chenyi Qiang (2):
target/i386: Remove split lock detect in Snowridge CPU model target/i386: Remove core-capability in Snowridge CPU model
target/i386/cpu.c | 9 +++++++++ 1 file changed, 9 insertions(+)
Signature · 1 line
2.17.1
PATCH v2 1/2 target/i386: Remove split lock detect in Snowridge CPU model
At present, there's no mechanism intelligent enough to virtualize split lock detection correctly. Remove it in Snowridge CPU model to avoid the feature exposure.
Message-Id: <[email protected]>
--- target/i386/cpu.c | 8 ++++++++ 1 file changed, 8 insertions(+)
target/i386/cpu.c +8 -0
@@ -3682,6 +3682,14 @@ static const X86CPUDefinition builtin_x86_defs[] = { { /* end of list */ }, }, }, + { + .version = 4, + .note = "no split lock detect", + .props = (PropValue[]) { + { "split-lock-detect", "off" }, + { /* end of list */ }, + }, + }, { /* end of list */ }, }, },
Signature · 1 line
2.17.1
PATCH v2 2/2 target/i386: Remove core-capability in Snowridge CPU model
In reply to Chenyi QiangBecause core-capability releated features are model-specific and KVM won't support it, remove the core-capability in CPU model to avoid the warning message.
--- target/i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
target/i386/cpu.c +2 -1
@@ -3684,9 +3684,10 @@ static const X86CPUDefinition builtin_x86_defs[] = { }, { .version = 4, - .note = "no split lock detect", + .note = "no split lock detect, no core-capability", .props = (PropValue []) { {"split-lock-detect" ,"off" }, + {"core-capability" ,"off" }, {/* end of list */ }, }, },
Signature · 1 line
2.17.1
Re: [PATCH v2 2/2] target/i386: Remove core-capability in Snowridge CPU model
Hi Eduardo,
Ping for this minor change.
Quoted 26 lines · Chenyi Qiang
Because core-capability releated features are model-specific and KVM won't support it, remove the core-capability in CPU model to avoid the warning message.
Signed-off-by Chenyi Qiang <[email protected]>--- target/i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)target/i386/cpu.c +2
-1@@ -3684,9 +3684,10 @@ static const X86CPUDefinition builtin_x86_defs[] = { }, { .version = 4, - .note = "no split lock detect", + .note = "no split lock detect, no core-capability", .props = (PropValue []) { {"split-lock-detect" ,"off" }, + {"core-capability" ,"off" }, {/* end of list */ }, }, },
Quoted 8 lines · Chenyi Qiang
Patch 1: https://lore.kernel.org/qemu-devel/[email protected]/
Patch 2 removes one more feature (core-capability) in Snowridge-v4 CPU model based on previous patch.
Chenyi Qiang (2):
target/i386: Remove split lock detect in Snowridge CPU model target/i386: Remove core-capability in Snowridge CPU model
Patch 2/2 queued (patch 1/2 was already merged). Thanks and apologies for the delay.
Signature · 1 line
Eduardo