staging: r8188eu: Provide a TODO file for this driver
PATCH v3 1/1 staging: r8188eu: Provide a TODO file for this driver
Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging.
---
v2->v3: Added a task suggested by Dan Carpenter <[email protected]>.v1->v2: According to reviews by Fabio Aiuto <[email protected]> and Greg K-H
<[email protected]>, remove "[] is currently in development...", indent and properly wrap the lines, remove the unnecessary last paragraph.
drivers/staging/r8188eu/TODO | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 drivers/staging/r8188eu/TODO
drivers/staging/r8188eu/TODO new file +13 -0
@@ -0,0 +1,13 @@ +To-do list: + +* Correct the coding style according to Linux guidelines; please read the document + at https://www.kernel.org/doc/html/latest/process/coding-style.html. +* Remove unnecessary debugging/printing macros; for those that are still needed + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). +* Remove dead code such as unusued functions, variables, fields, etc.. +* Use in-kernel API and remove unnecessary wrappers where possible. +* Fix bugs due to code that sleeps in atomic context. +* Remove the HAL layer and migrate its functionality into the relevant parts of + the driver. +* Switch to use LIB80211. +* Switch to use MAC80211.
Signature · 1 line
2.32.0
Quoted 37 lines · Fabio M. De Francesco
Provide a TODO file that lists the tasks that should be carried out in order to move this driver off
drivers/staging.Signed-off-by Fabio M. De Francesco <[email protected]>---
v2->v3: Added a task suggested by Dan Carpenter <[email protected]>.v1->v2: According to reviews by Fabio Aiuto <[email protected]> and Greg K-H
<[email protected]>, remove "[] is currently in development...", indent and properly wrap the lines, remove the unnecessary last paragraph.drivers/staging/r8188eu/TODO | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 drivers/staging/r8188eu/TODOdrivers/staging/r8188eu/TODO new file +13
-1@@ -0,0 +1,13 @@ +To-do list: + +* Correct the coding style according to Linux guidelines; please read the document + at https://www.kernel.org/doc/html/latest/process/coding-style.html. +* Remove unnecessary debugging/printing macros; for those that are still needed + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). +* Remove dead code such as unusued functions, variables, fields, etc.. +* Use in-kernel API and remove unnecessary wrappers where possible. +* Fix bugs due to code that sleeps in atomic context. +* Remove the HAL layer and migrate its functionality into the relevant parts of + the driver. +* Switch to use LIB80211. +* Switch to use MAC80211. --
Quoted 2 lines
2.32.0
Looks good to me. Thanks.
Regards,
Phil
drivers/staging/r8188eu/TODO line 13
Quoted 2 lines · Fabio M. De Francesco
drivers/staging/r8188eu/TODO new file +2
-0+* Switch to use LIB80211. +* Switch to use MAC80211.
You totally ignored my comment of yesterday!!!!! The driver will be converted to use CFG80211 - not eirher of those you quote, unless you are planning to convert to use mac80211. I am not.
Larry
Hello Larry,
Quoted 7 lines · Larry Finger
drivers/staging/r8188eu/TODO line 13
Quoted 2 lines · Fabio M. De Francesco
drivers/staging/r8188eu/TODO new file +2
-0+* Switch to use LIB80211. +* Switch to use MAC80211.You totally ignored my comment of yesterday!!!!! The driver will be converted to use CFG80211 - not eirher of those you quote, unless you are planning to convert to use mac80211. I am not.
I think Fabio took inspiration from other staging rtl* TODO files, (i.e. rtl8723bs which already supports cfg80211) where those items are listed and it's not related with the work you are donig with cfg80211.
Quoted 3 lines
Larry
thank you,
fabio
Quoted 9 lines · CEST Larry Finger
drivers/staging/r8188eu/TODO line 13
Quoted 2 lines · Fabio M. De Francesco
drivers/staging/r8188eu/TODO new file +2
-0+* Switch to use LIB80211. +* Switch to use MAC80211.You totally ignored my comment of yesterday!!!!! The driver will be converted to use CFG80211 - not eirher of those you quote, unless you are planning to convert to use mac80211. I am not.
Larry
Hi Larry,
To the contrary, I didn't mean to ignore your comment! At least, not voluntarily.
My confusion arises from the fact that, as far as 802.11 concerns, I know only that it is a family of standards that have to do with the lower two of the seven layers of the OSI protocol. I really don't know more than this: I cannot tell the difference between CFG/LIB/MAC80211.
I simply thought that they are complementary (each to the others) and that I should have removed "This work is currently..." without mentioning the cfg80211 task to not have someone to duplicate your work in progress.
Fabio Aiuto is right in guessing that I took those tasks from another TODO file.
Finally, I want to remember to you that (ahead of v1) I had asked Maintainers to do or help with doing this list and I clearly wrote that I didn't know what those tasks are and whether or not they are required.
I hope this message clarifies what I did and why.
Thanks,
Fabio
Quoted 26 lines · Fabio M. De Francesco
Provide a TODO file that lists the tasks that should be carried out in order to move this driver off
drivers/staging.Signed-off-by Fabio M. De Francesco <[email protected]>---
v2->v3: Added a task suggested by Dan Carpenter <[email protected]>.v1->v2: According to reviews by Fabio Aiuto <[email protected]> and Greg K-H
<[email protected]>, remove "[] is currently in development...", indent and properly wrap the lines, remove the unnecessary last paragraph.drivers/staging/r8188eu/TODO | 13 +++++++++++++ 1 file changed, 13 insertions(+)create mode 100644
drivers/staging/r8188eu/TODOdrivers/staging/r8188eu/TODO new file +3
-0@@ -0,0 +1,13 @@ +To-do list: + +* Correct the coding style according to Linux guidelines; please read the document
drivers/staging/r8188eu/TODO line 13
Quoted 10 lines
drivers/staging/r8188eu/TODO new file +10
-0+ at https://www.kernel.org/doc/html/latest/process/coding-style.html. +* Remove unnecessary debugging/printing macros; for those that are still needed + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). +* Remove dead code such as unusued functions, variables, fields, etc.. +* Use in-kernel API and remove unnecessary wrappers where possible. +* Fix bugs due to code that sleeps in atomic context. +* Remove the HAL layer and migrate its functionality into the relevant parts of + the driver. +* Switch to use LIB80211. +* Switch to use MAC80211.
I think, we can add an entry about error handling. There are _a lot_ function calls without proper error handling. rtw_read*() calls are on me, but others...
With regards,
Pavel Skripkin