Skip to contentSkip to conversation

test-runner: Fix verbose check for processes in namespaces

PATCH Applied Andrew Zaborowski 2 participants 2 messages Aug 28, 2021 – Aug 31, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-runner: Fix verbose check for processes in namespaces

Check whether verbose output is enabled for process name arg[0] before prepending the "ip netns exec" part to arg since arg[0] is going to be "ip" after that.

---
 tools/test-runner | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/test-runner +3 -3
index 8b244e99..42f140bf 100755
@@ -176,12 +176,12 @@ class Process(subprocess.Popen):
 			global config
 			self.ctx = config.ctx
 
-		if namespace:
-			args = ['ip', 'netns', 'exec', namespace] + args
-
 		if self.ctx.is_verbose(args[0], log=False):
 			self.verbose = True
 
+		if namespace:
+			args = ['ip', 'netns', 'exec', namespace] + args
+
 		if outfile:
 			self._append_outfile(outfile)
 
Signature · 1 line
2.30.2
#1 lore raw

Hi Andrew,

Quoted 6 lines · Andrew Zaborowski

Check whether verbose output is enabled for process name arg[0] before prepending the "ip netns exec" part to arg since arg[0] is going to be "ip" after that.

---
  tools/test-runner | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Regards,
-Denis