dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
Subsystems (3)
PATCH 1/2 dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
With the conversion of rockchip-usb-phy.yaml a long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects.
--- .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml +4 -7
@@ -11,13 +11,10 @@ maintainers: properties: compatible: - oneOf: - - const: rockchip,rk3288-usb-phy - - items: - - enum: - - rockchip,rk3066a-usb-phy - - rockchip,rk3188-usb-phy - - const: rockchip,rk3288-usb-phy + enum: + - rockchip,rk3066a-usb-phy + - rockchip,rk3188-usb-phy + - rockchip,rk3288-usb-phy "#address-cells": const: 1
Signature · 1 line
2.20.1
PATCH 2/2 ARM: dts: rockchip: remove usb-phy fallback string for rk3066a/rk3188
With the conversion of rockchip-usb-phy.yaml a long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects.
--- arch/arm/boot/dts/rk3066a.dtsi | 3 +-- arch/arm/boot/dts/rk3188.dtsi | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/rk3066a.dtsi +1 -2
@@ -681,8 +681,7 @@ compatible = "rockchip,rk3066-grf", "syscon", "simple-mfd"; usbphy: usbphy { - compatible = "rockchip,rk3066a-usb-phy", - "rockchip,rk3288-usb-phy"; + compatible = "rockchip,rk3066a-usb-phy"; #address-cells = <1>; #size-cells = <0>; status = "disabled";
arch/arm/boot/dts/rk3188.dtsi +1 -2
@@ -647,8 +647,7 @@ }; usbphy: usbphy { - compatible = "rockchip,rk3188-usb-phy", - "rockchip,rk3288-usb-phy"; + compatible = "rockchip,rk3188-usb-phy"; #address-cells = <1>; #size-cells = <0>; status = "disabled";
Signature · 1 line
2.20.1
Quoted 7 lines · Johan Jonker
With the conversion of
rockchip-usb-phy.yamla long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driverrockchip_usb2_phy.cdoes. The bits inGRF_UOC0_CON2for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects.
Quoted 5 lines
Signed-off-by Johan Jonker <[email protected]>--- .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
Heiko Stuebner
maintainerHi Vinod, Kishon,
Am Samstag, 28. August 2021, 13:12:17 CEST schrieb Johan Jonker:
Quoted 8 lines
With the conversion of
rockchip-usb-phy.yamla long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driverrockchip_usb2_phy.cdoes. The bits inGRF_UOC0_CON2for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects.Signed-off-by Johan Jonker <[email protected]>
are you picking up this patch or can I get an Ack to just apply it together with the dts patch2?
Thanks
Heiko
Quoted 27 lines
--- .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml +4
-7@@ -11,13 +11,10 @@ maintainers: properties: compatible: - oneOf: - - const: rockchip,rk3288-usb-phy - - items: - - enum: - - rockchip,rk3066a-usb-phy - - rockchip,rk3188-usb-phy - - const: rockchip,rk3288-usb-phy + enum: + - rockchip,rk3066a-usb-phy + - rockchip,rk3188-usb-phy + - rockchip,rk3288-usb-phy "#address-cells": const: 1
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 6 lines · Johan Jonker
With the conversion of
rockchip-usb-phy.yamla long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driverrockchip_usb2_phy.cdoes. The bits inGRF_UOC0_CON2for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects.
Applied, thanks
Signature · 1 line
~Vinod
Re: (subset) [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
In reply to Johan JonkerQuoted 6 lines · Johan Jonker
With the conversion of
rockchip-usb-phy.yamla long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driverrockchip_usb2_phy.cdoes. The bits inGRF_UOC0_CON2for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects.
Applied, thanks!
[2/2] ARM: dts: rockchip: remove usb-phy fallback string for rk3066a/rk3188
commit: 97ef6931208f7ab09f52dd291320aa53878aaa53
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>