Skip to contentSkip to conversation

KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page

PATCH Applied Jia He 3 participants 3 messages Aug 30, 2021 – Sep 6, 2021

Subsystems (3)
lore
Share & tools
lore

Jia He

author
#0 lore raw

PATCH 1/1 KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page

After reverting and restoring the fast tlb invalidation patch series, the mmio_cached is not removed. Hence a unused field is left in kvm_mmu_page.

Cc Sean Christopherson <[email protected]>
---
 arch/x86/kvm/mmu/mmu_internal.h | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kvm/mmu/mmu_internal.h +0 -1
index 35567293c1fd..3e6f21c1871a 100644
@@ -37,7 +37,6 @@ struct kvm_mmu_page {
 
 	bool unsync;
 	u8 mmu_valid_gen;
-	bool mmio_cached;
 	bool lpage_disallowed; /* Can't be replaced by an equiv large page */
 
 	/*
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jia He

After reverting and restoring the fast tlb invalidation patch series, the mmio_cached is not removed. Hence a unused field is left in kvm_mmu_page.

Cc Sean Christopherson <[email protected]>

There's also additional cleanup we can do to take advantage of the free byte. I'll include this patch in a follow-up mini-series to hopefully make life a bit easier for Paolo.

Thanks!

maintainer Applied
#2 lore raw
In reply to Jia He
Quoted 16 lines · Jia He

After reverting and restoring the fast tlb invalidation patch series, the mmio_cached is not removed. Hence a unused field is left in kvm_mmu_page.

Cc Sean Christopherson <[email protected]>
---
  arch/x86/kvm/mmu/mmu_internal.h | 1 -
  1 file changed, 1 deletion(-)
arch/x86/kvm/mmu/mmu_internal.h +0 -0
index 35567293c1fd..3e6f21c1871a 100644

arch/x86/kvm/mmu/mmu_internal.h struct kvm_mmu_page { · line 42

Quoted 7 lines
arch/x86/kvm/mmu/mmu_internal.h +0 -1
@@ -37,7 +37,6 @@ struct kvm_mmu_page {
 
  	bool unsync;
  	u8 mmu_valid_gen;
-	bool mmio_cached;
  	bool lpage_disallowed; /* Can't be replaced by an equiv large page */
 
  	/*

Queued, thanks.

Paolo