Skip to contentSkip to conversation

ASoC: mediatek: mt8195: add MTK_PMIC_WRAP dependency

PATCH In review Trevor Wu 3 participants 3 messages Aug 31, 2021 – Sep 1, 2021

Subsystems (3)
lore
Share & tools
lore

Trevor Wu

author
#0 lore raw

PATCH 1/1 ASoC: mediatek: mt8195: add MTK_PMIC_WRAP dependency

randconfig builds show the warning below,

WARNING: unmet direct dependencies detected for SND_SOC_MT6359
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MTK_PMIC_WRAP [=n]
Selected by [y]:
- SND_SOC_MT8195_MT6359_RT1019_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y]

Add a dependency to avoid it.

---
 sound/soc/mediatek/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mediatek/Kconfig +1 -1
index cf567a89f421..f6bf0f9c91e3 100644
@@ -197,7 +197,7 @@ config SND_SOC_MT8195
 config SND_SOC_MT8195_MT6359_RT1019_RT5682
 	tristate "ASoC Audio driver for MT8195 with MT6359 RT1019 RT5682 codec"
 	depends on I2C
-	depends on SND_SOC_MT8195
+	depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
 	select SND_SOC_MT6359
 	select SND_SOC_RT1015P
 	select SND_SOC_RT5682_I2C
Signature · 1 line
2.18.0
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Trevor Wu

randconfig builds show the warning below,

WARNING: unmet direct dependencies detected for SND_SOC_MT6359
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MTK_PMIC_WRAP [=n]
Selected by [y]:
- SND_SOC_MT8195_MT6359_RT1019_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y]

Add a dependency to avoid it.

Thanks.

Quoted 18 lines
---
  sound/soc/mediatek/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mediatek/Kconfig +1 -1
index cf567a89f421..f6bf0f9c91e3 100644
@@ -197,7 +197,7 @@ config SND_SOC_MT8195
  config SND_SOC_MT8195_MT6359_RT1019_RT5682
  	tristate "ASoC Audio driver for MT8195 with MT6359 RT1019 RT5682 codec"
  	depends on I2C
-	depends on SND_SOC_MT8195
+	depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
  	select SND_SOC_MT6359
  	select SND_SOC_RT1015P
  	select SND_SOC_RT5682_I2C
Signature · 1 line
~Randy
maintainer
#2 lore raw
In reply to Trevor Wu
Quoted 8 lines · Trevor Wu

randconfig builds show the warning below,

WARNING: unmet direct dependencies detected for SND_SOC_MT6359
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MTK_PMIC_WRAP [=n]
Selected by [y]:
- SND_SOC_MT8195_MT6359_RT1019_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y]

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: mt8195: add MTK_PMIC_WRAP dependency

      commit: cd5e4efde23ad8050921672ed777ec3f7aa310ec

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark