Skip to contentSkip to conversation

x86: Change SYS_LOAD_ADDR to 0x01000000

PATCH In review Tom Rini 2 participants 3 messages Aug 31, 2021

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 x86: Change SYS_LOAD_ADDR to 0x01000000

At least on qemu, and likely other platforms, a load address of 0x02000000 ends up without our protected range currently. Move this down to 0x01000000.

---
 Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Kconfig +2 -2
index 931a22806e4e..eaf48b80196f 100644
@@ -389,8 +389,8 @@ config SYS_LDSCRIPT
 
 config SYS_LOAD_ADDR
 	hex "Address in memory to use by default"
-	default 0x01000000 if ARCH_SOCFPGA
-	default 0x02000000 if PPC || X86
+	default 0x01000000 if ARCH_SOCFPGA || X86
+	default 0x02000000 if PPC
 	default 0x22000000 if MACH_SUN9I
 	default 0x42000000 if ARCH_SUNXI && !MACH_SUN9I
 	default 0x82000000 if ARCH_KEYSTONE || ARCH_OMAP2PLUS || ARCH_K3
Signature · 1 line
2.17.1
#1 lore raw

Hi Tom,

Quoted 4 lines · Tom Rini

At least on qemu, and likely other platforms, a load address of 0x02000000 ends up without our protected range currently. Move this down to 0x01000000.

What is the protected range?

Quoted 7 lines
---
 Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Regards,
Bin

author
#2 lore raw
Quoted 9 lines · Bin Meng

Hi Tom,

Quoted 4 lines · Tom Rini

At least on qemu, and likely other platforms, a load address of 0x02000000 ends up without our protected range currently. Move this down to 0x01000000.

What is the protected range?

That's a good question. I think we can disregard this patch for now. While I was sure I bisected this failure:
https://source.denx.de/u-boot/u-boot/-/jobs/315982#L216
to the default load address being populated to loadaddr, I'm not seeing it fail now locally like I was this morning. I think maybe I had mis-merged the SYS_LOAD_ADDR patch last night and cleaned that up as part of making this patch work.

Signature · 1 line
Tom