Skip to contentSkip to conversation

mkfs: warn about V4 deprecation when creating new V4 filesystems

PATCH In review Darrick J. Wong 2 participants 4 messages Aug 31, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mkfs: warn about V4 deprecation when creating new V4 filesystems

From: Darrick J. Wong <[email protected]>

The V4 filesystem format is deprecated in the upstream Linux kernel. In September 2025 it will be turned off by default in the kernel and five years after that, support will be removed entirely. Warn people formatting new filesystems with the old format, particularly since V4 is not the default.

---
 mkfs/xfs_mkfs.c |    9 +++++++++
 1 file changed, 9 insertions(+)
mkfs/xfs_mkfs.c +9 -0
index 53904677..b8c11ce9 100644
@@ -2103,6 +2103,15 @@ _("Directory ftype field always enabled on CRC enabled filesystems\n"));
 		}
 
 	} else {	/* !crcs_enabled */
+		/*
+		 * The V4 filesystem format is deprecated in the upstream Linux
+		 * kernel.  In September 2025 it will be turned off by default
+		 * in the kernel and in September 2030 support will be removed
+		 * entirely.
+		 */
+		fprintf(stdout,
+_("V4 filesystems are deprecated and will not be supported by future versions.\n"));
+
 		/*
 		 * The kernel doesn't support crc=0,finobt=1 filesystems.
 		 * If crcs are not enabled and the user has not explicitly
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

The V4 filesystem format is deprecated in the upstream Linux kernel. In September 2025 it will be turned off by default in the kernel and five years after that, support will be removed entirely. Warn people formatting new filesystems with the old format, particularly since V4 is not the default.

---
 mkfs/xfs_mkfs.c |    9 +++++++++
 1 file changed, 9 insertions(+)
mkfs/xfs_mkfs.c +2 -0
index 53904677..b8c11ce9 100644
@@ -2103,6 +2103,15 @@ _("Directory ftype field always enabled on CRC enabled filesystems\n"));
 		}
 
 	} else {	/* !crcs_enabled */
+		/*
+		 * The V4 filesystem format is deprecated in the upstream Linux

mkfs/xfs_mkfs.c _("Directory ftype field always enabled on CRC enabled filesystems\n")); · line 2117

Quoted 10 lines
mkfs/xfs_mkfs.c +7 -0
+		 * kernel.  In September 2025 it will be turned off by default
+		 * in the kernel and in September 2030 support will be removed
+		 * entirely.
+		 */
+		fprintf(stdout,
+_("V4 filesystems are deprecated and will not be supported by future versions.\n"));
+
 		/*
 		 * The kernel doesn't support crc=0,finobt=1 filesystems.
 		 * If crcs are not enabled and the user has not explicitly

Looks good to me.

Do we need to update the mkfs filter in fstests now?

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
Quoted 38 lines · Dave Chinner
Quoted 24 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

The V4 filesystem format is deprecated in the upstream Linux kernel. In September 2025 it will be turned off by default in the kernel and five years after that, support will be removed entirely. Warn people formatting new filesystems with the old format, particularly since V4 is not the default.

---
 mkfs/xfs_mkfs.c |    9 +++++++++
 1 file changed, 9 insertions(+)
mkfs/xfs_mkfs.c +2 -0
index 53904677..b8c11ce9 100644
@@ -2103,6 +2103,15 @@ _("Directory ftype field always enabled on CRC enabled filesystems\n"));
 		}
 
 	} else {	/* !crcs_enabled */
+		/*
+		 * The V4 filesystem format is deprecated in the upstream Linux

mkfs/xfs_mkfs.c _("Directory ftype field always enabled on CRC enabled filesystems\n")); · line 2117

Quoted 10 lines
mkfs/xfs_mkfs.c +7 -0
+		 * kernel.  In September 2025 it will be turned off by default
+		 * in the kernel and in September 2030 support will be removed
+		 * entirely.
+		 */
+		fprintf(stdout,
+_("V4 filesystems are deprecated and will not be supported by future versions.\n"));
+
 		/*
 		 * The kernel doesn't support crc=0,finobt=1 filesystems.
 		 * If crcs are not enabled and the user has not explicitly

Looks good to me.

Quoted 3 lines

Do we need to update the mkfs filter in fstests now?

AFAICT, no, because (so far) the only fstests that care about mkfs output only look for messages on stderr, and dump stdout to $seqres.full or /dev/null.

--D

Quoted 6 lines

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#3 lore raw
Quoted 39 lines · Darrick J. Wong
Quoted 38 lines · Dave Chinner
Quoted 24 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

The V4 filesystem format is deprecated in the upstream Linux kernel. In September 2025 it will be turned off by default in the kernel and five years after that, support will be removed entirely. Warn people formatting new filesystems with the old format, particularly since V4 is not the default.

---
 mkfs/xfs_mkfs.c |    9 +++++++++
 1 file changed, 9 insertions(+)
mkfs/xfs_mkfs.c +2 -0
index 53904677..b8c11ce9 100644
@@ -2103,6 +2103,15 @@ _("Directory ftype field always enabled on CRC enabled filesystems\n"));
 		}
 
 	} else {	/* !crcs_enabled */
+		/*
+		 * The V4 filesystem format is deprecated in the upstream Linux

mkfs/xfs_mkfs.c _("Directory ftype field always enabled on CRC enabled filesystems\n")); · line 2117

Quoted 10 lines
mkfs/xfs_mkfs.c +7 -0
+		 * kernel.  In September 2025 it will be turned off by default
+		 * in the kernel and in September 2030 support will be removed
+		 * entirely.
+		 */
+		fprintf(stdout,
+_("V4 filesystems are deprecated and will not be supported by future versions.\n"));
+
 		/*
 		 * The kernel doesn't support crc=0,finobt=1 filesystems.
 		 * If crcs are not enabled and the user has not explicitly

Looks good to me.

Quoted 7 lines
Quoted 3 lines

Do we need to update the mkfs filter in fstests now?

AFAICT, no, because (so far) the only fstests that care about mkfs output only look for messages on stderr, and dump stdout to $seqres.full or /dev/null.

So I'll immediately put my foot in my mouth; there /was/ a patch in my fstests tree to fix the one test that broke: xfs/449.

--D

Quoted 8 lines

--D

Quoted 6 lines

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]