eal: fix memory leak when saving arguments
PATCH 1/1 eal: fix memory leak when saving arguments
This patch fixes a memleak which was reported in Bugzilla within the eal_save_args function. This was caused by the function mistakenly adding -- to the eal args instead of breaking beforehand.
Bugzilla ID: 722
Fixes 293c53d8b23c ("eal: add telemetry callbacks")
Reported-by Zhihong Peng <[email protected]>
Signed-off-by Conor Walsh <[email protected]>
Signed-off-by Conor Fogarty <[email protected]>
--- lib/eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eal/common/eal_common_options.c +1 -1
@@ -229,9 +229,9 @@ eal_save_args(int argc, char **argv)return -1 ;for (i =0 ; i < argc; i++) { - eal_args[i] =strdup (argv[i]);if (strcmp (argv[i],"--" ) ==0 )break ; + eal_args[i] =strdup (argv[i]); } eal_args[i++] =NULL ;/* always finish with NULL */
Signature · 1 line
2.25.1
Quoted 11 lines · Conor Walsh
This patch fixes a memleak which was reported in Bugzilla within the
eal_save_argsfunction. This was caused by the function mistakenly adding -- to the eal args instead of breaking beforehand.Bugzilla ID: 722
Fixes 293c53d8b23c ("eal: add telemetry callbacks")Reported-by Zhihong Peng <[email protected]>Signed-off-by Conor Walsh <[email protected]>Signed-off-by Conor Fogarty <[email protected]>---
Acked-by Bruce Richardson <[email protected]>
David Marchand
AppliedQuoted 6 lines · Bruce Richardson
Quoted 4 lines · Conor Walsh
This patch fixes a memleak which was reported in Bugzilla within the
eal_save_argsfunction. This was caused by the function mistakenly adding -- to the eal args instead of breaking beforehand.
Quoted 8 lines
Quoted 7 lines
Bugzilla ID: 722
Fixes 293c53d8b23c ("eal: add telemetry callbacks")Reported-by Zhihong Peng <[email protected]>Signed-off-by Conor Walsh <[email protected]>Signed-off-by Conor Fogarty <[email protected]>---
Acked-by Bruce Richardson <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand