Skip to contentSkip to conversation

gpu: drm: add driver for ili9361 panel

PATCH Superseded Daniel Mack 2 participants 5 messages Sep 1, 2021

Subsystems (3)

v9 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

v9 cover gpu: drm: add driver for ili9361 panel

This is v9 of the series.

Changelog:

v2 -> v3:
* Turn Documentation into yaml format

v3 -> v4:
* Fix reference error in yaml file

v4 -> v5:
* More yaml file documentation fixes

v5 -> v6:
* More yaml file documentation fixes

v6 -> v7:
* Fix ordering of patches

v7 -> v8:
* More yaml file documentation fixes

v8 -> v9:
* Addressed some minor issues pointed out by Thomas Zimmermann
* Rebased

Daniel Mack (2):
dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF

 .../bindings/display/ilitek,ili9163.txt       |  27 +++
 drivers/gpu/drm/tiny/Kconfig                  |  13 +
 drivers/gpu/drm/tiny/Makefile                 |   1 +
 drivers/gpu/drm/tiny/ili9163.c                | 224 ++++++++++++++++++
 4 files changed, 265 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.txt
 create mode 100644 drivers/gpu/drm/tiny/ili9163.c
Signature · 1 line
2.31.1
#1 lore raw

PATCH v9 1/2 dt-bindings: display: add bindings for newhaven, 1.8-128160EF

This adds documentation for a new ILI9163 based, SPI connected display.

---
 .../bindings/display/ilitek,ili9163.txt       | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.txt
Documentation/devicetree/bindings/display/ilitek,ili9163.txt new file +27 -0
new file mode 100644
index 000000000000..fee119991c14
@@ -0,0 +1,27 @@
+Ilitek ILI9163 display panels
+
+This binding is for display panels using an Ilitek ILI9163 controller in SPI
+mode.
+
+Required properties:
+- compatible:	"newhaven,1.8-128160EF", "ilitek,ili9163"
+- dc-gpios:	D/C pin
+- reset-gpios:	Reset pin
+
+The node for this driver must be a child node of a SPI controller, hence
+all mandatory properties described in ../spi/spi-bus.txt must be specified.
+
+Optional properties:
+- rotation:	panel rotation in degrees counter clockwise (0,90,180,270)
+- backlight:	phandle of the backlight device attached to the panel
+
+Example:
+	display@0{
+		compatible = "newhaven,1.8-128160EF", "ilitek,ili9163"
+		reg = <0>;
+		spi-max-frequency = <32000000>;
+		dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>;
+		rotation = <270>;
+		backlight = <&backlight>;
+	};
Signature · 1 line
2.31.1
#2 lore raw

PATCH v9 2/2 drm/tiny: add driver for newhaven,1.8-128160EF

In reply to Daniel Mack

This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller.

---
 drivers/gpu/drm/tiny/Kconfig   |  13 ++
 drivers/gpu/drm/tiny/Makefile  |   1 +
 drivers/gpu/drm/tiny/ili9163.c | 224 +++++++++++++++++++++++++++++++++
 3 files changed, 238 insertions(+)
 create mode 100644 drivers/gpu/drm/tiny/ili9163.c
drivers/gpu/drm/tiny/Kconfig +13 -0
index d46f95d9196d..ca2d9255548b 100644
@@ -67,6 +67,19 @@ config TINYDRM_HX8357D
 
 	  If M is selected the module will be called hx8357d.
 
+config TINYDRM_ILI9163
+	tristate "DRM support for ILI9163 display panels"
+	depends on DRM && SPI
+	select BACKLIGHT_CLASS_DEVICE
+	select DRM_KMS_CMA_HELPER
+	select DRM_KMS_HELPER
+	select DRM_MIPI_DBI
+	help
+	  DRM driver for the following Ilitek ILI9163 panels:
+	  * NHD-1.8-128160EF 128x160 TFT
+
+	  If M is selected the module will be called ili9163.
+
 config TINYDRM_ILI9225
 	tristate "DRM support for ILI9225 display panels"
 	depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +1 -0
index 9cc847e756da..c96c663c3499 100644
@@ -5,6 +5,7 @@ obj-$(CONFIG_DRM_CIRRUS_QEMU)		+= cirrus.o
 obj-$(CONFIG_DRM_GM12U320)		+= gm12u320.o
 obj-$(CONFIG_DRM_SIMPLEDRM)		+= simpledrm.o
 obj-$(CONFIG_TINYDRM_HX8357D)		+= hx8357d.o
+obj-$(CONFIG_TINYDRM_ILI9163)		+= ili9163.o
 obj-$(CONFIG_TINYDRM_ILI9225)		+= ili9225.o
 obj-$(CONFIG_TINYDRM_ILI9341)		+= ili9341.o
 obj-$(CONFIG_TINYDRM_ILI9486)		+= ili9486.o
drivers/gpu/drm/tiny/ili9163.c new file +224 -0

224 lines not on this page · raw message

Signature · 1 line
2.31.1
#3 lore raw
In reply to Daniel Mack

Hi Daniel,

Quoted 6 lines · Daniel Mack

This is v9 of the series.

Changelog:

v2 -> v3:
* Turn Documentation into yaml format

...

Quoted 5 lines

Daniel Mack (2):
dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF

 .../bindings/display/ilitek,ili9163.txt       |  27 +++

Despite the changelog the patch contains a .txt file. Did you push the right patchset?

Sam

#4 lore raw

Hi Sam,

Quoted 12 lines · Sam Ravnborg

Hi Daniel,

Quoted 6 lines · Daniel Mack

This is v9 of the series.

Changelog:

v2 -> v3:
* Turn Documentation into yaml format

...

Quoted 8 lines
Quoted 5 lines

Daniel Mack (2):
dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF

 .../bindings/display/ilitek,ili9163.txt       |  27 +++

Despite the changelog the patch contains a .txt file. Did you push the right patchset?

Meh, you're right. Something went wrong in the rebase. Thanks for spotting this! Will send a v10 in a minute!

Daniel