libbpf: don't crash on object files with no symbol tables
Subsystems (4)
PATCH v2 1/1 libbpf: don't crash on object files with no symbol tables
If libbpf encounters an ELF file that has been stripped of its symbol table, it will crash in bpf_object__add_programs() when trying to dereference the obj->efile.symbols pointer.
Fix this by erroring out of bpf_object__elf_collect() if it is not able able to find the symbol table.
v2:
- Move check into bpf_object__elf_collect() and add nice error message
--- tools/lib/bpf/libbpf.c | 6 ++++++ 1 file changed, 6 insertions(+)
tools/lib/bpf/libbpf.c +6 -0
@@ -2990,6 +2990,12 @@ static int bpf_object__elf_collect(struct bpf_object *obj) } } +if (!obj->efile.symbols) { +pr_warn ("elf: couldn't find symbol table in %s - stripped object file?\n" , + obj->path); +return -ENOENT ; + } + scn =NULL ;while ((scn =elf_nextscn (elf, scn)) !=NULL ) { idx++;
Signature · 1 line
2.33.0
Andrii Nakryiko
AppliedQuoted 8 lines · Toke Høiland-Jørgensen
If libbpf encounters an ELF file that has been stripped of its symbol table, it will crash in
bpf_object__add_programs()when trying to dereference theobj->efile.symbolspointer.Fix this by erroring out of
bpf_object__elf_collect()if it is not able able to find the symbol table.
Quoted 6 lines
v2:
- Move check intobpf_object__elf_collect()and add nice error messageFixes 6245947c1b3c ("libbpf: Allow gaps in BPF program sections to support overriden weak functions")Signed-off-by Toke Høiland-Jørgensen <[email protected]>---
Applied to bpf-next, thanks.
Quoted 23 lines
tools/lib/bpf/libbpf.c | 6 ++++++ 1 file changed, 6 insertions(+)tools/lib/bpf/libbpf.c +6
-1@@ -2990,6 +2990,12 @@ static int bpf_object__elf_collect(struct bpf_object *obj) } } +if (!obj->efile.symbols) { +pr_warn ("elf: couldn't find symbol table in %s - stripped object file?\n" , + obj->path); +return -ENOENT ; + } + scn =NULL ;while ((scn =elf_nextscn (elf, scn)) !=NULL ) { idx++; --2.33.0