mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype
Subsystems (2)
PATCH v2 1/1 mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype
If it's not prepared to free unref page, the pcp page migratetype is unset. Thus We will get rubbish from get_pcppage_migratetype() and might list_del &page->lru again after it's already deleted from the list leading to grumble about data corruption.
--- mm/page_alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
mm/page_alloc.c +3 -1
@@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list)/* Prepare pages for freeing */ list_for_each_entry_safe (page, next, list, lru) { pfn =page_to_pfn (page); -if (!free_unref_page_prepare (page, pfn,0 )) +if (!free_unref_page_prepare (page, pfn,0 )) {list_del (&page->lru); +continue ; + }/* * Free isolated pages directly to the allocator, see
Signature · 1 line
2.23.0
Quoted 9 lines · Miaohe Lin
If it's not prepared to free unref page, the pcp page migratetype is unset. Thus We will get rubbish from
get_pcppage_migratetype()and mightlist_del&page->lruagain after it's already deleted from the list leading to grumble about data corruption.Fixes df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock")Signed-off-by Miaohe Lin <[email protected]>Acked-by Mel Gorman <[email protected]>Cc <[email protected]>
Quoted 21 lines
--- mm/page_alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)mm/page_alloc.c +3
-1@@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list)/* Prepare pages for freeing */ list_for_each_entry_safe (page, next, list, lru) { pfn =page_to_pfn (page); -if (!free_unref_page_prepare (page, pfn,0 )) +if (!free_unref_page_prepare (page, pfn,0 )) {list_del (&page->lru); +continue ; + }/* * Free isolated pages directly to the allocator, see
Quoted 20 lines · Miaohe Lin
If it's not prepared to free unref page, the pcp page migratetype is unset. Thus We will get rubbish from
get_pcppage_migratetype()and mightlist_del&page->lruagain after it's already deleted from the list leading to grumble about data corruption.Fixes df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock")Signed-off-by Miaohe Lin <[email protected]>Acked-by Mel Gorman <[email protected]>Cc <[email protected]>--- mm/page_alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)mm/page_alloc.c +0
-0@@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list)/* Prepare pages for freeing */
mm/page_alloc.c void free_unref_page_list(struct list_head *list) · line 3429
Quoted 10 lines
mm/page_alloc.c +3
-1list_for_each_entry_safe (page, next, list, lru) { pfn =page_to_pfn (page); -if (!free_unref_page_prepare (page, pfn,0 )) +if (!free_unref_page_prepare (page, pfn,0 )) {list_del (&page->lru); +continue ; + }/* * Free isolated pages directly to the allocator, see
Signature · 3 lines
Thanks, David / dhildenb