Skip to contentSkip to conversation

mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype

PATCH Applied Miaohe Lin 3 participants 3 messages Sep 2, 2021

Subsystems (2)
lore
Share & tools
lore

Miaohe Lin

author
#0 lore raw

PATCH v2 1/1 mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype

If it's not prepared to free unref page, the pcp page migratetype is unset. Thus We will get rubbish from get_pcppage_migratetype() and might list_del &page->lru again after it's already deleted from the list leading to grumble about data corruption.

Fixes df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock")
---
 mm/page_alloc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
mm/page_alloc.c +3 -1
index 9c09dcb24149..a3c6acafa478 100644
@@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list)
 	/* Prepare pages for freeing */
 	list_for_each_entry_safe(page, next, list, lru) {
 		pfn = page_to_pfn(page);
-		if (!free_unref_page_prepare(page, pfn, 0))
+		if (!free_unref_page_prepare(page, pfn, 0)) {
 			list_del(&page->lru);
+			continue;
+		}
 
 		/*
 		 * Free isolated pages directly to the allocator, see
Signature · 1 line
2.23.0
Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Miaohe Lin

If it's not prepared to free unref page, the pcp page migratetype is unset. Thus We will get rubbish from get_pcppage_migratetype() and might list_del &page->lru again after it's already deleted from the list leading to grumble about data corruption.

Fixes df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock")
Quoted 21 lines
---
 mm/page_alloc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
mm/page_alloc.c +3 -1
index 9c09dcb24149..a3c6acafa478 100644
@@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list)
 	/* Prepare pages for freeing */
 	list_for_each_entry_safe(page, next, list, lru) {
 		pfn = page_to_pfn(page);
-		if (!free_unref_page_prepare(page, pfn, 0))
+		if (!free_unref_page_prepare(page, pfn, 0)) {
 			list_del(&page->lru);
+			continue;
+		}
 
 		/*
 		 * Free isolated pages directly to the allocator, see
Reviewed-by on v2 1/1
#2 lore raw
In reply to Miaohe Lin
Quoted 20 lines · Miaohe Lin

If it's not prepared to free unref page, the pcp page migratetype is unset. Thus We will get rubbish from get_pcppage_migratetype() and might list_del &page->lru again after it's already deleted from the list leading to grumble about data corruption.

Fixes df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock")
---
  mm/page_alloc.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
mm/page_alloc.c +0 -0
index 9c09dcb24149..a3c6acafa478 100644
@@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list)
  	/* Prepare pages for freeing */

mm/page_alloc.c void free_unref_page_list(struct list_head *list) · line 3429

Quoted 10 lines
mm/page_alloc.c +3 -1
  	list_for_each_entry_safe(page, next, list, lru) {
  		pfn = page_to_pfn(page);
-		if (!free_unref_page_prepare(page, pfn, 0))
+		if (!free_unref_page_prepare(page, pfn, 0)) {
  			list_del(&page->lru);
+			continue;
+		}
 
  		/*
  		 * Free isolated pages directly to the allocator, see
Signature · 3 lines
Thanks,

David / dhildenb