Skip to contentSkip to conversation

media: pvrusb2: add newline between two statements

PATCH In review Colin King 2 participants 4 messages Sep 2, 2021 – Sep 13, 2021

Subsystems (3)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 media: pvrusb2: add newline between two statements

From: Colin Ian King <[email protected]>

There are two statements on the same line, add a newline to clean this up.

---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +2 -1
index d38dee1792e4..ca00b7fe1e7f 100644
@@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
 				   enable_flag ? "enable" : "disable");
 		}
 		pvr2_hdw_state_sched(hdw);
-	} while (0); LOCK_GIVE(hdw->big_lock);
+	} while (0);
+	LOCK_GIVE(hdw->big_lock);
 	if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
 	if (enable_flag) {
 		while ((st = hdw->master_state) != PVR2_STATE_RUN) {
Signature · 1 line
2.32.0
#1 lore raw

NAK: [PATCH][next] media: pvrusb2: add newline between two statements

Quoted 16 lines · Colin King

From: Colin Ian King <[email protected]>

There are two statements on the same line, add a newline to clean this up.

---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +0 -0
index d38dee1792e4..ca00b7fe1e7f 100644

drivers/media/usb/pvrusb2/pvrusb2-hdw.c int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) · line 1734

Quoted 9 lines
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +2 -1
@@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
 				   enable_flag ? "enable" : "disable");
 		}
 		pvr2_hdw_state_sched(hdw);
-	} while (0); LOCK_GIVE(hdw->big_lock);
+	} while (0);
+	LOCK_GIVE(hdw->big_lock);
 	if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
 	if (enable_flag) {
 		while ((st = hdw->master_state) != PVR2_STATE_RUN) {

ignore, V2 being sent in a moment.

#2 lore raw

Re: NAK: [PATCH][next] media: pvrusb2: add newline between two statements

Quoted 20 lines · Colin Ian King
Quoted 19 lines · Colin King

From: Colin Ian King <[email protected]>

There are two statements on the same line, add a newline to clean this up.

---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +0 -1
index d38dee1792e4..ca00b7fe1e7f 100644
@@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
 				   enable_flag ? "enable" : "disable");
 		}
 		pvr2_hdw_state_sched(hdw);
-	} while (0); LOCK_GIVE(hdw->big_lock);
Quoted 8 lines

drivers/media/usb/pvrusb2/pvrusb2-hdw.c int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) · line 1734

Quoted 6 lines
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +2 -0
+	} while (0);
+	LOCK_GIVE(hdw->big_lock);
 	if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
 	if (enable_flag) {
 		while ((st = hdw->master_state) != PVR2_STATE_RUN) {

ignore, V2 being sent in a moment.

I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.

Regards,

Hans

#3 lore raw

Re: NAK: [PATCH][next] media: pvrusb2: add newline between two statements

Quoted 30 lines · Hans Verkuil
Quoted 20 lines · Colin Ian King
Quoted 19 lines · Colin King

From: Colin Ian King <[email protected]>

There are two statements on the same line, add a newline to clean this up.

---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +0 -1
index d38dee1792e4..ca00b7fe1e7f 100644
@@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
 				   enable_flag ? "enable" : "disable");
 		}
 		pvr2_hdw_state_sched(hdw);
-	} while (0); LOCK_GIVE(hdw->big_lock);
Quoted 8 lines

drivers/media/usb/pvrusb2/pvrusb2-hdw.c int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) · line 1734

Quoted 6 lines
drivers/media/usb/pvrusb2/pvrusb2-hdw.c +2 -0
+	} while (0);
+	LOCK_GIVE(hdw->big_lock);
 	if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
 	if (enable_flag) {
 		while ((st = hdw->master_state) != PVR2_STATE_RUN) {

ignore, V2 being sent in a moment.

Quoted 1 line

I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.

After looking at all the unconventional code style issues I chose not to clean this up.

Quoted 5 lines

Regards,

Hans