config/ppc: ignore gcc 11 psabi warnings
PATCH 1/1 config/ppc: ignore gcc 11 psabi warnings
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Bugzilla ID: 739
--- config/ppc/meson.build | 6 ++++++ 1 file changed, 6 insertions(+)
config/ppc/meson.build +6 -0
@@ -17,6 +17,12 @@ if not power9_supported dpdk_conf.set('RTE_MACHINE','power8') endif +# Suppress the gcc warning "note: the layout of aggregates containing +# vectors with 4-byte alignment has changed in GCC 5". +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') + add_project_arguments('-Wno-psabi', language: 'c') +endif + # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a # high value can waste memory, cause timeouts in time limited autotests, and is # unlikely to be used in many production situations. Similarly, keeping the
Signature · 1 line
2.27.0
PATCH v2 1/1 config/ppc: ignore gcc 11 psabi warnings
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Bugzilla ID: 739
---
v2:
- update copyright year
- rebase for 21.11-rc0
--- config/ppc/meson.build | 7 +++++++ 1 file changed, 7 insertions(+)
config/ppc/meson.build +7 -0
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Luca Boccassi <[email protected]> +# Copyright(c) 2021 IBM Corporation if not dpdk_conf.get('RTE_ARCH_64') error('Only 64-bit compiles are supported for this platform type')
@@ -17,6 +18,12 @@ if not power9_supported dpdk_conf.set('RTE_MACHINE','power8') endif +# Suppress the gcc warning "note: the layout of aggregates containing +# vectors with 4-byte alignment has changed in GCC 5". +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') + add_project_arguments('-Wno-psabi', language: 'c') +endif + # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a # high value can waste memory, cause timeouts in time limited autotests, and is # unlikely to be used in many production situations. Similarly, keeping the
--
2.27.0
Quoted 9 lines
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Quoted 8 lines
Bugzilla ID: 739
Signed-off-by David Christensen <[email protected]>---
v2:
- update copyright year
- rebase for 21.11-rc0
---
David M,
Any chance of getting this approved in the 21.11 cycle? Patch was originally submitted on 6/23, is only applicable to PPC architecture, and has no functional impact because it only disables warnings. The failing test build on Windows reported at
http://mails.dpdk.org/archives/test-report/2021-September/216596.html
cannot in any way be caused by this patch. We hope to have all changes in place to support POWER10 in this DPDK release so we're constantly testing with new compiler versions which add P10 support.
Dave
David Marchand
AppliedQuoted 11 lines · David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Bugzilla ID: 739
I guess the intent was to have this backported.
So added explicit Cc: [email protected]
Quoted 22 lines
Signed-off-by David Christensen <[email protected]>---
v2:
- update copyright year
- rebase for 21.11-rc0--- config/ppc/meson.build | 7 +++++++ 1 file changed, 7 insertions(+)config/ppc/meson.build +1
-0@@ -1,5 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Luca Boccassi <[email protected]> +# Copyright(c) 2021 IBM Corporation if not dpdk_conf.get('RTE_ARCH_64') error('Only 64-bit compiles are supported for this platform type')
config/ppc/meson.build if not power9_supported · line 23
Quoted 6 lines
config/ppc/meson.build +3
-0@@ -17,6 +18,12 @@ if not power9_supported dpdk_conf.set('RTE_MACHINE','power8') endif +# Suppress the gcc warning "note: the layout of aggregates containing +# vectors with 4-byte alignment has changed in GCC 5". +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
Wrapped this to next line.
Quoted 9 lines
config/ppc/meson.build +3
-1+ add_project_arguments('-Wno-psabi', language: 'c') +endif + # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a # high value can waste memory, cause timeouts in time limited autotests, and is # unlikely to be used in many production situations. Similarly, keeping the --2.27.0
Applied, thanks.
Signature · 1 line
David Marchand
Quoted 35 lines · David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Bugzilla ID: 739
Signed-off-by David Christensen <[email protected]>---
v2:
- update copyright year
- rebase for 21.11-rc0--- config/ppc/meson.build | 7 +++++++ 1 file changed, 7 insertions(+)config/ppc/meson.build +1
-0@@ -1,5 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Luca Boccassi <[email protected]> +# Copyright(c) 2021 IBM Corporation if not dpdk_conf.get('RTE_ARCH_64') error('Only 64-bit compiles are supported for this platform type')@@ -17,6 +18,12 @@ if not power9_supported dpdk_conf.set('RTE_MACHINE','power8') endif
config/ppc/meson.build if not power9_supported
Quoted 10 lines
config/ppc/meson.build +6
-1+# Suppress the gcc warning "note: the layout of aggregates containing +# vectors with 4-byte alignment has changed in GCC 5". +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') + add_project_arguments('-Wno-psabi', language: 'c') +endif + # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a # high value can waste memory, cause timeouts in time limited autotests, and is # unlikely to be used in many production situations. Similarly, keeping the --
I am getting following build error in my environment:
"config/ppc/meson.build:23:6: ERROR: Unknown statement."
The compiler I have is:
powerpc64le-linux-gcc (gcc 10.2.0 "powerpc64le-linux-gcc.br_real (Buildroot 2020.08-14-ge5a2a90) 10.2.0")
meson version: Version: 0.59.1
Multi-line statements seems need to be merged with '\':
config/ppc/meson.build +1 -1
@@ -20,7 +20,7 @@ endif # Suppress the gcc warning "note: the layout of aggregates containing # vectors with 4-byte alignment has changed in GCC 5". -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and \ cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') add_project_arguments('-Wno-psabi', language: 'c') endif
Quoted 51 lines · Ferruh Yigit
Quoted 35 lines · David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Bugzilla ID: 739
Signed-off-by David Christensen <[email protected]>---
v2:
- update copyright year
- rebase for 21.11-rc0--- config/ppc/meson.build | 7 +++++++ 1 file changed, 7 insertions(+)config/ppc/meson.build +1
-0@@ -1,5 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Luca Boccassi <[email protected]> +# Copyright(c) 2021 IBM Corporation if not dpdk_conf.get('RTE_ARCH_64') error('Only 64-bit compiles are supported for this platform type')@@ -17,6 +18,12 @@ if not power9_supported dpdk_conf.set('RTE_MACHINE','power8') endifconfig/ppc/meson.build if not power9_supported
Quoted 10 lines
config/ppc/meson.build +6
-1+# Suppress the gcc warning "note: the layout of aggregates containing +# vectors with 4-byte alignment has changed in GCC 5". +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') + add_project_arguments('-Wno-psabi', language: 'c') +endif + # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a # high value can waste memory, cause timeouts in time limited autotests, and is # unlikely to be used in many production situations. Similarly, keeping the --I am getting following build error in my environment:
"config/ppc/meson.build:23:6: ERROR: Unknown statement."
Quoted 5 lines
The compiler I have is:
powerpc64le-linux-gcc (gcc 10.2.0 "powerpc64le-linux-gcc.br_real (Buildroot 2020.08-14-ge5a2a90) 10.2.0")meson version: Version: 0.59.1
Good catch.
My fault, and I did not see it because I was still testing with gcc 9.
Quoted 8 lines
Multi-line statements seems need to be merged with '\':
config/ppc/meson.build +0
-0
config/ppc/meson.build endif · line 24
Quoted 6 lines
config/ppc/meson.build +1
-1@@ -20,7 +20,7 @@ endif # Suppress the gcc warning "note: the layout of aggregates containing # vectors with 4-byte alignment has changed in GCC 5". -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and \ cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
I based this update of mine on other existing multiline statements in dpdk. But I did not notice that all of them are within parens.
So both \ and () are fine.
Bruce, I did not see this described in our meson coding style. Do you have an opinion for multiline statements in meson?
Signature · 1 line
David Marchand
Quoted 80 lines · David Marchand
Quoted 51 lines · Ferruh Yigit
Quoted 35 lines · David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment changes introduced in GCC 5. Older gcc versions forced vector alignment to 16 bytes due to requirements for POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs supported by DPDK.
Bugzilla ID: 739
Signed-off-by David Christensen <[email protected]>---
v2:
- update copyright year
- rebase for 21.11-rc0--- config/ppc/meson.build | 7 +++++++ 1 file changed, 7 insertions(+)config/ppc/meson.build +1
-0@@ -1,5 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Luca Boccassi <[email protected]> +# Copyright(c) 2021 IBM Corporation if not dpdk_conf.get('RTE_ARCH_64') error('Only 64-bit compiles are supported for this platform type')@@ -17,6 +18,12 @@ if not power9_supported dpdk_conf.set('RTE_MACHINE','power8') endifconfig/ppc/meson.build if not power9_supported
Quoted 10 lines
config/ppc/meson.build +6
-1+# Suppress the gcc warning "note: the layout of aggregates containing +# vectors with 4-byte alignment has changed in GCC 5". +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') + add_project_arguments('-Wno-psabi', language: 'c') +endif + # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a # high value can waste memory, cause timeouts in time limited autotests, and is # unlikely to be used in many production situations. Similarly, keeping the --I am getting following build error in my environment:
"config/ppc/meson.build:23:6: ERROR: Unknown statement."Quoted 5 lines
The compiler I have is:
powerpc64le-linux-gcc (gcc 10.2.0 "powerpc64le-linux-gcc.br_real (Buildroot 2020.08-14-ge5a2a90) 10.2.0")meson version: Version: 0.59.1
Good catch.
My fault, and I did not see it because I was still testing with gcc 9.Quoted 8 lines
Multi-line statements seems need to be merged with '\':
config/ppc/meson.build +0
-0config/ppc/meson.build endif · line 24
Quoted 6 lines
config/ppc/meson.build +1
-1@@ -20,7 +20,7 @@ endif # Suppress the gcc warning "note: the layout of aggregates containing # vectors with 4-byte alignment has changed in GCC 5". -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and \ cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')I based this update of mine on other existing multiline statements in dpdk. But I did not notice that all of them are within parens.
Quoted 5 lines
So both \ and () are fine.
Bruce, I did not see this described in our meson coding style. Do you have an opinion for multiline statements in meson?
No, I don't have an opinion either way. If you want, we can pick one to use in the coding style, but if we do we should also match the style for python code, as I believe they both share this multi-line approach.