Skip to contentSkip to conversation

cpufreq: powernow: Prefer kcalloc over open coded arithmetic

PATCH In review Len Baker 2 participants 2 messages Sep 4, 2021 – Sep 6, 2021 CPU frequency scaling framework

lore
Share & tools
lore

Len Baker

author
#0 lore raw

PATCH 1/1 cpufreq: powernow: Prefer kcalloc over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

---
 drivers/cpufreq/powernow-k7.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k7.c +2 -2
index 5d515fc34836..a9d2c7bae235 100644
@@ -174,8 +174,8 @@ static int get_ranges(unsigned char *pst)
 	unsigned int speed;
 	u8 fid, vid;
 
-	powernow_table = kzalloc((sizeof(*powernow_table) *
-				(number_scales + 1)), GFP_KERNEL);
+	powernow_table = kcalloc(number_scales + 1, sizeof(*powernow_table),
+				 GFP_KERNEL);
 	if (!powernow_table)
 		return -ENOMEM;
 

--
2.25.1

#1 lore raw
Quoted 9 lines · Len Baker

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

Quoted 6 lines

So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

I'm assuming that this patch will be picked up by the powerpc arch maintainers.

Quoted 22 lines
---
 drivers/cpufreq/powernow-k7.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k7.c +2 -3
index 5d515fc34836..a9d2c7bae235 100644
@@ -174,8 +174,8 @@ static int get_ranges(unsigned char *pst)
        unsigned int speed;
        u8 fid, vid;
 
-       powernow_table = kzalloc((sizeof(*powernow_table) *
-                               (number_scales + 1)), GFP_KERNEL);
+       powernow_table = kcalloc(number_scales + 1, sizeof(*powernow_table),
+                                GFP_KERNEL);
        if (!powernow_table)
                return -ENOMEM;
 
--

2.25.1