cpufreq: powernow: Prefer kcalloc over open coded arithmetic
PATCH 1/1 cpufreq: powernow: Prefer kcalloc over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function.
--- drivers/cpufreq/powernow-k7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k7.c +2 -2
@@ -174,8 +174,8 @@ static int get_ranges(unsigned char *pst)unsigned int speed;u8 fid, vid; - powernow_table =kzalloc ((sizeof (*powernow_table) * - (number_scales +1 )),GFP_KERNEL ); + powernow_table =kcalloc (number_scales +1 ,sizeof (*powernow_table), +GFP_KERNEL );if (!powernow_table)return -ENOMEM ;
--
2.25.1
Rafael J. Wysocki
maintainerQuoted 9 lines · Len Baker
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.Signed-off-by Len Baker <[email protected]>
I'm assuming that this patch will be picked up by the powerpc arch maintainers.
Quoted 22 lines
--- drivers/cpufreq/powernow-k7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/cpufreq/powernow-k7.c +2
-3@@ -174,8 +174,8 @@ static int get_ranges(unsigned char *pst)unsigned int speed;u8 fid, vid; - powernow_table =kzalloc ((sizeof (*powernow_table) * - (number_scales +1 )),GFP_KERNEL ); + powernow_table =kcalloc (number_scales +1 ,sizeof (*powernow_table), +GFP_KERNEL );if (!powernow_table)return -ENOMEM ; --2.25.1