scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
Subsystems (3)
PATCH 1/1 scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function.
--- drivers/scsi/elx/libefc/efc_fabric.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/elx/libefc/efc_fabric.c +1 -1
@@ -686,7 +686,7 @@ efc_process_gidpt_payload(struct efc_node *node, }/* Allocate a buffer for all nodes */ - active_nodes =kzalloc (port_count *sizeof (*active_nodes),GFP_ATOMIC ); + active_nodes =kcalloc (port_count,sizeof (*active_nodes),GFP_ATOMIC );if (!active_nodes) {node_printf (node,"efc_malloc failed\n" );return -EIO ;
--
2.25.1
Quoted 8 lines · Len Baker
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
kcalloc()function instead of the argument count * size in thekzalloc()function.Signed-off-by Len Baker <[email protected]>
Looks good. Thanks
-- james
Martin K. Petersen
AppliedQuoted 9 lines · Len Baker
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
[...]
Applied to 5.16/scsi-queue, thanks!
[1/1] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
https://git.kernel.org/mkp/scsi/c/0a5e20fc8ca7
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering