crypto/mlx5: support timestamp format
PATCH 1/1 crypto/mlx5: support timestamp format
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail.
The patch queries the timestamp formats supported by the hardware and sets the configuration values in queue context accordingly.
--- drivers/crypto/mlx5/mlx5_crypto.c | 2 ++ drivers/crypto/mlx5/mlx5_crypto.h | 1 + 2 files changed, 3 insertions(+)
drivers/crypto/mlx5/mlx5_crypto.c +2 -0
@@ -707,6 +707,7 @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id, attr.wq_umem_id = qp->umem_obj->umem_id; attr.wq_umem_offset =0 ; attr.dbr_umem_id = qp->umem_obj->umem_id; + attr.ts_format =mlx5_ts_format_conv (priv->qp_ts_format); attr.dbr_address =RTE_BIT64 (log_nb_desc) * priv->wqe_set_size; qp->qp_obj =mlx5_devx_cmd_create_qp (priv->ctx, &attr);if (qp->qp_obj ==NULL ) {
@@ -1049,6 +1050,7 @@ mlx5_crypto_dev_probe(struct rte_device *dev) priv->ctx = ctx; priv->login_obj = login; priv->crypto_dev = crypto_dev; + priv->qp_ts_format = attr.qp_ts_format;if (mlx5_crypto_hw_global_prepare (priv) !=0 ) {rte_cryptodev_pmd_destroy (priv->crypto_dev);claim_zero (mlx5_glue->close_device (priv->ctx));
drivers/crypto/mlx5/mlx5_crypto.h +1 -0
@@ -25,6 +25,7 @@ struct mlx5_crypto_priv {volatile uint64_t *uar_addr;uint32_t pdn;/* Protection Domain number. */ uint32_t max_segs_num;/* Maximum supported data segs. */ +uint8_t qp_ts_format;/* Whether QP supports timestamp formats. */ struct ibv_pd *pd;struct mlx5_hlist *dek_hlist;/* Dek hash list. */ struct rte_cryptodev_config dev_config;
Signature · 1 line
2.25.1
From: Michael Baum
Quoted 5 lines
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail.
Quoted 7 lines
The patch queries the timestamp formats supported by the hardware and sets the configuration values in queue context accordingly.
Fixes 6152534e211e ("crypto/mlx5: support queue pairs operations")Signed-off-by Michael Baum <[email protected]>
Quoted 6 lines
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail.
Quoted 8 lines
The patch queries the timestamp formats supported by the hardware and sets the configuration values in queue context accordingly.
Fixes 6152534e211e ("crypto/mlx5: support queue pairs operations")Signed-off-by Michael Baum <[email protected]>---
Is this a fix or a feature, title says a new feature, but description says it as a fix.
Please align title and description of the patch.
Hi,
Quoted 20 lines
-----Original Message-----
From: Akhil Goyal <[email protected]>
Sent: Thursday, September 2, 2021 1:14 PM
To: Michael Baum <[email protected]>; [email protected]
Cc: Matan Azrad <[email protected]>; [email protected]
Subject: RE: [EXT] [dpdk-dev] [PATCH]crypto/mlx5: support timestamp formatExternal email: Use caution opening links or attachments
Quoted 9 lines
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail.
The patch queries the timestamp formats supported by the hardware and sets the configuration values in queue context accordingly.
Quoted 7 lines
Quoted 5 lines
Fixes 6152534e211e ("crypto/mlx5: support queue pairs operations")Signed-off-by Michael Baum <[email protected]>---
Is this a fix or a feature, title says a new feature, but description says it as a fix.
Yes you're right.
Could you please change the title to: crypto/mlx5: fix timestamp format configuration? Or will I send v2?
Quoted 2 lines
Please align title and description of the patch.
PATCH v2 1/1 crypto/mlx5: fix timestamp format configuration
In reply to Michael BaumThis patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail.
The patch queries the timestamp formats supported by the hardware and sets the configuration values in queue context accordingly.
---
v2: Align title and description of the patch to a fix format.
drivers/crypto/mlx5/mlx5_crypto.c | 2 ++ drivers/crypto/mlx5/mlx5_crypto.h | 1 + 2 files changed, 3 insertions(+)
drivers/crypto/mlx5/mlx5_crypto.c +2 -0
@@ -707,6 +707,7 @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id, attr.wq_umem_id = qp->umem_obj->umem_id; attr.wq_umem_offset =0 ; attr.dbr_umem_id = qp->umem_obj->umem_id; + attr.ts_format =mlx5_ts_format_conv (priv->qp_ts_format); attr.dbr_address =RTE_BIT64 (log_nb_desc) * priv->wqe_set_size; qp->qp_obj =mlx5_devx_cmd_create_qp (priv->ctx, &attr);if (qp->qp_obj ==NULL ) {
@@ -1049,6 +1050,7 @@ mlx5_crypto_dev_probe(struct rte_device *dev) priv->ctx = ctx; priv->login_obj = login; priv->crypto_dev = crypto_dev; + priv->qp_ts_format = attr.qp_ts_format;if (mlx5_crypto_hw_global_prepare (priv) !=0 ) {rte_cryptodev_pmd_destroy (priv->crypto_dev);claim_zero (mlx5_glue->close_device (priv->ctx));
drivers/crypto/mlx5/mlx5_crypto.h +1 -0
@@ -25,6 +25,7 @@ struct mlx5_crypto_priv {volatile uint64_t *uar_addr;uint32_t pdn;/* Protection Domain number. */ uint32_t max_segs_num;/* Maximum supported data segs. */ +uint8_t qp_ts_format;/* Whether QP supports timestamp formats. */ struct ibv_pd *pd;struct mlx5_hlist *dek_hlist;/* Dek hash list. */ struct rte_cryptodev_config dev_config;
Signature · 1 line
2.25.1
Akhil Goyal
AppliedRe: [dpdk-dev] [EXT] [PATCH v2] crypto/mlx5: fix timestamp format configuration
Quoted 9 lines
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail.
The patch queries the timestamp formats supported by the hardware and sets the configuration values in queue context accordingly.
Quoted 8 lines
Fixes 6152534e211e ("crypto/mlx5: support queue pairs operations")Signed-off-by Michael Baum <[email protected]>Acked-by Matan Azrad <[email protected]>---
v2: Align title and description of the patch to a fix format.
Applied to dpdk-next-crypto
Thanks