Skip to contentSkip to conversation

mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis

PATCH Superseded Krish Jain 3 participants 5 messages Sep 4, 2021 – Sep 6, 2021

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Krish Jain

author
#0 lore raw

PATCH v2 1/1 mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis

From: Krish Jain <[email protected]>

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/staging/mt7621-dma/hsdma-mt7621.c +3 -7
index b0ed935de7ac..89b72a802800 100644
@@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
 	struct mtk_hsdma_chan chan[1];
 };
 
-static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
-		struct mtk_hsdma_chan *chan)
+static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
 	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
 			ddev);
@@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
 	return container_of(c, struct mtk_hsdma_chan, vchan.chan);
 }
 
-static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
-		struct virt_dma_desc *vdesc)
+static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
 {
 	return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
 }
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
Signature · 1 line
2.25.1
author
#1 lore raw
Quoted 47 lines · Krish Jain

From: Krish Jain <[email protected]>

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/staging/mt7621-dma/hsdma-mt7621.c +3 -8
index b0ed935de7ac..89b72a802800 100644
@@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
        struct mtk_hsdma_chan chan[1];
 };
 
-static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
-               struct mtk_hsdma_chan *chan)
+static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
        return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
                        ddev);
@@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
        return container_of(c, struct mtk_hsdma_chan, vchan.chan);
 }
 
-static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
-               struct virt_dma_desc *vdesc)
+static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
 {
        return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
 }
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
        spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-               struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-               size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
 {
        struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
        struct mtk_hsdma_desc *desc;
--
Quoted 2 lines

2.25.1

Hi, Greg, just to follow up on this, is this submission OK?

Best Regards,

Krish

#2 lore raw
Quoted 4 lines · Krish Jain
Quoted 4 lines
drivers/staging/mt7621-dma/hsdma-mt7621.c +1 -3
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-               struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-               size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
Quoted 8 lines
Quoted 6 lines
 {
        struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
        struct mtk_hsdma_desc *desc;

--
2.25.1

Hi, Greg, just to follow up on this, is this submission OK?

Please, give us a minumum of two weeks to respond before asking for feedback. We will get to it. There is no rush.

regards,
dan carpenter

#3 lore raw
In reply to Krish Jain

drivers/staging/mt7621-dma/hsdma-mt7621.c static void mtk_hsdma_issue_pending(struct dma_chan *c) · line 458

Quoted 8 lines · Krish Jain
drivers/staging/mt7621-dma/hsdma-mt7621.c +1 -3
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)

This line is too long now.

regards,
dan carpenter

maintainer
#4 lore raw
In reply to Krish Jain
Quoted 9 lines · Krish Jain

From: Krish Jain <[email protected]>

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Any reason why you didn't match up other patches for this driver for the subject line?

$ git log --oneline drivers/staging/mt7621-dma/ | head
1f92798cbe7f staging/mt7621-dma: mtk-hsdma.c->hsdma-mt7621.c
d887d6104ade staging: mt7621-dma: Fix a resource leak in an error handling path
773cfe0684a3 staging: mt7621-dma: fix alignment warnings
08446a45d194 staging: mt7621-dma: convert tasklets to use new tasklet_setup() API
5d6633b26bc3 staging: mt7621-dma: quoted string split across lines
e71903106721 staging: mt7621-dma: align to match open parenthesis
62a6e25ed677 staging: mt7621-dma: Remove unnecessary line continuations
390e4f967299 staging: mt7621-dma: use devm_platform_ioremap_resource() to simplify code
04d15d5cadb8 staging: Remove dev_err() usage after platform_get_irq()
4c1d2fc7d56c staging: mt7621-dma: sizeof via pointer dereference

Please always put 'staging' as the prefix here, so that our tools catch things easily.

Quoted 39 lines
drivers/staging/mt7621-dma/hsdma-mt7621.c +3 -7
index b0ed935de7ac..89b72a802800 100644
@@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
 	struct mtk_hsdma_chan chan[1];
 };
 
-static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
-		struct mtk_hsdma_chan *chan)
+static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
 	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
 			ddev);
@@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
 	return container_of(c, struct mtk_hsdma_chan, vchan.chan);
 }
 
-static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
-		struct virt_dma_desc *vdesc)
+static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
 {
 	return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
 }
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
Signature · 1 line
2.25.1

What happens when you run this patch through checkpatch.pl? Didn't you just add new warnings with your attempt to fix them?

thanks,

greg k-h