Inclusive language changes
Subsystems (2)
v4 cover Inclusive language changes
From: Archie Pusaka <[email protected]>
Hi BlueZ maintainers,
This series of patches promotes the usage of the more inclusive terms such as central/peripheral, accept list/reject list, or their equivalent where appropriate.
This is also reflected on the changes to Core spec v5.3 and the appropriate language mapping table by Bluetooth SIG
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
As you suggested, I dropped the Android changes and merge patches which belong to the same directory into one patch.
Note that the following terms are not replaced:
(1) those involving storage format (i.e. storing LTK)
(2) those which belong to the libbluetooth API
Thanks,
Archie
Changes in v4:
* Fix line over 80 columns
Changes in v3:
* Not replacing some terms which belong to libluetooth API
Changes in v2:
* Merging several patches from the same directory into one
Archie Pusaka (12):
lib: Inclusive language changes
btio: Inclusive language changes
monitor: Inclusive language changes
emulator: Inclusive language changes
tools: Inclusive language changes
plugins/sixaxis: Inclusive language changes
profiles: Inclusive language changes
src: Inclusive language changes
client: Inclusive language changes
mesh: Inclusive language changes
unit/mesh: Inclusive language changes
doc: Inclusive language update
android/a2dp.c | 2 +- android/bluetooth.c | 4 +- android/handsfree-client.c | 2 +- android/tester-main.c | 2 +- btio/btio.c | 42 ++-- btio/btio.h | 2 +- client/main.c | 6 +- doc/mesh-api.txt | 2 +- doc/mgmt-api.txt | 6 +- emulator/btdev.c | 204 +++++++++--------- emulator/hciemu.c | 21 +- emulator/hciemu.h | 12 +- emulator/le.c | 116 +++++------ emulator/serial.c | 6 +- emulator/smp.c | 8 +- lib/hci.c | 22 +- lib/mgmt.h | 2 +- mesh/net-keys.c | 38 ++-- mesh/net-keys.h | 8 +- mesh/net.h | 4 +- monitor/broadcom.c | 8 +- monitor/bt.h | 150 +++++++------- monitor/control.c | 14 +- monitor/l2cap.c | 10 +- monitor/ll.c | 60 +++--- monitor/lmp.c | 2 +- monitor/packet.c | 411 +++++++++++++++++++------------------ plugins/sixaxis.c | 44 ++-- profiles/audio/a2dp.c | 2 +- profiles/audio/avctp.c | 10 +- profiles/audio/avctp.h | 2 +- profiles/health/mcap.c | 20 +- profiles/health/mcap.h | 2 +- profiles/sap/server.c | 2 +- src/adapter.c | 113 +++++----- src/adapter.h | 4 +- src/device.c | 6 +- src/sdpd-server.c | 8 +- src/sdpd.h | 2 +- src/shared/ad.c | 8 +- src/shared/ad.h | 2 +- src/shared/hfp.c | 4 +- src/shared/hfp.h | 2 +- tools/3dsp.c | 62 +++--- tools/bdaddr.rst | 2 +- tools/btiotest.c | 22 +- tools/btpclientctl.c | 2 +- tools/hci-tester.c | 16 +- tools/hciconfig.c | 148 ++++++++----- tools/hciconfig.rst | 24 +-- tools/hcitool.c | 102 ++++----- tools/hcitool.rst | 30 +-- tools/l2cap-tester.c | 36 ++-- tools/l2test.c | 18 +- tools/mesh-cfgclient.c | 4 +- tools/mesh-gatt/mesh-net.h | 4 +- tools/mesh-gatt/net.c | 60 +++--- tools/mesh/mesh-db.c | 28 ++- tools/mesh/mesh-db.h | 4 +- tools/mesh/remote.c | 53 +++-- tools/mesh/remote.h | 5 +- tools/meshctl.c | 6 +- tools/mgmt-tester.c | 138 +++++++------ tools/oobtest.c | 12 +- tools/parser/avdtp.c | 11 +- tools/parser/csr.c | 17 +- tools/parser/ericsson.c | 2 +- tools/parser/hci.c | 38 ++-- tools/parser/lmp.c | 112 +++++----- tools/parser/parser.h | 2 +- tools/parser/smp.c | 12 +- tools/rctest.c | 19 +- tools/rctest.rst | 4 +- tools/rfcomm-tester.c | 14 +- tools/rfcomm.c | 15 +- tools/rfcomm.rst | 2 +- tools/sco-tester.c | 10 +- tools/smp-tester.c | 16 +- unit/test-mesh-crypto.c | 4 +- 79 files changed, 1256 insertions(+), 1193 deletions(-)
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 1/12 lib: Inclusive language changes
From: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", and "accept list".
---
(no changes since v3)
Changes in v3:
* Not replacing some terms which belong to libluetooth API
Changes in v2:
* Merging several patches from the same directory into one
android/bluetooth.c | 4 ++-- lib/hci.c | 22 +++++++++++----------- lib/mgmt.h | 2 +- monitor/control.c | 4 ++-- src/adapter.c | 4 ++-- tools/oobtest.c | 4 ++-- 6 files changed, 20 insertions(+), 20 deletions(-)
android/bluetooth.c +2 -2
@@ -2276,7 +2276,7 @@ static void new_long_term_key_event(uint16_t index, uint16_t length, ediv =le16_to_cpu (key->ediv); rand =le64_to_cpu (key->rand); -store_ltk (&key->addr.bdaddr, key->addr.type, key->master, +store_ltk (&key->addr.bdaddr, key->addr.type, key->central, key->val, key->type, key->enc_size, ediv, rand); }
@@ -3097,7 +3097,7 @@ static struct mgmt_ltk_info *get_ltk_info(GKeyFile *key_file, const char *peer, info->ediv =g_key_file_get_integer (key_file, peer, ediv_s,NULL ); info->ediv =cpu_to_le16 (info->ediv); - info->master = master; + info->central = master; failed:g_free (key);
lib/hci.c +11 -11
@@ -288,7 +288,7 @@ int hci_strtolp(char *str, unsigned int *val)static hci_map link_mode_map[] = { {"NONE" ,0 }, {"ACCEPT" ,HCI_LM_ACCEPT }, - {"MASTER" ,HCI_LM_MASTER }, + {"CENTRAL" ,HCI_LM_MASTER }, {"AUTH" ,HCI_LM_AUTH }, {"ENCRYPT" ,HCI_LM_ENCRYPT }, {"TRUSTED" ,HCI_LM_TRUSTED },
@@ -305,7 +305,7 @@ char *hci_lmtostr(unsigned int lm) *str =0 ;if (!(lm &HCI_LM_MASTER )) -strcpy (str,"SLAVE " ); +strcpy (str,"PERIPHERAL " ); s =hci_bit2str (link_mode_map, lm);if (!s) {
@@ -345,7 +345,7 @@ static hci_map commands_map[] = { { "Set Connection Encryption", 16 }, { "Change Connection Link Key", 17 }, - { "Master Link Key", 18 }, + { "Temporary Link Key", 18 }, { "Remote Name Request", 19 }, { "Cancel Remote Name Request", 20 }, { "Read Remote Supported Features", 21 },
@@ -565,11 +565,11 @@ static hci_map commands_map[] = { { "LE Set Scan Enable", 211 }, { "LE Create Connection", 212 }, { "LE Create Connection Cancel", 213 }, - { "LE Read White List Size", 214 }, - { "LE Clear White List", 215 }, + { "LE Read Accept List Size", 214 }, + { "LE Clear Accept List", 215 }, - { "LE Add Device To White List", 216 }, - { "LE Remove Device From White List", 217 }, + { "LE Add Device To Accept List", 216 }, + { "LE Remove Device From Accept List", 217 }, { "LE Connection Update", 218 }, { "LE Set Host Channel Classification", 219 }, { "LE Read Channel Map", 220 },
@@ -735,8 +735,8 @@ static hci_map lmp_features_map[8][9] = { { "<EV4 packets>", LMP_EV4 }, /* Bit 0 */ { "<EV5 packets>", LMP_EV5 }, /* Bit 1 */ { "<no. 34>", 0x04 }, /* Bit 2 */ - { "<AFH cap. slave>", LMP_AFH_CAP_SLV }, /* Bit 3 */ - { "<AFH class. slave>", LMP_AFH_CLS_SLV }, /* Bit 4 */ + { "<AFH cap. perip.>", LMP_AFH_CAP_SLV }, /* Bit 3 */ + { "<AFH cls. perip.>", LMP_AFH_CLS_SLV }, /* Bit 4 */ { "<BR/EDR not supp.>", LMP_NO_BREDR }, /* Bit 5 */ { "<LE support>", LMP_LE }, /* Bit 6 */ { "<3-slot EDR ACL>", LMP_EDR_3SLOT }, /* Bit 7 */
@@ -746,8 +746,8 @@ static hci_map lmp_features_map[8][9] = { { "<5-slot EDR ACL>", LMP_EDR_5SLOT }, /* Bit 0 */ { "<sniff subrating>", LMP_SNIFF_SUBR }, /* Bit 1 */ { "<pause encryption>", LMP_PAUSE_ENC }, /* Bit 2 */ - { "<AFH cap. master>", LMP_AFH_CAP_MST }, /* Bit 3 */ - { "<AFH class. master>",LMP_AFH_CLS_MST }, /* Bit 4 */ + { "<AFH cap. central>", LMP_AFH_CAP_MST }, /* Bit 3 */ + { "<AFH cls. central>", LMP_AFH_CLS_MST }, /* Bit 4 */ { "<EDR eSCO 2 Mbps>", LMP_EDR_ESCO_2M }, /* Bit 5 */ { "<EDR eSCO 3 Mbps>", LMP_EDR_ESCO_3M }, /* Bit 6 */ { "<3-slot EDR eSCO>", LMP_EDR_3S_ESCO }, /* Bit 7 */
lib/mgmt.h +1 -1
@@ -179,7 +179,7 @@ struct mgmt_cp_load_link_keys {struct mgmt_ltk_info {struct mgmt_addr_info addr;uint8_t type; -uint8_t master; +uint8_t central;uint8_t enc_size;uint16_t ediv;uint64_t rand;
monitor/control.c +2 -2
@@ -308,13 +308,13 @@ static void mgmt_new_long_term_key(uint16_t len, const void *buf)/* LE SC keys are both for master and slave */ switch (ev->key.type) {case 0x00 : -if (ev->key.master) +if (ev->key.central) type ="Master (Unauthenticated)" ;else type ="Slave (Unauthenticated)" ;break ;case 0x01 : -if (ev->key.master) +if (ev->key.central) type ="Master (Authenticated)" ;else type ="Slave (Authenticated)" ;
src/adapter.c +2 -2
@@ -4122,7 +4122,7 @@ static void load_ltks(struct btd_adapter *adapter, GSList *keys) key->rand =cpu_to_le64 (info->rand); key->ediv =cpu_to_le16 (info->ediv); key->type = info->authenticated; - key->master = info->master; + key->central = info->master; key->enc_size = info->enc_size; }
@@ -8307,7 +8307,7 @@ static void new_long_term_key_callback(uint16_t index, uint16_t length, rand =le64_to_cpu (key->rand);store_longtermkey (adapter, &key->addr.bdaddr, - key->addr.type, key->val, key->master, + key->addr.type, key->val, key->central, key->type, key->enc_size, ediv, rand);device_set_bonded (device, addr->type);
tools/oobtest.c +2 -2
@@ -133,13 +133,13 @@ static void new_long_term_key_event(uint16_t index, uint16_t len,switch (ev->key.type) {case 0x00 : -if (ev->key.master) +if (ev->key.central) type ="Unauthenticated, Master" ;else type ="Unauthenticated, Slave" ;break ;case 0x01 : -if (ev->key.master) +if (ev->key.central) type ="Authenticated, Master" ;else type ="Authenticated, Slave" ;
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=542379
---Test result---
Test Summary:
CheckPatch FAIL 4.00 seconds GitLint FAIL 1.20 seconds Prep - Setup ELL PASS 39.57 seconds Build - Prep PASS 0.09 seconds Build - Configure PASS 7.17 seconds Build - Make PASS 167.55 seconds Make Check PASS 8.70 seconds Make Distcheck PASS 202.81 seconds Build w/ext ELL - Configure PASS 7.12 seconds Build w/ext ELL - Make PASS 158.55 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
tools: Inclusive language changes
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10:
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
ERROR:INITIALISED_STATIC: do not initialise statics to 0 #985: FILE: tools/l2test.c:113:
+static int central = 0;
WARNING:MISSING_SPACE: break quoted strings at a space character #1030: FILE: tools/l2test.c:1340:
while ((opt = getopt(argc, argv, "a:b:cde:g:i:mnpqrstuwxyz"
+ "AB:CD:EF:GH:I:J:K:L:M:N:O:P:Q:RSTUV:W:X:Y:Z:")) != EOF) {
ERROR:INITIALISED_STATIC: do not initialise statics to 0 #2331: FILE: tools/rctest.c:79:
+static int central = 0;
ERROR:INITIALISED_STATIC: do not initialise statics to 0 #2483: FILE: tools/rfcomm.c:40:
+static int central = 0;
- total: 3 errors, 2 warnings, 2296 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] tools: Inclusive language changes" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
profiles: Inclusive language changes WARNING:LONG_LINE_COMMENT: line length of 100 exceeds 80 columns #116: FILE: profiles/health/mcap.h:273:
+ mcap_info_ind_event_cb mcl_sync_infoind_cb; /* (CSP Central) Received info indication */
- total: 0 errors, 1 warnings, 87 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] profiles: Inclusive language changes" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
src: Inclusive language changes
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10:
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
ERROR:INITIALISED_STATIC: do not initialise statics to NULL #36: FILE: src/adapter.c:115:
+static struct mgmt *mgmt_primary = NULL;
- total: 1 errors, 1 warnings, 478 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] src: Inclusive language changes" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
mesh: Inclusive language changes
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
ERROR:INITIALISED_STATIC: do not initialise statics to 0 #28: FILE: mesh/net-keys.c:56:
+static uint32_t last_flooding_id = 0;
- total: 1 errors, 1 warnings, 146 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] mesh: Inclusive language changes" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
unit/mesh: Inclusive language changes
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
- total: 0 errors, 1 warnings, 16 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] unit/mesh: Inclusive language changes" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
tools: Inclusive language changes
7: B1 Line exceeds max length (95>80): "https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf"
src: Inclusive language changes
7: B1 Line exceeds max length (95>80): "https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf"
mesh: Inclusive language changes
4: B1 Line exceeds max length (95>80): "https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf"
unit/mesh: Inclusive language changes
4: B1 Line exceeds max length (95>80): "https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf"
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
Marcel Holtmann
maintainerRe: [Bluez PATCH v4 01/12] lib: Inclusive language changes
In reply to Archie PusakaHi Archie,
Quoted 48 lines
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", and "accept list".
---(no changes since v3)
Changes in v3:
* Not replacing some terms which belong to libluetooth APIChanges in v2:
* Merging several patches from the same directory into oneandroid/bluetooth.c | 4 ++-- lib/hci.c | 22 +++++++++++----------- lib/mgmt.h | 2 +- monitor/control.c | 4 ++-- src/adapter.c | 4 ++-- tools/oobtest.c | 4 ++-- 6 files changed, 20 insertions(+), 20 deletions(-)android/bluetooth.c +2
-2@@ -2276,7 +2276,7 @@ static void new_long_term_key_event(uint16_t index, uint16_t length, ediv =le16_to_cpu (key->ediv); rand =le64_to_cpu (key->rand); -store_ltk (&key->addr.bdaddr, key->addr.type, key->master, +store_ltk (&key->addr.bdaddr, key->addr.type, key->central, key->val, key->type, key->enc_size, ediv, rand); }@@ -3097,7 +3097,7 @@ static struct mgmt_ltk_info *get_ltk_info(GKeyFile *key_file, const char *peer, info->ediv =g_key_file_get_integer (key_file, peer, ediv_s,NULL ); info->ediv =cpu_to_le16 (info->ediv); - info->master = master; + info->central = master;failed:
g_free(key);lib/hci.c +0
-0
lib/hci.c int hci_strtolp(char *str, unsigned int *val) · line 294
Quoted 8 lines
lib/hci.c +1
-1@@ -288,7 +288,7 @@ int hci_strtolp(char *str, unsigned int *val)static hci_map link_mode_map[] = { {"NONE" ,0 }, {"ACCEPT" ,HCI_LM_ACCEPT }, - {"MASTER" ,HCI_LM_MASTER }, + {"CENTRAL" ,HCI_LM_MASTER }, {"AUTH" ,HCI_LM_AUTH }, {"ENCRYPT" ,HCI_LM_ENCRYPT }, {"TRUSTED" ,HCI_LM_TRUSTED },
you can't do this since it actually maps to input of hciconfig tool. You really need to check where link_mode_map is used.
Quoted 121 lines
lib/hci.c +10
-10@@ -305,7 +305,7 @@ char *hci_lmtostr(unsigned int lm) *str =0 ;if (!(lm &HCI_LM_MASTER )) -strcpy (str,"SLAVE " ); +strcpy (str,"PERIPHERAL " ); s =hci_bit2str (link_mode_map, lm);if (!s) {@@ -345,7 +345,7 @@ static hci_map commands_map[] = { { "Set Connection Encryption", 16 }, { "Change Connection Link Key", 17 }, - { "Master Link Key", 18 }, + { "Temporary Link Key", 18 }, { "Remote Name Request", 19 }, { "Cancel Remote Name Request", 20 }, { "Read Remote Supported Features", 21 },@@ -565,11 +565,11 @@ static hci_map commands_map[] = { { "LE Set Scan Enable", 211 }, { "LE Create Connection", 212 }, { "LE Create Connection Cancel", 213 }, - { "LE Read White List Size", 214 }, - { "LE Clear White List", 215 }, + { "LE Read Accept List Size", 214 }, + { "LE Clear Accept List", 215 }, - { "LE Add Device To White List", 216 }, - { "LE Remove Device From White List", 217 }, + { "LE Add Device To Accept List", 216 }, + { "LE Remove Device From Accept List", 217 }, { "LE Connection Update", 218 }, { "LE Set Host Channel Classification", 219 }, { "LE Read Channel Map", 220 },@@ -735,8 +735,8 @@ static hci_map lmp_features_map[8][9] = { { "<EV4 packets>", LMP_EV4 }, /* Bit 0 */ { "<EV5 packets>", LMP_EV5 }, /* Bit 1 */ { "<no. 34>", 0x04 }, /* Bit 2 */ - { "<AFH cap. slave>", LMP_AFH_CAP_SLV }, /* Bit 3 */ - { "<AFH class. slave>", LMP_AFH_CLS_SLV }, /* Bit 4 */ + { "<AFH cap. perip.>", LMP_AFH_CAP_SLV }, /* Bit 3 */ + { "<AFH cls. perip.>", LMP_AFH_CLS_SLV }, /* Bit 4 */ { "<BR/EDR not supp.>", LMP_NO_BREDR }, /* Bit 5 */ { "<LE support>", LMP_LE }, /* Bit 6 */ { "<3-slot EDR ACL>", LMP_EDR_3SLOT }, /* Bit 7 */@@ -746,8 +746,8 @@ static hci_map lmp_features_map[8][9] = { { "<5-slot EDR ACL>", LMP_EDR_5SLOT }, /* Bit 0 */ { "<sniff subrating>", LMP_SNIFF_SUBR }, /* Bit 1 */ { "<pause encryption>", LMP_PAUSE_ENC }, /* Bit 2 */ - { "<AFH cap. master>", LMP_AFH_CAP_MST }, /* Bit 3 */ - { "<AFH class. master>",LMP_AFH_CLS_MST }, /* Bit 4 */ + { "<AFH cap. central>", LMP_AFH_CAP_MST }, /* Bit 3 */ + { "<AFH cls. central>", LMP_AFH_CLS_MST }, /* Bit 4 */ { "<EDR eSCO 2 Mbps>", LMP_EDR_ESCO_2M }, /* Bit 5 */ { "<EDR eSCO 3 Mbps>", LMP_EDR_ESCO_3M }, /* Bit 6 */ { "<3-slot EDR eSCO>", LMP_EDR_3S_ESCO }, /* Bit 7 */lib/mgmt.h +1
-1@@ -179,7 +179,7 @@ struct mgmt_cp_load_link_keys {struct mgmt_ltk_info {struct mgmt_addr_info addr;uint8_t type; -uint8_t master; +uint8_t central;uint8_t enc_size;uint16_t ediv;uint64_t rand;monitor/control.c +2
-2@@ -308,13 +308,13 @@ static void mgmt_new_long_term_key(uint16_t len, const void *buf)/* LE SC keys are both for master and slave */ switch (ev->key.type) {case 0x00 : -if (ev->key.master) +if (ev->key.central) type ="Master (Unauthenticated)" ;else type ="Slave (Unauthenticated)" ;break ;case 0x01 : -if (ev->key.master) +if (ev->key.central) type ="Master (Authenticated)" ;else type ="Slave (Authenticated)" ;src/adapter.c +2
-2@@ -4122,7 +4122,7 @@ static void load_ltks(struct btd_adapter *adapter, GSList *keys) key->rand =cpu_to_le64 (info->rand); key->ediv =cpu_to_le16 (info->ediv); key->type = info->authenticated; - key->master = info->master; + key->central = info->master; key->enc_size = info->enc_size; }@@ -8307,7 +8307,7 @@ static void new_long_term_key_callback(uint16_t index, uint16_t length, rand =le64_to_cpu (key->rand);store_longtermkey (adapter, &key->addr.bdaddr, - key->addr.type, key->val, key->master, + key->addr.type, key->val, key->central, key->type, key->enc_size, ediv, rand);device_set_bonded (device, addr->type);tools/oobtest.c +1
-1@@ -133,13 +133,13 @@ static void new_long_term_key_event(uint16_t index, uint16_t len,switch (ev->key.type) {case 0x00 : -if (ev->key.master) +if (ev->key.central)
tools/oobtest.c static void new_long_term_key_event(uint16_t index, uint16_t len, · line 145
Quoted 10 lines
tools/oobtest.c +1
-1type ="Unauthenticated, Master" ; else type ="Unauthenticated, Slave" ;break ;case 0x01 : -if (ev->key.master) +if (ev->key.central) type ="Authenticated, Master" ;else type ="Authenticated, Slave" ;
These strings you could have changed. It is just a test tool and not installed.
Regards
Marcel
Re: [Bluez PATCH v4 01/12] lib: Inclusive language changes
Hi Marcel,
Quoted 53 lines · Marcel Holtmann
Hi Archie,
Quoted 50 lines
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", and "accept list".
---(no changes since v3)
Changes in v3:
* Not replacing some terms which belong to libluetooth APIChanges in v2:
* Merging several patches from the same directory into oneandroid/bluetooth.c | 4 ++-- lib/hci.c | 22 +++++++++++----------- lib/mgmt.h | 2 +- monitor/control.c | 4 ++-- src/adapter.c | 4 ++-- tools/oobtest.c | 4 ++-- 6 files changed, 20 insertions(+), 20 deletions(-)android/bluetooth.c +2
-2@@ -2276,7 +2276,7 @@ static void new_long_term_key_event(uint16_t index, uint16_t length, ediv =le16_to_cpu (key->ediv); rand =le64_to_cpu (key->rand); -store_ltk (&key->addr.bdaddr, key->addr.type, key->master, +store_ltk (&key->addr.bdaddr, key->addr.type, key->central, key->val, key->type, key->enc_size, ediv, rand); }@@ -3097,7 +3097,7 @@ static struct mgmt_ltk_info *get_ltk_info(GKeyFile *key_file, const char *peer, info->ediv =g_key_file_get_integer (key_file, peer, ediv_s,NULL ); info->ediv =cpu_to_le16 (info->ediv); - info->master = master; + info->central = master;failed:
g_free(key);lib/hci.c +0
-0@@ -288,7 +288,7 @@ int hci_strtolp(char *str, unsigned int *val)static hci_map link_mode_map[] = { {"NONE" ,0 },
Quoted 8 lines
lib/hci.c int hci_strtolp(char *str, unsigned int *val) · line 294
Quoted 6 lines
lib/hci.c +1
-1{ "ACCEPT", HCI_LM_ACCEPT }, - { "MASTER", HCI_LM_MASTER }, + { "CENTRAL", HCI_LM_MASTER }, { "AUTH", HCI_LM_AUTH }, { "ENCRYPT", HCI_LM_ENCRYPT }, { "TRUSTED", HCI_LM_TRUSTED },you can't do this since it actually maps to input of hciconfig tool. You really need to check where
link_mode_mapis used.
But I also changed the documentation of hciconfig on patch 05/12. Are you concerned about that being not in the same patch as this change, or we shouldn't change the input of any of the tools? If it is the latter, then I also need to make changes to many of the tools in patch 05/12.
Quoted 118 lines
Quoted 118 lines
lib/hci.c +10
-10@@ -305,7 +305,7 @@ char *hci_lmtostr(unsigned int lm) *str =0 ;if (!(lm &HCI_LM_MASTER )) -strcpy (str,"SLAVE " ); +strcpy (str,"PERIPHERAL " ); s =hci_bit2str (link_mode_map, lm);if (!s) {@@ -345,7 +345,7 @@ static hci_map commands_map[] = { { "Set Connection Encryption", 16 }, { "Change Connection Link Key", 17 }, - { "Master Link Key", 18 }, + { "Temporary Link Key", 18 }, { "Remote Name Request", 19 }, { "Cancel Remote Name Request", 20 }, { "Read Remote Supported Features", 21 },@@ -565,11 +565,11 @@ static hci_map commands_map[] = { { "LE Set Scan Enable", 211 }, { "LE Create Connection", 212 }, { "LE Create Connection Cancel", 213 }, - { "LE Read White List Size", 214 }, - { "LE Clear White List", 215 }, + { "LE Read Accept List Size", 214 }, + { "LE Clear Accept List", 215 }, - { "LE Add Device To White List", 216 }, - { "LE Remove Device From White List", 217 }, + { "LE Add Device To Accept List", 216 }, + { "LE Remove Device From Accept List", 217 }, { "LE Connection Update", 218 }, { "LE Set Host Channel Classification", 219 }, { "LE Read Channel Map", 220 },@@ -735,8 +735,8 @@ static hci_map lmp_features_map[8][9] = { { "<EV4 packets>", LMP_EV4 }, /* Bit 0 */ { "<EV5 packets>", LMP_EV5 }, /* Bit 1 */ { "<no. 34>", 0x04 }, /* Bit 2 */ - { "<AFH cap. slave>", LMP_AFH_CAP_SLV }, /* Bit 3 */ - { "<AFH class. slave>", LMP_AFH_CLS_SLV }, /* Bit 4 */ + { "<AFH cap. perip.>", LMP_AFH_CAP_SLV }, /* Bit 3 */ + { "<AFH cls. perip.>", LMP_AFH_CLS_SLV }, /* Bit 4 */ { "<BR/EDR not supp.>", LMP_NO_BREDR }, /* Bit 5 */ { "<LE support>", LMP_LE }, /* Bit 6 */ { "<3-slot EDR ACL>", LMP_EDR_3SLOT }, /* Bit 7 */@@ -746,8 +746,8 @@ static hci_map lmp_features_map[8][9] = { { "<5-slot EDR ACL>", LMP_EDR_5SLOT }, /* Bit 0 */ { "<sniff subrating>", LMP_SNIFF_SUBR }, /* Bit 1 */ { "<pause encryption>", LMP_PAUSE_ENC }, /* Bit 2 */ - { "<AFH cap. master>", LMP_AFH_CAP_MST }, /* Bit 3 */ - { "<AFH class. master>",LMP_AFH_CLS_MST }, /* Bit 4 */ + { "<AFH cap. central>", LMP_AFH_CAP_MST }, /* Bit 3 */ + { "<AFH cls. central>", LMP_AFH_CLS_MST }, /* Bit 4 */ { "<EDR eSCO 2 Mbps>", LMP_EDR_ESCO_2M }, /* Bit 5 */ { "<EDR eSCO 3 Mbps>", LMP_EDR_ESCO_3M }, /* Bit 6 */ { "<3-slot EDR eSCO>", LMP_EDR_3S_ESCO }, /* Bit 7 */lib/mgmt.h +1
-1@@ -179,7 +179,7 @@ struct mgmt_cp_load_link_keys {struct mgmt_ltk_info {struct mgmt_addr_info addr;uint8_t type; -uint8_t master; +uint8_t central;uint8_t enc_size;uint16_t ediv;uint64_t rand;monitor/control.c +2
-2@@ -308,13 +308,13 @@ static void mgmt_new_long_term_key(uint16_t len, const void *buf)/* LE SC keys are both for master and slave */ switch (ev->key.type) {case 0x00 : -if (ev->key.master) +if (ev->key.central) type ="Master (Unauthenticated)" ;else type ="Slave (Unauthenticated)" ;break ;case 0x01 : -if (ev->key.master) +if (ev->key.central) type ="Master (Authenticated)" ;else type ="Slave (Authenticated)" ;src/adapter.c +2
-2@@ -4122,7 +4122,7 @@ static void load_ltks(struct btd_adapter *adapter, GSList *keys) key->rand =cpu_to_le64 (info->rand); key->ediv =cpu_to_le16 (info->ediv); key->type = info->authenticated; - key->master = info->master; + key->central = info->master; key->enc_size = info->enc_size; }@@ -8307,7 +8307,7 @@ static void new_long_term_key_callback(uint16_t index, uint16_t length, rand =le64_to_cpu (key->rand);store_longtermkey (adapter, &key->addr.bdaddr, - key->addr.type, key->val, key->master, + key->addr.type, key->val, key->central, key->type, key->enc_size, ediv, rand);device_set_bonded (device, addr->type);tools/oobtest.c +0
-0@@ -133,13 +133,13 @@ static void new_long_term_key_event(uint16_t index, uint16_t len,
Quoted 16 lines
Quoted 4 lines
tools/oobtest.c +1
-1switch (ev->key.type) {case 0x00 : -if (ev->key.master) +if (ev->key.central)tools/oobtest.c static void new_long_term_key_event(uint16_t index, uint16_t len, · line 145
Quoted 10 lines
tools/oobtest.c +1
-1type ="Unauthenticated, Master" ; else type ="Unauthenticated, Slave" ;break ;case 0x01 : -if (ev->key.master) +if (ev->key.central) type ="Authenticated, Master" ;else type ="Authenticated, Slave" ;These strings you could have changed. It is just a test tool and not installed.
Actually, I changed them in patch 05/12.
So I tried to respect the "one directory - one patch" policy. However sometimes changes need to be done cross-directory so no way we can enforce that rule without having compile errors. Therefore, I only make the minimum necessary changes in the other directories so the code can still be compiled while respecting the "one directory - one patch" policy as much as possible.
In this patch 01/12, the changes are inside the /lib directory, so cross-directory changes, such as to /tools/oobtest.c, are unavoidable. However I prefer to update the files inside tools in their own patch (05/12), so only the necessary changes are made in patch 01/12.
Regards,
Archie
PATCH v4 2/12 btio: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL uses "central" as it is deemed to be more appropriate.
---
(no changes since v1)
android/a2dp.c | 2 +- btio/btio.c | 42 +++++++++++++++++++++--------------------- btio/btio.h | 2 +- profiles/audio/a2dp.c | 2 +- profiles/audio/avctp.c | 2 +- profiles/sap/server.c | 2 +- tools/btiotest.c | 8 ++++---- 7 files changed, 30 insertions(+), 30 deletions(-)
android/a2dp.c +1 -1
@@ -1692,7 +1692,7 @@ bool bt_a2dp_register(struct ipc *ipc, const bdaddr_t *addr, uint8_t mode)BT_IO_OPT_SOURCE_BDADDR , &adapter_addr,BT_IO_OPT_PSM ,AVDTP_PSM ,BT_IO_OPT_SEC_LEVEL ,BT_IO_SEC_MEDIUM , -BT_IO_OPT_MASTER , true, +BT_IO_OPT_CENTRAL , true, BT_IO_OPT_INVALID);if (!server) {error ("Failed to listen on AVDTP channel: %s" , err->message);
btio/btio.c +21 -21
144 lines not on this page · raw message
btio/btio.h +1 -1
@@ -36,7 +36,7 @@ typedef enum {BT_IO_OPT_MTU ,BT_IO_OPT_OMTU ,BT_IO_OPT_IMTU , -BT_IO_OPT_MASTER , +BT_IO_OPT_CENTRAL ,BT_IO_OPT_HANDLE ,BT_IO_OPT_CLASS , BT_IO_OPT_MODE,
profiles/audio/a2dp.c +1 -1
@@ -2518,7 +2518,7 @@ static bool a2dp_server_listen(struct a2dp_server *server)BT_IO_OPT_PSM ,AVDTP_PSM ,BT_IO_OPT_MODE , mode,BT_IO_OPT_SEC_LEVEL ,BT_IO_SEC_MEDIUM , -BT_IO_OPT_MASTER , true, +BT_IO_OPT_CENTRAL , true, BT_IO_OPT_INVALID);if (server->io)return true;
profiles/audio/avctp.c +1 -1
@@ -1625,7 +1625,7 @@ static GIOChannel *avctp_server_socket(const bdaddr_t *src, gboolean master,BT_IO_OPT_SOURCE_BDADDR , src,BT_IO_OPT_PSM , psm,BT_IO_OPT_SEC_LEVEL ,BT_IO_SEC_MEDIUM , -BT_IO_OPT_MASTER , master, +BT_IO_OPT_CENTRAL , master,BT_IO_OPT_MODE , mode, BT_IO_OPT_INVALID);if (!io) {
profiles/sap/server.c +1 -1
@@ -1369,7 +1369,7 @@ int sap_server_register(struct btd_adapter *adapter)btd_adapter_get_address (adapter),BT_IO_OPT_CHANNEL ,SAP_SERVER_CHANNEL ,BT_IO_OPT_SEC_LEVEL ,BT_IO_SEC_HIGH , -BT_IO_OPT_MASTER , TRUE, +BT_IO_OPT_CENTRAL , TRUE, BT_IO_OPT_INVALID);if (!io) {error ("Can't listen at channel %d." ,SAP_SERVER_CHANNEL );
tools/btiotest.c +4 -4
@@ -343,7 +343,7 @@ static void l2cap_listen(const char *src, uint8_t addr_type, uint16_t psm,BT_IO_OPT_PSM , psm,BT_IO_OPT_CID , cid,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_MASTER , master, +BT_IO_OPT_CENTRAL , master, BT_IO_OPT_INVALID); else l2_srv = bt_io_listen(conn, cfm, data,
@@ -353,7 +353,7 @@ static void l2cap_listen(const char *src, uint8_t addr_type, uint16_t psm,BT_IO_OPT_PSM , psm,BT_IO_OPT_CID , cid,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_MASTER , master, +BT_IO_OPT_CENTRAL , master, BT_IO_OPT_INVALID);if (!l2_srv) {
@@ -427,7 +427,7 @@ static void rfcomm_listen(const char *src, uint8_t ch, gboolean defer,BT_IO_OPT_SOURCE , src,BT_IO_OPT_CHANNEL , ch,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_MASTER , master, +BT_IO_OPT_CENTRAL , master, BT_IO_OPT_INVALID); else rc_srv = bt_io_listen(conn, cfm,
@@ -435,7 +435,7 @@ static void rfcomm_listen(const char *src, uint8_t ch, gboolean defer, &err,BT_IO_OPT_CHANNEL , ch,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_MASTER , master, +BT_IO_OPT_CENTRAL , master, BT_IO_OPT_INVALID);if (!rc_srv) {
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 3/12 monitor: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", "link key", and "accept list"
---
Changes in v4:
* Fix line over 80 columns
Changes in v2:
* Merging several patches from the same directory into one
emulator/btdev.c | 58 +++---- emulator/le.c | 32 ++-- emulator/smp.c | 8 +- monitor/broadcom.c | 8 +- monitor/bt.h | 150 ++++++++-------- monitor/control.c | 10 +- monitor/l2cap.c | 10 +- monitor/ll.c | 60 ++++--- monitor/lmp.c | 2 +- monitor/packet.c | 411 ++++++++++++++++++++++---------------------- tools/3dsp.c | 33 ++-- tools/hci-tester.c | 4 +- tools/mgmt-tester.c | 4 +- 13 files changed, 400 insertions(+), 390 deletions(-)
emulator/btdev.c +29 -29
@@ -3568,11 +3568,11 @@ static int cmd_le_create_conn_complete(struct btdev *dev, const void *data,static int cmd_read_wl_size (struct btdev *dev,const void *data,uint8_t len) { -struct bt_hci_rsp_le_read_white_list_size rsp; +struct bt_hci_rsp_le_read_accept_list_size rsp; rsp.status =BT_HCI_ERR_SUCCESS ; rsp.size =WL_SIZE ; -cmd_complete (dev,BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE , &rsp, +cmd_complete (dev,BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE , &rsp,sizeof (rsp));return 0 ;
@@ -3620,7 +3620,7 @@ static int cmd_wl_clear(struct btdev *dev, const void *data, uint8_t len)wl_clear (dev); status =BT_HCI_ERR_SUCCESS ; -cmd_complete (dev,BT_HCI_CMD_LE_CLEAR_WHITE_LIST , &status, +cmd_complete (dev,BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST , &status,sizeof (status));return 0 ;
@@ -3637,7 +3637,7 @@ static void wl_add(struct btdev_wl *wl, uint8_t type, bdaddr_t *addr)static int cmd_add_wl (struct btdev *dev,const void *data,uint8_t len) { -const struct bt_hci_cmd_le_add_to_white_list *cmd = data; +const struct bt_hci_cmd_le_add_to_accept_list *cmd = data;uint8_t status;bool exists = false;int i, pos =-1 ;
@@ -3673,14 +3673,14 @@ static int cmd_add_wl(struct btdev *dev, const void *data, uint8_t len)if (pos <0 ) {cmd_status (dev,BT_HCI_ERR_MEM_CAPACITY_EXCEEDED , -BT_HCI_CMD_LE_ADD_TO_WHITE_LIST ); +BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST );return 0 ; }wl_add (&dev->le_wl[pos], cmd->addr_type, (bdaddr_t *)&cmd->addr); status =BT_HCI_ERR_SUCCESS ; -cmd_complete (dev,BT_HCI_CMD_LE_ADD_TO_WHITE_LIST , +cmd_complete (dev,BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST , &status,sizeof (status));return 0 ;
@@ -3688,7 +3688,7 @@ static int cmd_add_wl(struct btdev *dev, const void *data, uint8_t len)static int cmd_remove_wl (struct btdev *dev,const void *data,uint8_t len) { -const struct bt_hci_cmd_le_remove_from_white_list *cmd = data; +const struct bt_hci_cmd_le_remove_from_accept_list *cmd = data;uint8_t status;int i;char addr[18 ];
@@ -3728,7 +3728,7 @@ static int cmd_remove_wl(struct btdev *dev, const void *data, uint8_t len)return -EINVAL ; status =BT_HCI_ERR_SUCCESS ; -cmd_complete (dev,BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST , +cmd_complete (dev,BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST , &status,sizeof (status));return 0 ;
@@ -4313,10 +4313,10 @@ static int cmd_gen_dhkey(struct btdev *dev, const void *data, uint8_t len) cmd_set_scan_enable_complete), \CMD (BT_HCI_CMD_LE_CREATE_CONN , cmd_le_create_conn, \ cmd_le_create_conn_complete), \ -CMD (BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE , cmd_read_wl_size,NULL ), \ -CMD (BT_HCI_CMD_LE_CLEAR_WHITE_LIST , cmd_wl_clear,NULL ), \ -CMD (BT_HCI_CMD_LE_ADD_TO_WHITE_LIST , cmd_add_wl,NULL ), \ -CMD (BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST , cmd_remove_wl,NULL ), \ +CMD (BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE , cmd_read_wl_size,NULL ), \ +CMD (BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST , cmd_wl_clear,NULL ), \ +CMD (BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST , cmd_add_wl,NULL ), \ +CMD (BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST , cmd_remove_wl,NULL ), \CMD (BT_HCI_CMD_LE_CONN_UPDATE , cmd_conn_update, \ cmd_conn_update_complete), \ CMD(BT_HCI_CMD_LE_READ_REMOTE_FEATURES, cmd_le_read_remote_features, \
@@ -5408,24 +5408,24 @@ static void le_cis_estabilished(struct btdev *dev, struct btdev_conn *conn,struct btdev *remote = conn->link->dev;/* TODO: Figure out if these values makes sense */ -memcpy (evt.cig_sync_delay, remote->le_cig.params.m_interval, -sizeof (remote->le_cig.params.m_interval)); -memcpy (evt.cis_sync_delay, remote->le_cig.params.s_interval, -sizeof (remote->le_cig.params.s_interval)); -memcpy (evt.m_latency, &remote->le_cig.params.m_latency, -sizeof (remote->le_cig.params.m_latency)); -memcpy (evt.s_latency, &remote->le_cig.params.s_latency, -sizeof (remote->le_cig.params.s_latency)); - evt.m_phy = remote->le_cig.cis[0 ].m_phy; - evt.s_phy = remote->le_cig.cis[0 ].s_phy; +memcpy (evt.cig_sync_delay, remote->le_cig.params.c_interval, +sizeof (remote->le_cig.params.c_interval)); +memcpy (evt.cis_sync_delay, remote->le_cig.params.p_interval, +sizeof (remote->le_cig.params.p_interval)); +memcpy (evt.c_latency, &remote->le_cig.params.c_latency, +sizeof (remote->le_cig.params.c_latency)); +memcpy (evt.p_latency, &remote->le_cig.params.p_latency, +sizeof (remote->le_cig.params.p_latency)); + evt.c_phy = remote->le_cig.cis[0 ].c_phy; + evt.p_phy = remote->le_cig.cis[0 ].p_phy; evt.nse =0x01 ; - evt.m_bn =0x01 ; - evt.s_bn =0x01 ; - evt.m_ft =0x01 ; - evt.s_ft =0x01 ; - evt.m_mtu = remote->le_cig.cis[0 ].m_sdu; - evt.s_mtu = remote->le_cig.cis[0 ].s_sdu; - evt.interval = remote->le_cig.params.m_latency; + evt.c_bn =0x01 ; + evt.p_bn =0x01 ; + evt.c_ft =0x01 ; + evt.p_ft =0x01 ; + evt.c_mtu = remote->le_cig.cis[0 ].c_sdu; + evt.p_mtu = remote->le_cig.cis[0 ].p_sdu; + evt.interval = remote->le_cig.params.c_latency; }le_meta_event (dev,BT_HCI_EVT_LE_CIS_ESTABLISHED , &evt,sizeof (evt));
emulator/le.c +16 -16
@@ -1211,12 +1211,12 @@ static void cmd_le_create_conn_cancel(struct bt_le *hci,static void cmd_le_read_white_list_size (struct bt_le *hci,const void *data,uint8_t size) { -struct bt_hci_rsp_le_read_white_list_size rsp; +struct bt_hci_rsp_le_read_accept_list_size rsp; rsp.status =BT_HCI_ERR_SUCCESS ; rsp.size = hci->le_white_list_size; -cmd_complete (hci,BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE , +cmd_complete (hci,BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE , &rsp,sizeof (rsp)); }
@@ -1228,14 +1228,14 @@ static void cmd_le_clear_white_list(struct bt_le *hci,clear_white_list (hci); status =BT_HCI_ERR_SUCCESS ; -cmd_complete (hci,BT_HCI_CMD_LE_CLEAR_WHITE_LIST , +cmd_complete (hci,BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST , &status,sizeof (status)); }static void cmd_le_add_to_white_list (struct bt_le *hci,const void *data,uint8_t size) { -const struct bt_hci_cmd_le_add_to_white_list *cmd = data; +const struct bt_hci_cmd_le_add_to_accept_list *cmd = data;uint8_t status;bool exists = false;int i, pos =-1 ;
@@ -1243,7 +1243,7 @@ static void cmd_le_add_to_white_list(struct bt_le *hci,/* Valid range for address type is 0x00 to 0x01 */ if (cmd->addr_type >0x01 ) {cmd_status (hci,BT_HCI_ERR_INVALID_PARAMETERS , -BT_HCI_CMD_LE_ADD_TO_WHITE_LIST ); +BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST );return ; }
@@ -1259,13 +1259,13 @@ static void cmd_le_add_to_white_list(struct bt_le *hci,if (exists) {cmd_status (hci,BT_HCI_ERR_UNSPECIFIED_ERROR , -BT_HCI_CMD_LE_ADD_TO_WHITE_LIST ); +BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST );return ; }if (pos <0 ) {cmd_status (hci,BT_HCI_ERR_MEM_CAPACITY_EXCEEDED , -BT_HCI_CMD_LE_ADD_TO_WHITE_LIST ); +BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST );return ; }
@@ -1273,21 +1273,21 @@ static void cmd_le_add_to_white_list(struct bt_le *hci,memcpy (&hci->le_white_list[pos][1 ], cmd->addr,6 ); status =BT_HCI_ERR_SUCCESS ; -cmd_complete (hci,BT_HCI_CMD_LE_ADD_TO_WHITE_LIST , +cmd_complete (hci,BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST , &status,sizeof (status)); }static void cmd_le_remove_from_white_list (struct bt_le *hci,const void *data,uint8_t size) { -const struct bt_hci_cmd_le_remove_from_white_list *cmd = data; +const struct bt_hci_cmd_le_remove_from_accept_list *cmd = data;uint8_t status;int i, pos =-1 ;/* Valid range for address type is 0x00 to 0x01 */ if (cmd->addr_type >0x01 ) {cmd_status (hci,BT_HCI_ERR_INVALID_PARAMETERS , -BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST ); +BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST );return ; }
@@ -1302,7 +1302,7 @@ static void cmd_le_remove_from_white_list(struct bt_le *hci,if (pos <0 ) {cmd_status (hci,BT_HCI_ERR_INVALID_PARAMETERS , -BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST ); +BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST );return ; }
@@ -1310,7 +1310,7 @@ static void cmd_le_remove_from_white_list(struct bt_le *hci,memset (&hci->le_white_list[pos][1 ],0 ,6 ); status =BT_HCI_ERR_SUCCESS ; -cmd_complete (hci,BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST , +cmd_complete (hci,BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST , &status,sizeof (status)); }
@@ -1830,13 +1830,13 @@ static const struct { cmd_le_create_conn, 25, true }, {BT_HCI_CMD_LE_CREATE_CONN_CANCEL , cmd_le_create_conn_cancel, 0, true }, - { BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE, + { BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE, cmd_le_read_white_list_size, 0, true }, - { BT_HCI_CMD_LE_CLEAR_WHITE_LIST, + { BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST, cmd_le_clear_white_list, 0, true }, - { BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, + { BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, cmd_le_add_to_white_list, 7, true }, - { BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, + { BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, cmd_le_remove_from_white_list, 7, true }, { BT_HCI_CMD_LE_ENCRYPT, cmd_le_encrypt, 32, true },
emulator/smp.c +4 -4
@@ -383,7 +383,7 @@ static void distribute_keys(struct smp_conn *conn)if (conn->local_key_dist &DIST_ENC_KEY ) {memset (buf,0 ,sizeof (buf));smp_send (conn,BT_L2CAP_SMP_ENCRYPT_INFO , buf,sizeof (buf)); -smp_send (conn,BT_L2CAP_SMP_MASTER_IDENT , buf,10 ); +smp_send (conn,BT_L2CAP_SMP_CENTRAL_IDENT , buf,10 ); }if (conn->local_key_dist &DIST_ID_KEY ) {
@@ -571,7 +571,7 @@ static void encrypt_info(struct smp_conn *conn, const void *data, uint16_t len) { } -static void master_ident (struct smp_conn *conn,const void *data,uint16_t len) +static void central_ident (struct smp_conn *conn,const void *data,uint16_t len) { conn->remote_key_dist &= ~DIST_ENC_KEY ;
@@ -727,8 +727,8 @@ void smp_data(void *conn_data, const void *data, uint16_t len)case BT_L2CAP_SMP_ENCRYPT_INFO :encrypt_info (conn, data, len);break ; -case BT_L2CAP_SMP_MASTER_IDENT : -master_ident (conn, data, len); +case BT_L2CAP_SMP_CENTRAL_IDENT : +central_ident (conn, data, len);break ;case BT_L2CAP_SMP_IDENT_ADDR_INFO :ident_addr_info (conn, data, len);
monitor/broadcom.c +4 -4
@@ -120,10 +120,10 @@ static void print_sync_mode(uint8_t mode)switch (mode) {case 0x00 : - str ="Slave" ; + str ="Peripheral" ;break ;case 0x01 : - str ="Master" ; + str ="Central" ;break ;default : str ="Reserved" ;
@@ -139,10 +139,10 @@ static void print_clock_mode(uint8_t mode)switch (mode) {case 0x00 : - str ="Slave" ; + str ="Peripheral" ;break ;case 0x01 : - str ="Master" ; + str ="Central" ;break ;default : str ="Reserved" ;
monitor/bt.h +75 -75
286 lines not on this page · raw message
monitor/control.c +5 -5
@@ -305,19 +305,19 @@ static void mgmt_new_long_term_key(uint16_t len, const void *buf)return ; } -/* LE SC keys are both for master and slave */ +/* LE SC keys are both for central and peripheral */ switch (ev->key.type) {case 0x00 :if (ev->key.central) - type ="Master (Unauthenticated)" ; + type ="Central (Unauthenticated)" ;else - type ="Slave (Unauthenticated)" ; + type ="Peripheral (Unauthenticated)" ;break ;case 0x01 :if (ev->key.central) - type ="Master (Authenticated)" ; + type ="Central (Authenticated)" ;else - type ="Slave (Authenticated)" ; + type ="Peripheral (Authenticated)" ;break ;case 0x02 : type ="SC (Unauthenticated)" ;
monitor/l2cap.c +5 -5
@@ -1280,7 +1280,7 @@ static void sig_conn_param_req(const struct l2cap_frame *frame)print_field ("Min interval: %d" ,le16_to_cpu (pdu->min_interval));print_field ("Max interval: %d" ,le16_to_cpu (pdu->max_interval)); -print_field ("Slave latency: %d" ,le16_to_cpu (pdu->latency)); +print_field ("Peripheral latency: %d" ,le16_to_cpu (pdu->latency));print_field ("Timeout multiplier: %d" ,le16_to_cpu (pdu->timeout)); }
@@ -2960,9 +2960,9 @@ static void smp_encrypt_info(const struct l2cap_frame *frame)print_hex_field ("Long term key" , pdu->ltk,16 ); } -static void smp_master_ident (const struct l2cap_frame *frame) +static void smp_central_ident (const struct l2cap_frame *frame) { -const struct bt_l2cap_smp_master_ident *pdu = frame->data; +const struct bt_l2cap_smp_central_ident *pdu = frame->data;print_field ("EDIV: 0x%4.4x" ,le16_to_cpu (pdu->ediv));print_field ("Rand: 0x%16.16" PRIx64,le64_to_cpu (pdu->rand));
@@ -3065,8 +3065,8 @@ static const struct smp_opcode_data smp_opcode_table[] = { smp_pairing_failed, 1, true }, {0x06 ,"Encryption Information" , smp_encrypt_info, 16, true }, - { 0x07, "Master Identification", - smp_master_ident, 10, true }, + { 0x07, "Central Identification", + smp_central_ident, 10, true }, { 0x08, "Identity Information", smp_ident_info, 16, true }, { 0x09, "Identity Address Information",
monitor/ll.c +32 -28
133 lines not on this page · raw message
monitor/lmp.c +1 -1
@@ -839,7 +839,7 @@ void lmp_packet(const void *data, uint8_t size, bool padded) tid = ((const uint8_t *) data)[0 ] &0x01 ; opcode = (((const uint8_t *) data)[0 ] &0xfe ) >>1 ; - tid_str = tid ==0x00 ?"Master" :"Slave" ; + tid_str = tid ==0x00 ?"Central" :"Peripheral" ;switch (opcode) {case 127 :
monitor/packet.c +208 -203
743 lines not on this page · raw message
tools/3dsp.c +17 -16
@@ -122,7 +122,7 @@ static void sync_train_received(const void *data, uint8_t size, void *user_data) {const struct bt_hci_evt_sync_train_received *evt = data; -struct bt_hci_cmd_set_slave_broadcast_receive cmd; +struct bt_hci_cmd_set_peripheral_broadcast_receive cmd;if (evt->status) {printf ("Failed to synchronize with 3D display\n" );
@@ -147,7 +147,7 @@ static void sync_train_received(const void *data, uint8_t size, cmd.pkt_type =cpu_to_le16 (PKT_TYPE );memcpy (cmd.map, evt->map,10 ); -bt_hci_send (hci_dev,BT_HCI_CMD_SET_SLAVE_BROADCAST_RECEIVE , +bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST_RECEIVE , &cmd,sizeof (cmd), set_slave_broadcast_receive,NULL ,NULL ); }
@@ -156,7 +156,7 @@ static void brcm_sync_train_received(const void *data, uint8_t size, void *user_data) {const struct brcm_evt_sync_train_received *evt = data; -struct bt_hci_cmd_set_slave_broadcast_receive cmd; +struct bt_hci_cmd_set_peripheral_broadcast_receive cmd;if (evt->status) {printf ("Failed to synchronize with 3D display\n" );
@@ -181,7 +181,7 @@ static void brcm_sync_train_received(const void *data, uint8_t size, cmd.pkt_type =cpu_to_le16 (PKT_TYPE );memcpy (cmd.map, evt->map,10 ); -bt_hci_send (hci_dev,BT_HCI_CMD_SET_SLAVE_BROADCAST_RECEIVE , +bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST_RECEIVE , &cmd,sizeof (cmd), set_slave_broadcast_receive,NULL ,NULL ); }
@@ -212,7 +212,7 @@ static void truncated_page_complete(const void *data, uint8_t size,static void slave_broadcast_timeout (const void *data,uint8_t size,void *user_data) { -const struct bt_hci_evt_slave_broadcast_timeout *evt = data; +const struct bt_hci_evt_peripheral_broadcast_timeout *evt = data;struct bt_hci_cmd_receive_sync_train cmd;printf ("Re-synchronizing with 3D display\n" );
@@ -229,7 +229,7 @@ static void slave_broadcast_timeout(const void *data, uint8_t size,static void slave_broadcast_receive (const void *data,uint8_t size,void *user_data) { -const struct bt_hci_evt_slave_broadcast_receive *evt = data; +const struct bt_hci_evt_peripheral_broadcast_receive *evt = data;struct bt_hci_cmd_read_clock cmd;if (evt->status !=0x00 )
@@ -326,9 +326,9 @@ static void start_glasses(void)bt_hci_register (hci_dev,BT_HCI_EVT_TRUNCATED_PAGE_COMPLETE , truncated_page_complete,NULL ,NULL ); -bt_hci_register (hci_dev,BT_HCI_EVT_SLAVE_BROADCAST_TIMEOUT , +bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_BROADCAST_TIMEOUT , slave_broadcast_timeout,NULL ,NULL ); -bt_hci_register (hci_dev,BT_HCI_EVT_SLAVE_BROADCAST_RECEIVE , +bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_BROADCAST_RECEIVE , slave_broadcast_receive,NULL ,NULL );start_inquiry ();
@@ -443,13 +443,13 @@ static void read_clock(const void *data, uint8_t size, void *user_data) msg.frame_sync_period_fraction =0 ;memcpy (bcastdata +3 , &msg,sizeof (msg)); -bt_hci_send (hci_dev,BT_HCI_CMD_SET_SLAVE_BROADCAST_DATA , +bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST_DATA , bcastdata,sizeof (bcastdata),NULL ,NULL ,NULL ); }static void set_slave_broadcast (const void *data,uint8_t size,void *user_data) { -const struct bt_hci_rsp_set_slave_broadcast *rsp = data; +const struct bt_hci_rsp_set_peripheral_broadcast *rsp = data;struct bt_hci_cmd_read_clock cmd;if (rsp->status) {
@@ -467,7 +467,7 @@ static void set_slave_broadcast(const void *data, uint8_t size, void *user_data)static void start_display (void ) { -struct bt_hci_cmd_set_slave_broadcast cmd; +struct bt_hci_cmd_set_peripheral_broadcast cmd;uint8_t evtmask1[] = {0x1c ,0xe0 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 };uint8_t evtmask2[] = {0x00 ,0xc0 ,0x74 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 };uint8_t sspmode =0x01 ;
@@ -492,10 +492,11 @@ static void start_display(void)bt_hci_register (hci_dev,BT_HCI_EVT_CONN_REQUEST , conn_request,NULL ,NULL ); -bt_hci_register (hci_dev,BT_HCI_EVT_SLAVE_PAGE_RESPONSE_TIMEOUT , +bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_PAGE_RESPONSE_TIMEOUT , slave_page_response_timeout,NULL ,NULL ); -bt_hci_register (hci_dev,BT_HCI_EVT_SLAVE_BROADCAST_CHANNEL_MAP_CHANGE , - slave_broadcast_channel_map_change,NULL ,NULL ); +bt_hci_register (hci_dev, +BT_HCI_EVT_PERIPHERAL_BROADCAST_CHANNEL_MAP_CHANGE , + slave_broadcast_channel_map_change,NULL ,NULL );bt_hci_register (hci_dev,BT_HCI_EVT_SYNC_TRAIN_COMPLETE , sync_train_complete,NULL ,NULL );
@@ -510,8 +511,8 @@ static void start_display(void) cmd.max_interval =cpu_to_le16 (0x00a0 );/* 100 ms */ cmd.timeout =cpu_to_le16 (0xfffe ); -bt_hci_send (hci_dev,BT_HCI_CMD_SET_SLAVE_BROADCAST , &cmd,sizeof (cmd), - set_slave_broadcast,NULL ,NULL ); +bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST , &cmd, +sizeof (cmd), set_slave_broadcast,NULL ,NULL ); }static void signal_callback (int signum,void *user_data)
tools/hci-tester.c +2 -2
@@ -337,12 +337,12 @@ static void test_read_local_supported_codecs(const void *test_data)static void test_le_read_white_list_size (const void *test_data) { -test_command (BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE ); +test_command (BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE ); }static void test_le_clear_white_list (const void *test_data) { -test_command (BT_HCI_CMD_LE_CLEAR_WHITE_LIST ); +test_command (BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST ); } static void test_le_encrypt_complete(const void *data, uint8_t size,
tools/mgmt-tester.c +2 -2
@@ -4248,7 +4248,7 @@ static const struct generic_data add_device_success_6 = { .expect_alt_ev = MGMT_EV_DEVICE_ADDED, .expect_alt_ev_param = add_device_success_param_6, .expect_alt_ev_len = sizeof(add_device_success_param_6), - .expect_hci_command = BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, + .expect_hci_command = BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, .expect_hci_param = le_add_to_white_list_param, .expect_hci_len = sizeof(le_add_to_white_list_param), };
@@ -4418,7 +4418,7 @@ static const struct generic_data remove_device_success_7 = { .expect_param = remove_device_param_2, .expect_len = sizeof(remove_device_param_2), .expect_status = MGMT_STATUS_SUCCESS, - .expect_hci_command = BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, + .expect_hci_command = BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, .expect_hci_param = le_add_to_white_list_param, .expect_hci_len = sizeof(le_add_to_white_list_param), .expect_alt_ev = MGMT_EV_DEVICE_REMOVED,
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 4/12 emulator: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", and "accept list".
---
Changes in v4:
* Fix line over 80 columns
Changes in v2:
* Merging several patches from the same directory into one
android/tester-main.c | 2 +- emulator/btdev.c | 154 +++++++++++++++++++++--------------------- emulator/hciemu.c | 21 +++--- emulator/hciemu.h | 12 ++-- emulator/le.c | 84 +++++++++++------------ emulator/serial.c | 6 +- tools/l2cap-tester.c | 16 ++--- tools/mgmt-tester.c | 20 +++--- tools/rfcomm-tester.c | 4 +- tools/sco-tester.c | 2 +- tools/smp-tester.c | 6 +- 11 files changed, 164 insertions(+), 163 deletions(-)
android/tester-main.c +1 -1
@@ -2786,7 +2786,7 @@ void emu_remote_connect_hci_action(void) struct step *step = g_new0(struct step, 1);const uint8_t *master_addr; - master_addr =hciemu_get_master_bdaddr (data->hciemu); + master_addr =hciemu_get_central_bdaddr (data->hciemu);tester_print ("Trying to connect hci" );
emulator/btdev.c +77 -77
352 lines not on this page · raw message
emulator/hciemu.c +11 -10
@@ -84,7 +84,7 @@ static void run_command_hook(void *data, void *user_data) run_data->len, hook->user_data); } -static void master_command_callback (uint16_t opcode, +static void central_command_callback (uint16_t opcode,const void *data,uint8_t len,btdev_callback callback,void *user_data) {
@@ -230,7 +230,7 @@ static bool create_vhci(struct hciemu *hciemu)if (!btdev)return false; -btdev_set_command_handler (btdev, master_command_callback, hciemu); +btdev_set_command_handler (btdev, central_command_callback, hciemu); fd =open ("/dev/vhci" ,O_RDWR |O_NONBLOCK |O_CLOEXEC );if (fd <0 ) {
@@ -462,7 +462,7 @@ static void bthost_print(const char *str, void *user_data) "bthost: %s", str); } -static void btdev_master_debug (const char *str,void *user_data) +static void btdev_central_debug (const char *str,void *user_data) {struct hciemu *hciemu = user_data;
@@ -500,7 +500,7 @@ bool hciemu_set_debug(struct hciemu *hciemu, hciemu_debug_func_t callback, hciemu->debug_destroy = destroy; hciemu->debug_data = user_data; -btdev_set_debug (hciemu->dev, btdev_master_debug, hciemu,NULL ); +btdev_set_debug (hciemu->dev, btdev_central_debug, hciemu,NULL );queue_foreach (hciemu->clients, hciemu_client_set_debug, hciemu);
@@ -528,7 +528,7 @@ uint8_t *hciemu_get_features(struct hciemu *hciemu)return btdev_get_features (hciemu->dev); } -const uint8_t *hciemu_get_master_bdaddr (struct hciemu *hciemu) +const uint8_t *hciemu_get_central_bdaddr (struct hciemu *hciemu) {if (!hciemu || !hciemu->dev)return NULL ;
@@ -556,7 +556,7 @@ const uint8_t *hciemu_get_client_bdaddr(struct hciemu *hciemu)return hciemu_client_bdaddr (client); } -uint8_t hciemu_get_master_scan_enable (struct hciemu *hciemu) +uint8_t hciemu_get_central_scan_enable (struct hciemu *hciemu) {if (!hciemu || !hciemu->dev)return 0 ;
@@ -564,7 +564,7 @@ uint8_t hciemu_get_master_scan_enable(struct hciemu *hciemu)return btdev_get_scan_enable (hciemu->dev); } -uint8_t hciemu_get_master_le_scan_enable (struct hciemu *hciemu) +uint8_t hciemu_get_central_le_scan_enable (struct hciemu *hciemu) {if (!hciemu || !hciemu->dev)return 0 ;
@@ -572,7 +572,8 @@ uint8_t hciemu_get_master_le_scan_enable(struct hciemu *hciemu)return btdev_get_le_scan_enable (hciemu->dev); } -void hciemu_set_master_le_states (struct hciemu *hciemu,const uint8_t *le_states) +void hciemu_set_central_le_states (struct hciemu *hciemu, +const uint8_t *le_states) {if (!hciemu || !hciemu->dev)return ;
@@ -580,7 +581,7 @@ void hciemu_set_master_le_states(struct hciemu *hciemu, const uint8_t *le_statesbtdev_set_le_states (hciemu->dev, le_states); } -bool hciemu_add_master_post_command_hook (struct hciemu *hciemu, +bool hciemu_add_central_post_command_hook (struct hciemu *hciemu,hciemu_command_func_t function,void *user_data) {struct hciemu_command_hook *hook;
@@ -603,7 +604,7 @@ bool hciemu_add_master_post_command_hook(struct hciemu *hciemu,return true; } -bool hciemu_clear_master_post_command_hooks (struct hciemu *hciemu) +bool hciemu_clear_central_post_command_hooks (struct hciemu *hciemu) {if (!hciemu)return false;
emulator/hciemu.h +6 -6
@@ -50,14 +50,14 @@ struct bthost *hciemu_client_get_host(struct hciemu *hciemu);const char *hciemu_get_address (struct hciemu *hciemu);uint8_t *hciemu_get_features (struct hciemu *hciemu); -const uint8_t *hciemu_get_master_bdaddr (struct hciemu *hciemu); +const uint8_t *hciemu_get_central_bdaddr (struct hciemu *hciemu);const uint8_t *hciemu_get_client_bdaddr (struct hciemu *hciemu); -uint8_t hciemu_get_master_scan_enable (struct hciemu *hciemu); +uint8_t hciemu_get_central_scan_enable (struct hciemu *hciemu); -uint8_t hciemu_get_master_le_scan_enable (struct hciemu *hciemu); +uint8_t hciemu_get_central_le_scan_enable (struct hciemu *hciemu); -void hciemu_set_master_le_states (struct hciemu *hciemu, +void hciemu_set_central_le_states (struct hciemu *hciemu,const uint8_t *le_states); typedef void (*hciemu_command_func_t)(uint16_t opcode, const void *data,
@@ -66,10 +66,10 @@ typedef void (*hciemu_command_func_t)(uint16_t opcode, const void *data,typedef bool (*hciemu_hook_func_t )(const void *data,uint16_t len,void *user_data); -bool hciemu_add_master_post_command_hook (struct hciemu *hciemu, +bool hciemu_add_central_post_command_hook (struct hciemu *hciemu,hciemu_command_func_t function,void *user_data); -bool hciemu_clear_master_post_command_hooks (struct hciemu *hciemu); +bool hciemu_clear_central_post_command_hooks (struct hciemu *hciemu); int hciemu_add_hook(struct hciemu *hciemu, enum hciemu_hook_type type, uint16_t opcode, hciemu_hook_func_t function,
emulator/le.c +42 -42
213 lines not on this page · raw message
emulator/serial.c +3 -3
@@ -151,19 +151,19 @@ static void open_pty(struct serial *serial) serial->fd =posix_openpt (O_RDWR |O_NOCTTY );if (serial->fd <0 ) { -perror ("Failed to get master pseudo terminal" ); +perror ("Failed to get central pseudo terminal" );return ; }if (grantpt (serial->fd) <0 ) { -perror ("Failed to grant slave pseudo terminal" ); +perror ("Failed to grant peripheral pseudo terminal" );close (serial->fd); serial->fd =-1 ;return ; }if (unlockpt (serial->fd) <0 ) { -perror ("Failed to unlock slave pseudo terminal" ); +perror ("Failed to unlock peripheral pseudo terminal" );close (serial->fd); serial->fd =-1 ;return ;
tools/l2cap-tester.c +8 -8
@@ -1116,7 +1116,7 @@ static int create_l2cap_sock(struct test_data *data, uint16_t psm,return err; } - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );close (sk);
@@ -1301,7 +1301,7 @@ static void test_connect(const void *test_data) }if (l2data->direct_advertising) -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, direct_adv_cmd_complete,NULL ); sk = create_l2cap_sock(data, 0, l2data->cid, l2data->sec_level,
@@ -1419,7 +1419,7 @@ static gboolean test_close_socket_1_part_3(gpointer arg)return FALSE; } -if (hciemu_get_master_le_scan_enable (data->hciemu)) { +if (hciemu_get_central_le_scan_enable (data->hciemu)) {tester_print ("Delayed check whether scann is off failed" );tester_test_failed ();return FALSE;
@@ -1440,7 +1440,7 @@ static gboolean test_close_socket_1_part_2(gpointer args)* was added to kernel whitelist, and scan was started. We * should be still scanning. */ -if (!hciemu_get_master_le_scan_enable (data->hciemu)) { +if (!hciemu_get_central_le_scan_enable (data->hciemu)) {tester_print ("Error - should be still scanning" );tester_test_failed ();return FALSE;
@@ -1467,7 +1467,7 @@ static gboolean test_close_socket_2_part_3(gpointer arg)int err;/* Scan should be already over, we're trying to create connection */ -if (hciemu_get_master_le_scan_enable (data->hciemu)) { +if (hciemu_get_central_le_scan_enable (data->hciemu)) {tester_print ("Error - should no longer scan" );tester_test_failed ();return FALSE;
@@ -1563,7 +1563,7 @@ static void test_close_socket(const void *test_data)const struct l2cap_data *l2data = data->test_data;const uint8_t *client_bdaddr; -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, test_close_socket_router, data);if (l2data->client_bdaddr !=NULL )
@@ -1668,7 +1668,7 @@ static void test_connect_2(const void *test_data) test_2_connect_cb_cnt =0 ; test_scan_enable_counter =0 ; -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, test_connect_2_router, data);if (l2data->server_psm) {
@@ -1869,7 +1869,7 @@ static void test_server(const void *test_data)tester_print ("Listening for connections" ); } - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );tester_test_failed ();
tools/mgmt-tester.c +10 -10
@@ -365,7 +365,7 @@ static void read_index_list_callback(uint8_t status, uint16_t length,hciemu_set_debug (data->hciemu, print_debug,"hciemu: " ,NULL );if (test && test->setup_le_states) -hciemu_set_master_le_states (data->hciemu, test->le_states); +hciemu_set_central_le_states (data->hciemu, test->le_states); }static void test_pre_setup (const void *test_data)
@@ -7136,7 +7136,7 @@ static void command_setup_hci_callback(uint16_t opcode, const void *param,return ; } -hciemu_clear_master_post_command_hooks (data->hciemu); +hciemu_clear_central_post_command_hooks (data->hciemu);test_setup_condition_complete (data); }
@@ -7202,7 +7202,7 @@ static void setup_command_generic(const void *test_data)tester_print ("Registering setup expected HCI command callback" );tester_print ("Setup expected HCI command 0x%04x" , test->setup_expect_hci_command); -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, command_setup_hci_callback, data);test_add_setup_condition (data); }
@@ -9529,7 +9529,7 @@ static void setup_ll_privacy_device(const void *test_data)tester_print ("Setup expected HCI command 0x%04x" , test->setup_expect_hci_command); -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, command_setup_hci_callback, data);test_add_setup_condition (data);
@@ -9686,7 +9686,7 @@ static void test_command_generic(const void *test_data)if (test->expect_hci_command) {tester_print ("Registering HCI command callback" ); -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, command_hci_callback, data);test_add_condition (data); }
@@ -9720,13 +9720,13 @@ static void check_scan(void *user_data) {struct test_data *data =tester_get_data (); -if (hciemu_get_master_le_scan_enable (data->hciemu)) { +if (hciemu_get_central_le_scan_enable (data->hciemu)) {tester_warn ("LE scan still enabled" );tester_test_failed ();return ; } -if (hciemu_get_master_scan_enable (data->hciemu)) { +if (hciemu_get_central_scan_enable (data->hciemu)) {tester_warn ("BR/EDR scan still enabled" );tester_test_failed ();return ;
@@ -9817,7 +9817,7 @@ static void test_pairing_acceptor(const void *test_data)test_add_condition (data); } - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );tester_test_failed ();
@@ -9882,7 +9882,7 @@ static void test_command_generic_connect(const void *test_data) data->mgmt_alt_ev_id = id;test_add_condition (data); - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );tester_test_failed ();
@@ -9961,7 +9961,7 @@ static void add_device_callback(uint8_t status, uint16_t len, const void *param,if (test->client_enable_adv)return ; - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );tester_test_failed ();
tools/rfcomm-tester.c +2 -2
@@ -542,7 +542,7 @@ static void test_connect(const void *test_data)bthost_add_rfcomm_server (bthost, cli->server_channel, rfcomm_connect_cb,NULL ); - master_addr =hciemu_get_master_bdaddr (data->hciemu); + master_addr =hciemu_get_central_bdaddr (data->hciemu); client_addr =hciemu_get_client_bdaddr (data->hciemu); sk =create_rfcomm_sock ((bdaddr_t *) master_addr,0 );
@@ -680,7 +680,7 @@ static void test_server(const void *test_data)GIOChannel *io;int sk; - master_addr =hciemu_get_master_bdaddr (data->hciemu); + master_addr =hciemu_get_central_bdaddr (data->hciemu); sk =create_rfcomm_sock ((bdaddr_t *) master_addr, srv->server_channel);if (sk <0 ) {
tools/sco-tester.c +1 -1
@@ -426,7 +426,7 @@ static int create_sco_sock(struct test_data *data)return err; } - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );return -ENODEV ;
tools/smp-tester.c +3 -3
@@ -767,7 +767,7 @@ static void init_bdaddr(struct test_data *data) {const uint8_t *master_bdaddr, *client_bdaddr; - master_bdaddr =hciemu_get_master_bdaddr (data->hciemu); + master_bdaddr =hciemu_get_central_bdaddr (data->hciemu);if (!master_bdaddr) {tester_warn ("No master bdaddr" );tester_test_failed ();
@@ -808,7 +808,7 @@ static void test_client(const void *test_data)if (smp->expect_hci_command) {tester_print ("Registering HCI command callback" ); -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, command_hci_callback, data);test_add_condition (data); }
@@ -889,7 +889,7 @@ static void test_server(const void *test_data)if (smp->expect_hci_command) {tester_print ("Registering HCI command callback" ); -hciemu_add_master_post_command_hook (data->hciemu, +hciemu_add_central_post_command_hook (data->hciemu, command_hci_callback, data);test_add_condition (data); }
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 5/12 tools: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", "accept list", "reject list", and "temporary link key". Note that some suggestions come from
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
---
Changes in v4:
* Aggresively fix line over 80 columns
Changes in v2:
* Merging several patches from the same directory into one
tools/3dsp.c | 33 +++++---- tools/bdaddr.rst | 2 +- tools/btiotest.c | 22 +++--- tools/btpclientctl.c | 2 +- tools/hci-tester.c | 12 +-- tools/hciconfig.c | 148 ++++++++++++++++++++++++------------- tools/hciconfig.rst | 24 +++--- tools/hcitool.c | 102 ++++++++++++------------- tools/hcitool.rst | 30 ++++---- tools/l2cap-tester.c | 24 +++--- tools/l2test.c | 18 ++--- tools/mesh-cfgclient.c | 4 +- tools/mesh-gatt/mesh-net.h | 4 +- tools/mesh-gatt/net.c | 60 +++++++-------- tools/mesh/mesh-db.c | 28 ++++--- tools/mesh/mesh-db.h | 4 +- tools/mesh/remote.c | 53 +++++++------ tools/mesh/remote.h | 5 +- tools/meshctl.c | 6 +- tools/mgmt-tester.c | 120 +++++++++++++++--------------- tools/oobtest.c | 8 +- tools/parser/avdtp.c | 11 ++- tools/parser/csr.c | 17 +++-- tools/parser/ericsson.c | 2 +- tools/parser/hci.c | 38 +++++----- tools/parser/lmp.c | 112 ++++++++++++++-------------- tools/parser/parser.h | 2 +- tools/parser/smp.c | 12 +-- tools/rctest.c | 19 ++--- tools/rctest.rst | 4 +- tools/rfcomm-tester.c | 14 ++-- tools/rfcomm.c | 15 ++-- tools/rfcomm.rst | 2 +- tools/sco-tester.c | 10 +-- tools/smp-tester.c | 12 +-- 35 files changed, 514 insertions(+), 465 deletions(-)
tools/3dsp.c +17 -16
@@ -112,10 +112,10 @@ static void start_inquiry(void) inquiry_started, NULL, NULL); } -static void set_slave_broadcast_receive (const void *data,uint8_t size, +static void set_peripheral_broadcast_receive (const void *data,uint8_t size,void *user_data) { -printf ("Slave broadcast receiption enabled\n" ); +printf ("Peripheral broadcast reception enabled\n" ); } static void sync_train_received(const void *data, uint8_t size,
@@ -149,7 +149,7 @@ static void sync_train_received(const void *data, uint8_t size,bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST_RECEIVE , &cmd,sizeof (cmd), - set_slave_broadcast_receive,NULL ,NULL ); + set_peripheral_broadcast_receive,NULL ,NULL ); } static void brcm_sync_train_received(const void *data, uint8_t size,
@@ -183,7 +183,7 @@ static void brcm_sync_train_received(const void *data, uint8_t size,bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST_RECEIVE , &cmd,sizeof (cmd), - set_slave_broadcast_receive,NULL ,NULL ); + set_peripheral_broadcast_receive,NULL ,NULL ); } static void truncated_page_complete(const void *data, uint8_t size,
@@ -209,7 +209,7 @@ static void truncated_page_complete(const void *data, uint8_t size, NULL, NULL, NULL); } -static void slave_broadcast_timeout (const void *data,uint8_t size, +static void peripheral_broadcast_timeout (const void *data,uint8_t size,void *user_data) {const struct bt_hci_evt_peripheral_broadcast_timeout *evt = data;
@@ -226,7 +226,7 @@ static void slave_broadcast_timeout(const void *data, uint8_t size, NULL, NULL, NULL); } -static void slave_broadcast_receive (const void *data,uint8_t size, +static void peripheral_broadcast_receive (const void *data,uint8_t size,void *user_data) {const struct bt_hci_evt_peripheral_broadcast_receive *evt = data;
@@ -327,9 +327,9 @@ static void start_glasses(void)bt_hci_register (hci_dev,BT_HCI_EVT_TRUNCATED_PAGE_COMPLETE , truncated_page_complete,NULL ,NULL );bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_BROADCAST_TIMEOUT , - slave_broadcast_timeout,NULL ,NULL ); + peripheral_broadcast_timeout,NULL ,NULL );bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_BROADCAST_RECEIVE , - slave_broadcast_receive,NULL ,NULL ); + peripheral_broadcast_receive,NULL ,NULL );start_inquiry (); }
@@ -381,7 +381,7 @@ static void conn_request(const void *data, uint8_t size, void *user_data)start_sync_train (); } -static void slave_page_response_timeout (const void *data,uint8_t size, +static void peripheral_page_response_timeout (const void *data,uint8_t size,void *user_data) {printf ("Incoming truncated page received\n" );
@@ -389,8 +389,8 @@ static void slave_page_response_timeout(const void *data, uint8_t size,start_sync_train (); } -static void slave_broadcast_channel_map_change (const void *data,uint8_t size, -void *user_data) +static void peripheral_broadcast_channel_map_change (const void *data, +uint8_t size,void *user_data) {printf ("Broadcast channel map changed\n" );
@@ -447,13 +447,14 @@ static void read_clock(const void *data, uint8_t size, void *user_data) bcastdata, sizeof(bcastdata), NULL, NULL, NULL); } -static void set_slave_broadcast (const void *data,uint8_t size,void *user_data) +static void set_peripheral_broadcast (const void *data,uint8_t size, +void *user_data) {const struct bt_hci_rsp_set_peripheral_broadcast *rsp = data;struct bt_hci_cmd_read_clock cmd;if (rsp->status) { -printf ("Failed to set slave broadcast transmission\n" ); +printf ("Failed to set peripheral broadcast transmission\n" );shutdown_device ();return ; }
@@ -493,10 +494,10 @@ static void start_display(void) conn_request, NULL, NULL);bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_PAGE_RESPONSE_TIMEOUT , - slave_page_response_timeout,NULL ,NULL ); + peripheral_page_response_timeout,NULL ,NULL );bt_hci_register (hci_dev,BT_HCI_EVT_PERIPHERAL_BROADCAST_CHANNEL_MAP_CHANGE , - slave_broadcast_channel_map_change,NULL ,NULL ); + peripheral_broadcast_channel_map_change,NULL ,NULL );bt_hci_register (hci_dev,BT_HCI_EVT_SYNC_TRAIN_COMPLETE , sync_train_complete,NULL ,NULL );
@@ -512,7 +513,7 @@ static void start_display(void) cmd.timeout =cpu_to_le16 (0xfffe );bt_hci_send (hci_dev,BT_HCI_CMD_SET_PERIPHERAL_BROADCAST , &cmd, -sizeof (cmd), set_slave_broadcast,NULL ,NULL ); +sizeof (cmd), set_peripheral_broadcast,NULL ,NULL ); }static void signal_callback (int signum,void *user_data)
tools/bdaddr.rst +1 -1
@@ -61,7 +61,7 @@ FILES ===== /usr/share/misc/oui.txt - IEEE Organizationally Unique Identifier master file. + IEEE Organizationally Unique Identifier consolidated file. Manually update from: http://standards.ieee.org/regauth/oui/oui.txt
tools/btiotest.c +11 -11
@@ -310,7 +310,7 @@ static void l2cap_connect(const char *src, const char *dst, uint8_t addr_type,static void l2cap_listen (const char *src,uint8_t addr_type,uint16_t psm,uint16_t cid,int defer,int reject,int disconn,int accept,int sec, -gboolean master) +gboolean central) {struct io_data *data;BtIOConnect conn;
@@ -343,7 +343,7 @@ static void l2cap_listen(const char *src, uint8_t addr_type, uint16_t psm,BT_IO_OPT_PSM , psm,BT_IO_OPT_CID , cid,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_CENTRAL , master, +BT_IO_OPT_CENTRAL , central, BT_IO_OPT_INVALID); else l2_srv = bt_io_listen(conn, cfm, data,
@@ -353,7 +353,7 @@ static void l2cap_listen(const char *src, uint8_t addr_type, uint16_t psm,BT_IO_OPT_PSM , psm,BT_IO_OPT_CID , cid,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_CENTRAL , master, +BT_IO_OPT_CENTRAL , central, BT_IO_OPT_INVALID);if (!l2_srv) {
@@ -402,7 +402,7 @@ static void rfcomm_connect(const char *src, const char *dst, uint8_t ch,static void rfcomm_listen (const char *src,uint8_t ch,gboolean defer,int reject,int disconn,int accept, -int sec,gboolean master) +int sec,gboolean central) {struct io_data *data;BtIOConnect conn;
@@ -427,7 +427,7 @@ static void rfcomm_listen(const char *src, uint8_t ch, gboolean defer,BT_IO_OPT_SOURCE , src,BT_IO_OPT_CHANNEL , ch,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_CENTRAL , master, +BT_IO_OPT_CENTRAL , central, BT_IO_OPT_INVALID); else rc_srv = bt_io_listen(conn, cfm,
@@ -435,7 +435,7 @@ static void rfcomm_listen(const char *src, uint8_t ch, gboolean defer, &err,BT_IO_OPT_CHANNEL , ch,BT_IO_OPT_SEC_LEVEL , sec, -BT_IO_OPT_CENTRAL , master, +BT_IO_OPT_CENTRAL , central, BT_IO_OPT_INVALID);if (!rc_srv) {
@@ -540,7 +540,7 @@ static int opt_reject = -1;static int opt_disconn =-1 ;static int opt_accept =DEFAULT_ACCEPT_TIMEOUT ;static int opt_sec =0 ; -static gboolean opt_master = FALSE; +static gboolean opt_central = FALSE;static int opt_priority =0 ;static int opt_cid =0 ;static guint8 opt_addr_type =0 ;
@@ -576,8 +576,8 @@ static GOptionEntry options[] = { "Disconnect connection after N seconds" }, {"accept" ,'a' ,0 ,G_OPTION_ARG_INT , &opt_accept, "Accept connection after N seconds" }, - { "master", 'm', 0, G_OPTION_ARG_NONE, &opt_master, - "Master role switch (incoming connections)" }, + { "central", 'C', 0, G_OPTION_ARG_NONE, &opt_central, + "Central role switch (incoming connections)" }, { "priority", 'P', 0, G_OPTION_ARG_INT, &opt_priority,"Transmission priority: Setting a priority " "outside the range 0 to 6 requires the"
@@ -614,7 +614,7 @@ int main(int argc, char *argv[])else l2cap_listen (opt_dev, opt_addr_type, opt_psm, opt_cid, opt_defer, opt_reject, opt_disconn, - opt_accept, opt_sec, opt_master); + opt_accept, opt_sec, opt_central); }if (opt_channel !=-1 ) {
@@ -624,7 +624,7 @@ int main(int argc, char *argv[])else rfcomm_listen (opt_dev, opt_channel, opt_defer, opt_reject, opt_disconn, opt_accept, - opt_sec, opt_master); + opt_sec, opt_central); }if (opt_sco) {
tools/btpclientctl.c +1 -1
@@ -676,7 +676,7 @@ const struct indexstr_data ad_type_table[] = { { 0x10, "BT_AD_DEVICE_ID" }, { 0x10, "BT_AD_SMP_TK" }, { 0x11, "BT_AD_SMP_OOB_FLAGS" }, - { 0x12, "BT_AD_SLAVE_CONN_INTERVAL" }, + { 0x12, "BT_AD_PERIPHERAL_CONN_INTERVAL" }, { 0x14, "BT_AD_SOLICIT16" }, { 0x15, "BT_AD_SOLICIT128" }, { 0x16, "BT_AD_SERVICE_DATA16" },
tools/hci-tester.c +6 -6
@@ -335,12 +335,12 @@ static void test_read_local_supported_codecs(const void *test_data)test_command (BT_HCI_CMD_READ_LOCAL_CODECS ); } -static void test_le_read_white_list_size (const void *test_data) +static void test_le_read_accept_list_size (const void *test_data) {test_command (BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE ); } -static void test_le_clear_white_list (const void *test_data) +static void test_le_clear_accept_list (const void *test_data) {test_command (BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST ); }
@@ -944,10 +944,10 @@ int main(int argc, char *argv[])test_hci_local ("Read Local Supported Codecs" ,NULL ,NULL , test_read_local_supported_codecs); -test_hci_local ("LE Read White List Size" ,NULL ,NULL , - test_le_read_white_list_size); -test_hci_local ("LE Clear White List" ,NULL ,NULL , - test_le_clear_white_list); +test_hci_local ("LE Read Accept List Size" ,NULL ,NULL , + test_le_read_accept_list_size); +test_hci_local ("LE Clear Accept List" ,NULL ,NULL , + test_le_clear_accept_list);test_hci_local ("LE Encrypt" ,NULL ,NULL , test_le_encrypt); test_hci_local("LE Rand", NULL, NULL,
tools/hciconfig.c +95 -53
170 lines not on this page · raw message
tools/hciconfig.rst +12 -12
@@ -216,24 +216,24 @@ revision Display revision information. lm [*mode*] - With no *mode*, prints link mode. **MASTER** or **SLAVE** mean, - respectively, to ask to become master or to remain slave when a connection - request comes in. The additional keyword **ACCEPT** means that baseband - connections will be accepted even if there are no listening *AF_BLUETOOTH* - sockets. *mode* is **NONE** or a comma-separated list of keywords, where - possible keywords are **MASTER** and **ACCEPT**. **NONE** sets link policy - to the default behaviour of remaining slave and not accepting baseband - connections when there are no listening *AF_BLUETOOTH* sockets. If - **MASTER** is present, the device will ask to become master if a - connection request comes in. If **ACCEPT** is present, the device will + With no *mode*, prints link mode. **CENTRAL** or **PERIPHERAL** mean, + respectively, to ask to become central or to remain peripheral when a + connection request comes in. The additional keyword **ACCEPT** means that + baseband connections will be accepted even if there are no listening + *AF_BLUETOOTH* sockets. *mode* is **NONE** or a comma-separated list of + keywords, where possible keywords are **CENTRAL** and **ACCEPT**. **NONE** + sets link policy to the default behaviour of remaining peripheral and not + accepting baseband connections when there are no listening *AF_BLUETOOTH* + sockets. If **CENTRAL** is present, the device will ask to become central + if a connection request comes in. If **ACCEPT** is present, the device will accept baseband connections even when there are no listening *AF_BLUETOOTH* sockets. block <*bdaddr*> - Add a device to the blacklist + Add a device to the reject list unblock <*bdaddr*> - Remove a device from the blacklist + Remove a device from the reject list lerandaddr <*bdaddr*> Set LE Random Address
tools/hcitool.c +51 -51
286 lines not on this page · raw message
tools/hcitool.rst +15 -15
@@ -74,7 +74,7 @@ cmd <*ogf*> <*ocf*> [*parameters*] con Display active baseband connections -cc [--*role*\=m|s] [--*pkt-type*\=<*ptype*>] <*bdaddr*> +cc [--*role*\=c|p] [--*pkt-type*\=<*ptype*>] <*bdaddr*> Create baseband connection to remote device with Bluetooth address *bdaddr*. Option **--pkt-type** specifies a list of allowed packet types.
@@ -82,9 +82,9 @@ cc [--*role*\=m|s] [--*pkt-type*\=<*ptype*>] <*bdaddr*> packet types are **DM1**, **DM3**, **DM5**, **DH1**, **DH3**, **DH5**, **HV1**, **HV2**, **HV3**. Default is to allow all packet types. - Option **--role** can have value **m** (do not allow role switch, stay - master) or **s** (allow role switch, become slave if the peer asks to become - master). Default is **m**. + Option **--role** can have value **c** (do not allow role switch, stay + central) or **p** (allow role switch, become peripheral if the peer asks to + become central). Default is **c**. dc <*bdaddr*> [*reason*] Delete baseband connection from remote device with Bluetooth address
@@ -96,7 +96,7 @@ dc <*bdaddr*> [*reason*] sr <*bdaddr*> <*role*> Switch role for the baseband connection from the remote device to - **master** or **slave**. + **central** or **peripheral**. cpt <*bdaddr*> <*ptypes*> Change packet types for baseband connection to device with Bluetooth
@@ -157,23 +157,23 @@ clock [*bdaddr*] [*clock*] The *clock* can be **0** for the local clock or **1** for the piconet clock (which is default). -lescan [--*privacy*] [--*passive*] [--*whitelist*] [--*discovery*\=g|l] [--*duplicates*] +lescan [--*privacy*] [--*passive*] [--*acceptlist*] [--*discovery*\=g|l] [--*duplicates*] Start LE scan leinfo [--*static*] [--*random*] <*bdaddr*> Get LE remote information -lewladd [--*random*] <*bdaddr*> - Add device to LE White List +lealall [--*random*] <*bdaddr*> + Add device to LE Accept List -lewlrm <*bdaddr*> - Remove device from LE White List +lealrm <*bdaddr*> + Remove device from LE Accept List -lewlsz - Read size of LE White List +lealsz + Read size of LE Accept List -lewlclr - Clear LE White List +lealclr + Clear LE Accept List lerladd [--*local_irk*] [--*peer_irk*] [--*random*] <*bdaddr*> Add device to LE Resolving List
@@ -193,7 +193,7 @@ lerlon lerloff Disable LE Address Resolution -lecc [--*static*] [--*random*] <*bdaddr*> | [--*whitelist*] +lecc [--*static*] [--*random*] <*bdaddr*> | [--*acceptlist*] Create a LE Connection ledc <*handle*> [*reason*]
tools/l2cap-tester.c +12 -12
@@ -1103,7 +1103,7 @@ static int create_l2cap_sock(struct test_data *data, uint16_t psm, uint16_t cid, int sec_level, uint8_t mode) { const struct l2cap_data *l2data = data->test_data; -const uint8_t *master_bdaddr; +const uint8_t *central_bdaddr;struct sockaddr_l2 addr;int sk, err;
@@ -1116,9 +1116,9 @@ static int create_l2cap_sock(struct test_data *data, uint16_t psm,return err; } - master_bdaddr =hciemu_get_central_bdaddr (data->hciemu); -if (!master_bdaddr) { -tester_warn ("No master bdaddr" ); + central_bdaddr =hciemu_get_central_bdaddr (data->hciemu); +if (!central_bdaddr) { +tester_warn ("No central bdaddr" );close (sk);return -ENODEV ; }
@@ -1127,7 +1127,7 @@ static int create_l2cap_sock(struct test_data *data, uint16_t psm, addr.l2_family =AF_BLUETOOTH ; addr.l2_psm =htobs (psm); addr.l2_cid =htobs (cid); -bacpy (&addr.l2_bdaddr, (void *) master_bdaddr); +bacpy (&addr.l2_bdaddr, (void *) central_bdaddr);if (l2data && l2data->addr_type_avail) addr.l2_bdaddr_type = l2data->addr_type;
@@ -1437,7 +1437,7 @@ static gboolean test_close_socket_1_part_2(gpointer args)tester_print ("Will close socket during scan phase..." );/* We tried to conect to LE device that is not advertising. It -* was added to kernel whitelist, and scan was started. We +* was added to kernel accept list, and scan was started. We * should be still scanning. */ if (!hciemu_get_central_le_scan_enable (data->hciemu)) {
@@ -1446,7 +1446,7 @@ static gboolean test_close_socket_1_part_2(gpointer args)return FALSE; } -/* Calling close() should remove device from whitelist, and stop +/* Calling close() should remove device from accept list, and stop * the scan. */ if (close (sk) <0 ) {
@@ -1836,7 +1836,7 @@ static void test_server(const void *test_data) {struct test_data *data =tester_get_data ();const struct l2cap_data *l2data = data->test_data; -const uint8_t *master_bdaddr; +const uint8_t *central_bdaddr;uint8_t addr_type;struct bthost *bthost;GIOChannel *io;
@@ -1869,9 +1869,9 @@ static void test_server(const void *test_data)tester_print ("Listening for connections" ); } - master_bdaddr =hciemu_get_central_bdaddr (data->hciemu); -if (!master_bdaddr) { -tester_warn ("No master bdaddr" ); + central_bdaddr =hciemu_get_central_bdaddr (data->hciemu); +if (!central_bdaddr) { +tester_warn ("No central bdaddr" );tester_test_failed ();return ; }
@@ -1884,7 +1884,7 @@ static void test_server(const void *test_data)else addr_type =BDADDR_LE_PUBLIC ; -bthost_hci_connect (bthost, master_bdaddr, addr_type); +bthost_hci_connect (bthost, central_bdaddr, addr_type); }static void test_getpeername_not_connected (const void *test_data)
tools/l2test.c +9 -9
@@ -110,7 +110,7 @@ static int seq_start = 0;static const char *filename =NULL ;static int rfcmode =0 ; -static int master =0 ; +static int central =0 ;static int auth =0 ;static int encr =0 ;static int secure =0 ;
@@ -483,7 +483,7 @@ static int do_connect(char *svr) opt =0 ;if (reliable) opt |=L2CAP_LM_RELIABLE ; -if (master) +if (central) opt |=L2CAP_LM_MASTER ;if (auth) opt |=L2CAP_LM_AUTH ;
@@ -586,7 +586,7 @@ static void do_listen(void (*handler)(int sk)) opt =0 ;if (reliable) opt |=L2CAP_LM_RELIABLE ; -if (master) +if (central) opt |=L2CAP_LM_MASTER ;if (auth) opt |=L2CAP_LM_AUTH ;
@@ -1306,7 +1306,7 @@ static void usage(void)"\t[-W seconds] enable deferred setup\n" "\t[-B filename] use data packets from file\n" "\t[-N num] send num frames (default = infinite)\n" -"\t[-C num] send num frames before delay (default = 1)\n" +"\t[-M num] send num frames before delay (default = 1)\n" "\t[-D milliseconds] delay after sending num frames (default = 0)\n" "\t[-K milliseconds] delay before receiving (default = 0)\n" "\t[-g milliseconds] delay before disconnecting (default = 0)\n"
@@ -1323,7 +1323,7 @@ static void usage(void)"\t[-A] request authentication\n" "\t[-E] request encryption\n" "\t[-S] secure connection\n" -"\t[-M] become master\n" +"\t[-C] become central\n" "\t[-T] enable timestamps\n" "\t[-V type] address type (help for list, default = bredr)\n" "\t[-e seq] initial sequence value (default = 0)\n");
@@ -1337,7 +1337,7 @@ int main(int argc, char *argv[])bacpy (&bdaddr,BDADDR_ANY );while ((opt =getopt (argc, argv,"a:b:cde:g:i:mnpqrstuwxyz" -"AB:C:D:EF:GH:I:J:K:L:MN:O:P:Q:RSTUV:W:X:Y:Z:" )) !=EOF ) { +"AB:CD:EF:GH:I:J:K:L:M:N:O:P:Q:RSTUV:W:X:Y:Z:" )) !=EOF ) {switch (opt) {case 'r' : mode =RECV ;
@@ -1442,7 +1442,7 @@ int main(int argc, char *argv[]) num_frames =atoi (optarg);break ; -case 'C' : +case 'M' : count =atoi (optarg);break ;
@@ -1488,8 +1488,8 @@ int main(int argc, char *argv[]) reliable =1 ;break ; -case 'M' : - master =1 ; +case 'C' : + central =1 ;break ;case 'A' :
tools/mesh-cfgclient.c +2 -2
@@ -720,7 +720,7 @@ static void attach_node_reply(struct l_dbus_proxy *proxy, ivi != iv_index) { iv_index = ivi;mesh_db_set_iv_index (ivi); -remote_clear_blacklisted_addresses (ivi); +remote_clear_rejected_addresses (ivi); }return ;
@@ -1858,7 +1858,7 @@ static void property_changed(struct l_dbus_proxy *proxy, const char *name, iv_index = ivi;mesh_db_set_iv_index (ivi); -remote_clear_blacklisted_addresses (ivi); +remote_clear_rejected_addresses (ivi); } } }
tools/mesh-gatt/mesh-net.h +2 -2
@@ -97,8 +97,8 @@#define PROXY_OP_FILTER_STATUS 0x03/* Proxy Filter Defines */ -#define PROXY_FILTER_WHITELIST 0x00 -#define PROXY_FILTER_BLACKLIST 0x01 +#define PROXY_FILTER_ACCEPT_LIST 0x00 +#define PROXY_FILTER_REJECT_LIST 0x01/* Network Tranport Opcodes */ #define NET_OP_SEG_ACKNOWLEDGE 0x00
tools/mesh-gatt/net.c +30 -30
117 lines not on this page · raw message
tools/mesh/mesh-db.c +13 -15
@@ -1246,7 +1246,7 @@ bool mesh_db_set_iv_index(uint32_t ivi)return save_config (); } -static int get_blacklisted_by_iv_index (json_object *jarray,uint32_t iv_index) +static int get_rejected_by_iv_index (json_object *jarray,uint32_t iv_index) {int i, cnt;
@@ -1268,12 +1268,12 @@ static int get_blacklisted_by_iv_index(json_object *jarray, uint32_t iv_index)return -1 ; } -static bool load_blacklisted (json_object *jobj) +static bool load_rejected_addresses (json_object *jobj) {json_object *jarray;int i, cnt; -json_object_object_get_ex (jobj,"blacklistedAddresses" , &jarray); +json_object_object_get_ex (jobj,"rejectedAddresses" , &jarray);if (!jarray ||json_object_get_type (jarray) != json_type_array)return true;
@@ -1304,15 +1304,14 @@ static bool load_blacklisted(json_object *jobj)if (sscanf (str,"%04hx" , &unicast) !=1 )return false; -remote_add_blacklisted_address (unicast, iv_index, - false); +remote_add_rejected_address (unicast, iv_index, false); } }return true; } -bool mesh_db_add_blacklisted_addr (uint16_t unicast,uint32_t iv_index) +bool mesh_db_add_rejected_addr (uint16_t unicast,uint32_t iv_index) {json_object *jarray, *jobj, *jaddrs, *jstring;int idx;
@@ -1321,14 +1320,13 @@ bool mesh_db_add_blacklisted_addr(uint16_t unicast, uint32_t iv_index)if (!cfg || !cfg->jcfg)return false; -json_object_object_get_ex (cfg->jcfg,"blacklistedAddresses" , &jarray); +json_object_object_get_ex (cfg->jcfg,"rejectedAddresses" , &jarray);if (!jarray) { jarray =json_object_new_array (); -json_object_object_add (cfg->jcfg,"blacklistedAddresses" , - jarray); +json_object_object_add (cfg->jcfg,"rejectedAddresses" , jarray); } - idx =get_blacklisted_by_iv_index (jarray, iv_index); + idx =get_rejected_by_iv_index (jarray, iv_index);if (idx <0 ) { jobj =json_object_new_object ();
@@ -1362,7 +1360,7 @@ fail:return false; } -bool mesh_db_clear_blacklisted (uint32_t iv_index) +bool mesh_db_clear_rejected (uint32_t iv_index) {json_object *jarray;int idx;
@@ -1370,11 +1368,11 @@ bool mesh_db_clear_blacklisted(uint32_t iv_index)if (!cfg || !cfg->jcfg)return false; -json_object_object_get_ex (cfg->jcfg,"blacklistedAddresses" , &jarray); +json_object_object_get_ex (cfg->jcfg,"rejectedAddresses" , &jarray);if (!jarray ||json_object_get_type (jarray) != json_type_array)return false; - idx =get_blacklisted_by_iv_index (jarray, iv_index); + idx =get_rejected_by_iv_index (jarray, iv_index);if (idx <0 )return true;
@@ -1437,7 +1435,7 @@ bool mesh_db_create(const char *fname, const uint8_t token[8],if (!jarray) goto fail; -json_object_object_add (jcfg,"blacklistedAddresses" , jarray); +json_object_object_add (jcfg,"rejectedAddresses" , jarray);write_int (jcfg,"ivIndex" ,0 );
@@ -1504,7 +1502,7 @@ bool mesh_db_load(const char *fname)load_remotes (jcfg); -load_blacklisted (jcfg); +load_rejected_addresses (jcfg);return true; fail:
tools/mesh/mesh-db.h +2 -2
@@ -49,5 +49,5 @@ bool mesh_db_node_model_binding_del(uint16_t unicast, uint8_t ele, bool vendor, uint32_t mod_id, uint16_t app_idx);struct l_queue *mesh_db_load_groups (void );bool mesh_db_add_group (struct mesh_group *grp); -bool mesh_db_add_blacklisted_addr (uint16_t unicast,uint32_t iv_index); -bool mesh_db_clear_blacklisted (uint32_t iv_index); +bool mesh_db_add_rejected_addr (uint16_t unicast,uint32_t iv_index); +bool mesh_db_clear_rejected (uint32_t iv_index);
tools/mesh/remote.c +26 -27
112 lines not on this page · raw message
tools/mesh/remote.h +2 -3
@@ -13,9 +13,8 @@ bool remote_add_node(const uint8_t uuid[16], uint16_t unicast,uint8_t remote_del_node (uint16_t unicast);bool remote_set_model (uint16_t unicast,uint8_t ele_idx,uint32_t mod_id,bool vendor); -void remote_add_blacklisted_address (uint16_t addr,uint32_t iv_index, -bool save); -void remote_clear_blacklisted_addresses (uint32_t iv_index); +void remote_add_rejected_address (uint16_t addr,uint32_t iv_index,bool save); +void remote_clear_rejected_addresses (uint32_t iv_index);uint16_t remote_get_next_unicast (uint16_t low,uint16_t high,uint8_t ele_cnt);bool remote_add_net_key (uint16_t addr,uint16_t net_idx);bool remote_del_net_key (uint16_t addr,uint16_t net_idx);
tools/meshctl.c +3 -3
@@ -541,19 +541,19 @@ static void print_uuids(GDBusProxy *proxy) } } -static gboolean device_is_child (GDBusProxy *device,GDBusProxy *master) +static gboolean device_is_child (GDBusProxy *device,GDBusProxy *parent) {DBusMessageIter iter;const char *adapter, *path; -if (!master) +if (!parent)return FALSE;if (g_dbus_proxy_get_property (device,"Adapter" , &iter) == FALSE)return FALSE;dbus_message_iter_get_basic (&iter, &adapter); - path =g_dbus_proxy_get_path (master); + path =g_dbus_proxy_get_path (parent);if (!strcmp (path, adapter))return TRUE;
tools/mgmt-tester.c +61 -59
285 lines not on this page · raw message
tools/oobtest.c +4 -4
@@ -134,15 +134,15 @@ static void new_long_term_key_event(uint16_t index, uint16_t len,switch (ev->key.type) {case 0x00 :if (ev->key.central) - type ="Unauthenticated, Master" ; + type ="Unauthenticated, Central" ;else - type ="Unauthenticated, Slave" ; + type ="Unauthenticated, Peripheral" ;break ;case 0x01 :if (ev->key.central) - type ="Authenticated, Master" ; + type ="Authenticated, Central" ;else - type ="Authenticated, Slave" ; + type ="Authenticated, Peripheral" ;break ;case 0x02 : type ="Unauthenticated, P-256" ;
tools/parser/avdtp.c +7 -4
@@ -605,7 +605,7 @@ void avdtp_dump(int level, struct frame *frm) nsp = (hdr &0x0c ) ==0x04 ?p_get_u8 (frm) :0 ; sid = hdr &0x08 ?0x00 :p_get_u8 (frm); -printf ("AVDTP(s): %s %s: transaction %d nsp 0x%02x\n" , +printf ("AVDTP(p): %s %s: transaction %d nsp 0x%02x\n" , hdr &0x08 ?pt2str (hdr) :si2str (sid),mt2str (hdr), hdr >>4 , nsp);
@@ -659,9 +659,12 @@ void avdtp_dump(int level, struct frame *frm) time =p_get_u32 (frm); ssrc =p_get_u32 (frm); -printf ("AVDTP(m): ver %d %s%scc %d %spt %d seqn %d time %d ssrc %d\n" , - hdr >>6 , hdr &0x20 ?"pad " :"" , hdr &0x10 ?"ext " :"" , - hdr &0xf , type &0x80 ?"mark " :"" , type &0x7f , seqn, time, ssrc); +printf ("AVDTP(c): ver %d %s%scc" +" %d %spt %d seqn %d time %d ssrc %d\n" , + hdr >>6 , hdr &0x20 ?"pad " :"" , + hdr &0x10 ?"ext " :"" , hdr &0xf , + type &0x80 ?"mark " :"" , type &0x7f , + seqn, time, ssrc);break ; }
tools/parser/csr.c +9 -8
@@ -257,7 +257,7 @@ static inline void pskey_dump(int level, struct frame *frm)uint16_dump (level +1 ,"MAX_SCOS" , frm);break ;case 0x000f : -uint16_dump (level +1 ,"MAX_REMOTE_MASTERS" , frm); +uint16_dump (level +1 ,"MAX_REMOTE_CENTRALS" , frm);break ;case 0x00da :uint16_dump (level +1 ,"ENC_KEY_LMIN" , frm);
@@ -546,7 +546,7 @@ static char *frag2str(uint8_t frag)void csr_dump (int level,struct frame *frm) {uint8_t desc, cid, type; -uint16_t handle, master, addr; +uint16_t handle, central, addr; desc =CSR_U8 (frm);
@@ -564,24 +564,25 @@ void csr_dump(int level, struct frame *frm)switch (type) {case 0x0f : frm->handle = ((uint8_t *) frm->ptr)[17 ]; - frm->master =0 ; + frm->central =0 ; frm->len--;lmp_dump (level, frm);return ;case 0x10 : frm->handle = ((uint8_t *) frm->ptr)[17 ]; - frm->master =1 ; + frm->central =1 ; frm->len--;lmp_dump (level, frm);return ;case 0x12 : handle =CSR_U16 (frm); - master =CSR_U16 (frm); + central =CSR_U16 (frm); addr =CSR_U16 (frm);p_indent (level, frm); -printf ("FHS: handle %d addr %d (%s)\n" , handle, - addr, master ?"master" :"slave" ); -if (!master) { +printf ("FHS: handle %d addr %d (%s)\n" , + handle, addr, + central ?"central" :"peripheral" ); +if (!central) {char addr[18 ];p_ba2str ((bdaddr_t *) frm->ptr, addr);p_indent (level +1 , frm);
tools/parser/ericsson.c +1 -1
@@ -29,7 +29,7 @@ void ericsson_dump(int level, struct frame *frm)raw_dump (level, frm); } - frm->master = !(buf[0 ] &0x01 ); + frm->central = !(buf[0 ] &0x01 ); frm->handle = buf[1 ] | (buf[2 ] <<8 ); buf[5 ] = (buf[5 ] <<1 ) | (buf[3 ] &0x01 );
tools/parser/hci.c +20 -18
@@ -45,7 +45,7 @@ static char *event_str[EVENT_NUM + 1] = {"Remote Name Req Complete" ,"Encrypt Change" ,"Change Connection Link Key Complete" , -"Master Link Key Complete" , +"Temporary Link Key Complete" ,"Read Remote Supported Features" ,"Read Remote Ver Info Complete" , "QoS Setup Complete",
@@ -150,7 +150,7 @@ static char *cmd_linkctl_str[CMD_LINKCTL_NUM + 1] = {"Unknown" ,"Change Connection Link Key" ,"Unknown" , -"Master Link Key" , +"Temporary Link Key" ,"Unknown" ,"Remote Name Request" , "Remote Name Request Cancel",
@@ -383,10 +383,10 @@ static char *cmd_le_str[CMD_LE_NUM + 1] = {"LE Set Scan Enable" ,"LE Create Connection" ,"LE Create Connection Cancel" , -"LE Read White List Size" , -"LE Clear White List" , -"LE Add Device To White List" , -"LE Remove Device From White List" , +"LE Read Accept List Size" , +"LE Clear Accept List" , +"LE Add Device To Accept List" , +"LE Remove Device From Accept List" ,"LE Connection Update" ,"LE Set Host Channel Classification" , "LE Read Channel Map",
@@ -568,9 +568,9 @@ static char *role2str(uint8_t role) {switch (role) {case 0x00 : -return "Master" ; +return "Central" ;case 0x01 : -return "Slave" ; +return "Peripheral" ;default :return "Unknown" ; }
@@ -739,11 +739,11 @@ static char *filterpolicy2str(uint8_t policy)case 0x00 :return "Allow scan from any, connection from any" ;case 0x01 : -return "Allow scan from white list, connection from any" ; +return "Allow scan from accept list, connection from any" ;case 0x02 : -return "Allow scan from any, connection from white list" ; +return "Allow scan from any, connection from accept list" ;case 0x03 : -return "Allow scan and connection from white list" ; +return "Allow scan and connection from accept list" ;default :return "Reserved" ; }
@@ -1082,7 +1082,7 @@ static inline void remote_name_req_dump(int level, struct frame *frm) clkoffset & 0x7fff, clkoffset & 0x8000 ? " (valid)" : ""); } -static inline void master_link_key_dump (int level,struct frame *frm) +static inline void temporary_link_key_dump (int level,struct frame *frm) {master_link_key_cp *cp = frm->ptr;
@@ -1638,9 +1638,10 @@ static inline void le_set_scan_parameters_dump(int level, struct frame *frm)p_indent (level, frm);printf ("own address: 0x%02x (%s) policy: %s\n" , cp->own_bdaddr_type, -bdaddrtype2str (cp->own_bdaddr_type), +bdaddrtype2str (cp->own_bdaddr_type), (cp->filter ==0x00 ?"All" : - (cp->filter ==0x01 ?"white list only" :"reserved" ))); + (cp->filter ==0x01 ?"accept list only" : +"reserved" ))); }static inline void le_set_scan_enable_dump (int level,struct frame *frm)
@@ -1772,7 +1773,7 @@ static inline void command_dump(int level, struct frame *frm)generic_command_dump (level +1 , frm);return ;case OCF_MASTER_LINK_KEY : -master_link_key_dump (level +1 , frm); +temporary_link_key_dump (level +1 , frm);return ;case OCF_READ_REMOTE_EXT_FEATURES :read_remote_ext_features_dump (level +1 , frm);
@@ -3114,7 +3115,8 @@ static inline void remote_name_req_complete_dump(int level, struct frame *frm) } } -static inline void master_link_key_complete_dump (int level,struct frame *frm) +static inline void temporary_link_key_complete_dump (int level, +struct frame *frm) {evt_master_link_key_complete *evt = frm->ptr;
@@ -3565,7 +3567,7 @@ static inline void evt_le_conn_complete_dump(int level, struct frame *frm)p_indent (level, frm);printf ("status 0x%2.2x handle %d, role %s\n" , evt->status,btohs (evt->handle), - evt->role ?"slave" :"master" ); + evt->role ?"peripheral" :"central" );p_indent (level, frm);p_ba2str (&evt->peer_bdaddr, addr);
@@ -3875,7 +3877,7 @@ static inline void event_dump(int level, struct frame *frm)generic_response_dump (level +1 , frm);break ;case EVT_MASTER_LINK_KEY_COMPLETE : -master_link_key_complete_dump (level +1 , frm); +temporary_link_key_complete_dump (level +1 , frm);break ;case EVT_REMOTE_NAME_REQ_COMPLETE :remote_name_req_complete_dump (level +1 , frm);
tools/parser/lmp.c +56 -56
202 lines not on this page · raw message
tools/parser/parser.h +1 -1
@@ -26,7 +26,7 @@ struct frame {uint32_t len;uint16_t dev_id;uint8_t in; -uint8_t master; +uint8_t central;uint16_t handle;uint16_t cid;uint16_t num;
tools/parser/smp.c +6 -6
@@ -28,7 +28,7 @@#define SMP_CMD_PAIRING_RANDOM 0x04#define SMP_CMD_PAIRING_FAILED 0x05#define SMP_CMD_ENCRYPT_INFO 0x06 -#define SMP_CMD_MASTER_IDENT 0x07 +#define SMP_CMD_CENTRAL_IDENT 0x07#define SMP_CMD_IDENT_INFO 0X08#define SMP_CMD_IDENT_ADDR_INFO 0x09#define SMP_CMD_SIGN_INFO 0x0a
@@ -78,8 +78,8 @@ static const char *smpcmd2str(uint8_t cmd)return "Pairing Failed" ;case SMP_CMD_ENCRYPT_INFO :return "Encryption Information" ; -case SMP_CMD_MASTER_IDENT : -return "Master Identification" ; +case SMP_CMD_CENTRAL_IDENT : +return "Central Identification" ;case SMP_CMD_IDENT_INFO :return "Identity Information" ;case SMP_CMD_IDENT_ADDR_INFO :
@@ -221,7 +221,7 @@ static void smp_cmd_encrypt_info_dump(int level, struct frame *frm)printf ("\n" ); } -static void smp_cmd_master_ident_dump (int level,struct frame *frm) +static void smp_cmd_central_ident_dump (int level,struct frame *frm) {uint16_t ediv =btohs (htons (p_get_u16 (frm)));int i;
@@ -303,8 +303,8 @@ void smp_dump(int level, struct frame *frm)case SMP_CMD_ENCRYPT_INFO :smp_cmd_encrypt_info_dump (level +1 , frm);break ; -case SMP_CMD_MASTER_IDENT : -smp_cmd_master_ident_dump (level +1 , frm); +case SMP_CMD_CENTRAL_IDENT : +smp_cmd_central_ident_dump (level +1 , frm);break ;case SMP_CMD_IDENT_INFO :smp_cmd_ident_info_dump (level +1 , frm);
tools/rctest.c +10 -9
@@ -76,7 +76,7 @@ static const char *filename = NULL;static const char *savefile =NULL ;static int save_fd =-1 ; -static int master =0 ; +static int central =0 ;static int auth =0 ;static int encr =0 ;static int secure =0 ;
@@ -202,7 +202,7 @@ static int do_connect(const char *svr)/* Set link mode */ opt =0 ; -if (master) +if (central) opt |=RFCOMM_LM_MASTER ;if (auth) opt |=RFCOMM_LM_AUTH ;
@@ -293,7 +293,7 @@ static void do_listen(void (*handler)(int sk))/* Set link mode */ opt =0 ; -if (master) +if (central) opt |=RFCOMM_LM_MASTER ;if (auth) opt |=RFCOMM_LM_AUTH ;
@@ -679,13 +679,13 @@ static void usage(void)"\t[-B filename] use data packets from file\n" "\t[-O filename] save received data to file\n" "\t[-N num] number of frames to send\n" -"\t[-C num] send num frames before delay (default = 1)\n" +"\t[-M num] send num frames before delay (default = 1)\n" "\t[-D milliseconds] delay after sending num frames (default = 0)\n" "\t[-Y priority] socket priority\n" "\t[-A] request authentication\n" "\t[-E] request encryption\n" "\t[-S] secure connection\n" -"\t[-M] become master\n" +"\t[-C] become central\n" "\t[-T] enable timestamps\n"); }
@@ -697,7 +697,8 @@ int main(int argc, char *argv[])bacpy (&bdaddr,BDADDR_ANY );bacpy (&auto_bdaddr,BDADDR_ANY ); -while ((opt=getopt (argc,argv,"rdscuwmna:b:i:P:U:B:O:N:MAESL:W:C:D:Y:T" )) !=EOF ) { +while ((opt =getopt (argc, argv, +"rdscuwmna:b:i:P:U:B:O:N:CAESL:W:M:D:Y:T" )) !=EOF ) {switch (opt) {case 'r' : mode =RECV ;
@@ -769,8 +770,8 @@ int main(int argc, char *argv[]) uuid =atoi (optarg);break ; -case 'M' : - master =1 ; +case 'C' : + central =1 ;break ;case 'A' :
@@ -805,7 +806,7 @@ int main(int argc, char *argv[]) num_frames =atoi (optarg);break ; -case 'C' : +case 'M' : count =atoi (optarg);break ;
tools/rctest.rst +2 -2
@@ -56,7 +56,7 @@ OPTIONS -N num send num frames --C num send num frames before delay (default: 1) +-M num send num frames before delay (default: 1) -D milliseconds delay milliseconds after sending num frames (default: 0)
@@ -66,7 +66,7 @@ OPTIONS -S secure connection --M become master +-C become central -T enable timestamps
tools/rfcomm-tester.c +7 -7
@@ -534,7 +534,7 @@ static void test_connect(const void *test_data)struct test_data *data =tester_get_data ();struct bthost *bthost =hciemu_client_get_host (data->hciemu);const struct rfcomm_client_data *cli = data->test_data; -const uint8_t *client_addr, *master_addr; +const uint8_t *client_addr, *central_addr;GIOChannel *io;int sk;
@@ -542,10 +542,10 @@ static void test_connect(const void *test_data)bthost_add_rfcomm_server (bthost, cli->server_channel, rfcomm_connect_cb,NULL ); - master_addr =hciemu_get_central_bdaddr (data->hciemu); + central_addr =hciemu_get_central_bdaddr (data->hciemu); client_addr =hciemu_get_client_bdaddr (data->hciemu); - sk =create_rfcomm_sock ((bdaddr_t *) master_addr,0 ); + sk =create_rfcomm_sock ((bdaddr_t *) central_addr,0 );if (connect_rfcomm_sock (sk, (const bdaddr_t *) client_addr, cli->client_channel) <0 ) {
@@ -675,14 +675,14 @@ static void test_server(const void *test_data) {struct test_data *data =tester_get_data ();const struct rfcomm_server_data *srv = data->test_data; -const uint8_t *master_addr; +const uint8_t *central_addr;struct bthost *bthost;GIOChannel *io;int sk; - master_addr =hciemu_get_central_bdaddr (data->hciemu); + central_addr =hciemu_get_central_bdaddr (data->hciemu); - sk =create_rfcomm_sock ((bdaddr_t *) master_addr, srv->server_channel); + sk =create_rfcomm_sock ((bdaddr_t *) central_addr, srv->server_channel);if (sk <0 ) {tester_test_failed ();return ;
@@ -707,7 +707,7 @@ static void test_server(const void *test_data) bthost =hciemu_client_get_host (data->hciemu);bthost_set_connect_cb (bthost, client_new_conn, data); -bthost_hci_connect (bthost, master_addr,BDADDR_BREDR ); +bthost_hci_connect (bthost, central_addr,BDADDR_BREDR ); }#define test_rfcomm (name, data, setup, func) \
tools/rfcomm.c +8 -7
@@ -37,7 +37,7 @@ static int rfcomm_raw_tty = 0;static int auth =0 ;static int encryption =0 ;static int secure =0 ; -static int master =0 ; +static int central =0 ;static int linger =0 ;static char *rfcomm_state[] = {
@@ -434,7 +434,7 @@ static void cmd_listen(int ctl, int dev, bdaddr_t *bdaddr, int argc, char **argv } lm =0 ; -if (master) +if (central) lm |=RFCOMM_LM_MASTER ;if (auth) lm |=RFCOMM_LM_AUTH ;
@@ -646,7 +646,7 @@ static void usage(void)"\t-A, --auth Enable authentication\n" "\t-E, --encrypt Enable encryption\n" "\t-S, --secure Secure connection\n" -"\t-M, --master Become the master of a piconet\n" +"\t-C, --central Become the central of a piconet\n" "\t-L, --linger [seconds] Set linger timeout\n" "\t-a Show all devices (default)\n" "\n");
@@ -668,7 +668,7 @@ static struct option main_options[] = { { "auth", 0, 0, 'A' }, { "encrypt", 0, 0, 'E' }, { "secure", 0, 0, 'S' }, - { "master", 0, 0, 'M' }, + { "central", 0, 0, 'C' }, { "linger", 1, 0, 'L' }, { 0, 0, 0, 0 } };
@@ -680,7 +680,8 @@ int main(int argc, char *argv[])bacpy (&bdaddr,BDADDR_ANY ); -while ((opt =getopt_long (argc, argv,"+i:rahAESML:" , main_options,NULL )) !=-1 ) { +while ((opt =getopt_long (argc, argv,"+i:rahAESCL:" , main_options, +NULL )) !=-1 ) {switch (opt) {case 'i' :if (strncmp (optarg,"hci" ,3 ) ==0 )
@@ -713,8 +714,8 @@ int main(int argc, char *argv[]) secure =1 ;break ; -case 'M' : - master =1 ; +case 'C' : + central =1 ;break ;case 'L' :
tools/rfcomm.rst +1 -1
@@ -47,7 +47,7 @@ OPTIONS -S Secure connection --M Become the master of a piconet +-C Become the central of a piconet -L <seconds> Set linger timeout
tools/sco-tester.c +5 -5
@@ -413,7 +413,7 @@ end:static int create_sco_sock (struct test_data *data) { -const uint8_t *master_bdaddr; +const uint8_t *central_bdaddr;struct sockaddr_sco addr;int sk, err;
@@ -426,15 +426,15 @@ static int create_sco_sock(struct test_data *data)return err; } - master_bdaddr =hciemu_get_central_bdaddr (data->hciemu); -if (!master_bdaddr) { -tester_warn ("No master bdaddr" ); + central_bdaddr =hciemu_get_central_bdaddr (data->hciemu); +if (!central_bdaddr) { +tester_warn ("No central bdaddr" );return -ENODEV ; }memset (&addr,0 ,sizeof (addr)); addr.sco_family =AF_BLUETOOTH ; -bacpy (&addr.sco_bdaddr, (void *) master_bdaddr); +bacpy (&addr.sco_bdaddr, (void *) central_bdaddr);if (bind (sk, (struct sockaddr *) &addr,sizeof (addr)) <0 ) { err = -errno;
tools/smp-tester.c +6 -6
@@ -765,11 +765,11 @@ static void smp_new_conn(uint16_t handle, void *user_data)static void init_bdaddr (struct test_data *data) { -const uint8_t *master_bdaddr, *client_bdaddr; +const uint8_t *central_bdaddr, *client_bdaddr; - master_bdaddr =hciemu_get_central_bdaddr (data->hciemu); -if (!master_bdaddr) { -tester_warn ("No master bdaddr" ); + central_bdaddr =hciemu_get_central_bdaddr (data->hciemu); +if (!central_bdaddr) { +tester_warn ("No central bdaddr" );tester_test_failed ();return ; }
@@ -786,9 +786,9 @@ static void init_bdaddr(struct test_data *data)if (data->out) {memcpy (data->ia, client_bdaddr,sizeof (data->ia)); -memcpy (data->ra, master_bdaddr,sizeof (data->ra)); +memcpy (data->ra, central_bdaddr,sizeof (data->ra)); }else { -memcpy (data->ia, master_bdaddr,sizeof (data->ia)); +memcpy (data->ia, central_bdaddr,sizeof (data->ia));memcpy (data->ra, client_bdaddr,sizeof (data->ra)); } }
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 6/12 plugins/sixaxis: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL uses "central" as it is deemed to be more appropriate.
---
(no changes since v1)
plugins/sixaxis.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-)
plugins/sixaxis.c +22 -22
@@ -139,7 +139,7 @@ static int get_device_bdaddr(int fd, bdaddr_t *bdaddr, CablePairingType type)return -1 ; } -static int sixaxis_get_master_bdaddr (int fd,bdaddr_t *bdaddr) +static int sixaxis_get_central_bdaddr (int fd,bdaddr_t *bdaddr) {uint8_t buf[8 ];int ret;
@@ -150,7 +150,7 @@ static int sixaxis_get_master_bdaddr(int fd, bdaddr_t *bdaddr) ret =ioctl (fd,HIDIOCGFEATURE (sizeof (buf)), buf);if (ret <0 ) { -error ("sixaxis: failed to read master address (%s)" , +error ("sixaxis: failed to read central address (%s)" ,strerror (errno));return ret; }
@@ -160,7 +160,7 @@ static int sixaxis_get_master_bdaddr(int fd, bdaddr_t *bdaddr)return 0 ; } -static int ds4_get_master_bdaddr (int fd,bdaddr_t *bdaddr) +static int ds4_get_central_bdaddr (int fd,bdaddr_t *bdaddr) {uint8_t buf[16 ];int ret;
@@ -171,7 +171,7 @@ static int ds4_get_master_bdaddr(int fd, bdaddr_t *bdaddr) ret =ioctl (fd,HIDIOCGFEATURE (sizeof (buf)), buf);if (ret <0 ) { -error ("sixaxis: failed to read DS4 master address (%s)" , +error ("sixaxis: failed to read DS4 central address (%s)" ,strerror (errno));return ret; }
@@ -182,16 +182,16 @@ static int ds4_get_master_bdaddr(int fd, bdaddr_t *bdaddr)return 0 ; } -static int get_master_bdaddr (int fd,bdaddr_t *bdaddr,CablePairingType type) +static int get_central_bdaddr (int fd,bdaddr_t *bdaddr,CablePairingType type) {if (type ==CABLE_PAIRING_SIXAXIS ) -return sixaxis_get_master_bdaddr (fd, bdaddr); +return sixaxis_get_central_bdaddr (fd, bdaddr);else if (type ==CABLE_PAIRING_DS4 ) -return ds4_get_master_bdaddr (fd, bdaddr); +return ds4_get_central_bdaddr (fd, bdaddr);return -1 ; } -static int sixaxis_set_master_bdaddr (int fd,const bdaddr_t *bdaddr) +static int sixaxis_set_central_bdaddr (int fd,const bdaddr_t *bdaddr) {uint8_t buf[8 ];int ret;
@@ -203,13 +203,13 @@ static int sixaxis_set_master_bdaddr(int fd, const bdaddr_t *bdaddr) ret =ioctl (fd,HIDIOCSFEATURE (sizeof (buf)), buf);if (ret <0 ) -error ("sixaxis: failed to write master address (%s)" , +error ("sixaxis: failed to write central address (%s)" ,strerror (errno));return ret; } -static int ds4_set_master_bdaddr (int fd,const bdaddr_t *bdaddr) +static int ds4_set_central_bdaddr (int fd,const bdaddr_t *bdaddr) {uint8_t buf[23 ];int ret;
@@ -223,19 +223,19 @@ static int ds4_set_master_bdaddr(int fd, const bdaddr_t *bdaddr) ret =ioctl (fd,HIDIOCSFEATURE (sizeof (buf)), buf);if (ret <0 ) -error ("sixaxis: failed to write DS4 master address (%s)" , +error ("sixaxis: failed to write DS4 central address (%s)" ,strerror (errno));return ret; } -static int set_master_bdaddr (int fd,const bdaddr_t *bdaddr, +static int set_central_bdaddr (int fd,const bdaddr_t *bdaddr,CablePairingType type) {if (type ==CABLE_PAIRING_SIXAXIS ) -return sixaxis_set_master_bdaddr (fd, bdaddr); +return sixaxis_set_central_bdaddr (fd, bdaddr);else if (type ==CABLE_PAIRING_DS4 ) -return ds4_set_master_bdaddr (fd, bdaddr); +return ds4_set_central_bdaddr (fd, bdaddr);return -1 ; }
@@ -267,8 +267,8 @@ static void agent_auth_cb(DBusError *derr, void *user_data) {struct authentication_closure *closure = user_data;struct authentication_destroy_closure *destroy; -char master_addr[18 ], adapter_addr[18 ], device_addr[18 ]; -bdaddr_t master_bdaddr; +char central_addr[18 ], adapter_addr[18 ], device_addr[18 ]; +bdaddr_t central_bdaddr;const bdaddr_t *adapter_bdaddr;bool remove_device = true;
@@ -283,12 +283,12 @@ static void agent_auth_cb(DBusError *derr, void *user_data) goto out; } -if (get_master_bdaddr (closure->fd, &master_bdaddr, closure->type) <0 ) +if (get_central_bdaddr (closure->fd, ¢ral_bdaddr, closure->type) <0 ) goto out; adapter_bdaddr =btd_adapter_get_address (closure->adapter); -if (bacmp (adapter_bdaddr, &master_bdaddr)) { -if (set_master_bdaddr (closure->fd, adapter_bdaddr, +if (bacmp (adapter_bdaddr, ¢ral_bdaddr)) { +if (set_central_bdaddr (closure->fd, adapter_bdaddr, closure->type) <0 ) goto out; }
@@ -302,10 +302,10 @@ static void agent_auth_cb(DBusError *derr, void *user_data) SIXAXIS_HID_SDP_RECORD);ba2str (&closure->bdaddr, device_addr); -ba2str (&master_bdaddr, master_addr); +ba2str (¢ral_bdaddr, central_addr);ba2str (adapter_bdaddr, adapter_addr); -DBG ("remote %s old_master %s new_master %s" , - device_addr, master_addr, adapter_addr); +DBG ("remote %s old_central %s new_central %s" , + device_addr, central_addr, adapter_addr); out:g_hash_table_steal (pending_auths, closure->sysfs_path);
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 7/12 profiles: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central" and "peripheral".
---
Changes in v4:
* Fix line over 80 columns
Changes in v2:
* Merging several patches from the same directory into one
profiles/audio/avctp.c | 10 +++++----- profiles/audio/avctp.h | 2 +- profiles/health/mcap.c | 20 ++++++++++---------- profiles/health/mcap.h | 2 +- 4 files changed, 17 insertions(+), 17 deletions(-)
profiles/audio/avctp.c +5 -5
@@ -1614,7 +1614,7 @@ static void avctp_confirm_cb(GIOChannel *chan, gpointer data)return ; } -static GIOChannel *avctp_server_socket (const bdaddr_t *src,gboolean master, +static GIOChannel *avctp_server_socket (const bdaddr_t *src,gboolean central,uint8_t mode,uint16_t psm) {GError *err =NULL ;
@@ -1625,7 +1625,7 @@ static GIOChannel *avctp_server_socket(const bdaddr_t *src, gboolean master,BT_IO_OPT_SOURCE_BDADDR , src,BT_IO_OPT_PSM , psm,BT_IO_OPT_SEC_LEVEL ,BT_IO_SEC_MEDIUM , -BT_IO_OPT_CENTRAL , master, +BT_IO_OPT_CENTRAL , central,BT_IO_OPT_MODE , mode, BT_IO_OPT_INVALID);if (!io) {
@@ -1636,20 +1636,20 @@ static GIOChannel *avctp_server_socket(const bdaddr_t *src, gboolean master,return io; } -int avctp_register (struct btd_adapter *adapter,gboolean master) +int avctp_register (struct btd_adapter *adapter,gboolean central) {struct avctp_server *server;const bdaddr_t *src =btd_adapter_get_address (adapter); server = g_new0(struct avctp_server, 1); - server->control_io =avctp_server_socket (src, master,BT_IO_MODE_BASIC , + server->control_io =avctp_server_socket (src, central,BT_IO_MODE_BASIC ,AVCTP_CONTROL_PSM );if (!server->control_io) {g_free (server);return -1 ; } - server->browsing_io =avctp_server_socket (src, master,BT_IO_MODE_ERTM , + server->browsing_io =avctp_server_socket (src, central,BT_IO_MODE_ERTM ,AVCTP_BROWSING_PSM );if (!server->browsing_io) {if (server->control_io) {
profiles/audio/avctp.h +1 -1
@@ -145,7 +145,7 @@ unsigned int avctp_add_state_cb(struct btd_device *dev, avctp_state_cb cb, void *user_data);gboolean avctp_remove_state_cb (unsigned int id); -int avctp_register (struct btd_adapter *adapter,gboolean master); +int avctp_register (struct btd_adapter *adapter,gboolean central);void avctp_unregister (struct btd_adapter *adapter);struct avctp *avctp_connect (struct btd_device *device);
profiles/health/mcap.c +10 -10
@@ -52,15 +52,15 @@struct mcap_csp {uint64_t base_tmstamp;/* CSP base timestamp */ struct timespec base_time;/* CSP base time when timestamp set */ -guint local_caps;/* CSP-Master: have got remote caps */ -guint remote_caps;/* CSP-Slave: remote master got caps */ -guint rem_req_acc;/* CSP-Slave: accuracy required by master */ -guint ind_expected;/* CSP-Master: indication expected */ -uint8_t csp_req;/* CSP-Master: Request control flag */ -guint ind_timer;/* CSP-Slave: indication timer */ -guint set_timer;/* CSP-Slave: delayed set timer */ -void *set_data;/* CSP-Slave: delayed set data */ -void *csp_priv_data;/* CSP-Master: In-flight request data */ +guint local_caps;/* CSP-Cent.: have got remote caps */ +guint remote_caps;/* CSP-Perip: remote central got caps */ +guint rem_req_acc;/* CSP-Perip: accuracy req by central */ +guint ind_expected;/* CSP-Cent.: indication expected */ +uint8_t csp_req;/* CSP-Cent.: Request control flag */ +guint ind_timer;/* CSP-Perip: indication timer */ +guint set_timer;/* CSP-Perip: delayed set timer */ +void *set_data;/* CSP-Perip: delayed set data */ +void *csp_priv_data;/* CSP-Cent.: In-flight request data */ };struct mcap_sync_cap_cbdata {
@@ -3139,7 +3139,7 @@ void mcap_sync_set_req(struct mcap_mcl *mcl, uint8_t update, uint32_t btclock,g_set_error (err,MCAP_CSP_ERROR ,MCAP_ERROR_RESOURCE_UNAVAILABLE , -"Did not get CSP caps from slave yet" ); +"Did not get CSP caps from peripheral yet" );return ; }
profiles/health/mcap.h +1 -1
@@ -270,7 +270,7 @@ struct mcap_instance {mcap_mcl_event_cb mcl_reconnected_cb;/* Old MCL has been reconnected */ mcap_mcl_event_cb mcl_disconnected_cb;/* MCL disconnected */ mcap_mcl_event_cb mcl_uncached_cb;/* MCL has been removed from MCAP cache */ -mcap_info_ind_event_cb mcl_sync_infoind_cb;/* (CSP Master) Received info indication */ +mcap_info_ind_event_cb mcl_sync_infoind_cb;/* (CSP Central) Received info indication */ gpointer user_data;/* Data to be provided in callbacks */ int ref;/* Reference counter */
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 8/12 src: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
BT core spec 5.3 promotes the usage of inclusive languages. This CL replaces some terms with the more appropriate counterparts, such as "central", "peripheral", "accept list", and "reject list". Note that some suggestions come from
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
Also use "primary" to refer the global mgmt struct.
---
(no changes since v2)
Changes in v2:
* Merging several patches from the same directory into one
android/handsfree-client.c | 2 +- src/adapter.c | 111 +++++++++++++++++++------------------ src/adapter.h | 4 +- src/device.c | 6 +- src/sdpd-server.c | 8 +-- src/sdpd.h | 2 +- src/shared/ad.c | 8 +-- src/shared/ad.h | 2 +- src/shared/hfp.c | 4 +- src/shared/hfp.h | 2 +- 10 files changed, 76 insertions(+), 73 deletions(-)
android/handsfree-client.c +1 -1
@@ -405,7 +405,7 @@ static void cmd_complete_cb(enum hfp_result result, enum hfp_error cme_err,case HFP_RESULT_DELAYED : ev.type =HAL_HF_CLIENT_CMD_COMP_ERR_DELAYED ;break ; -case HFP_RESULT_BLACKLISTED : +case HFP_RESULT_REJECTED : ev.type =HAL_HF_CLIENT_CMD_COMP_ERR_BACKLISTED ;break ;case HFP_RESULT_CME_ERROR :
src/adapter.c +57 -54
339 lines not on this page · raw message
src/adapter.h +2 -2
@@ -225,9 +225,9 @@ void adapter_auto_connect_add(struct btd_adapter *adapter, struct btd_device *device);void adapter_auto_connect_remove (struct btd_adapter *adapter,struct btd_device *device); -void adapter_whitelist_add (struct btd_adapter *adapter, +void adapter_accept_list_add (struct btd_adapter *adapter,struct btd_device *dev); -void adapter_whitelist_remove (struct btd_adapter *adapter, +void adapter_accept_list_remove (struct btd_adapter *adapter,struct btd_device *dev); void btd_adapter_set_oob_handler(struct btd_adapter *adapter,
src/device.c +3 -3
@@ -1123,7 +1123,7 @@ static void set_blocked(GDBusPendingPropertySet id, gboolean value, void *data)break ;case EINVAL :g_dbus_pending_property_error (id,ERROR_INTERFACE ".Failed" , -"Kernel lacks blacklist support" ); +"Kernel lacks reject list support" );break ;default : g_dbus_pending_property_error(id, ERROR_INTERFACE ".Failed",
@@ -5789,7 +5789,7 @@ void btd_device_set_temporary(struct btd_device *device, bool temporary)if (temporary) {if (device->bredr) -adapter_whitelist_remove (device->adapter, device); +adapter_accept_list_remove (device->adapter, device);adapter_connect_list_remove (device->adapter, device);if (device->auto_connect) { device->disable_auto_connect = TRUE;
@@ -5801,7 +5801,7 @@ void btd_device_set_temporary(struct btd_device *device, bool temporary)clear_temporary_timer (device);if (device->bredr) -adapter_whitelist_add (device->adapter, device); +adapter_accept_list_add (device->adapter, device);store_device_info (device);
src/sdpd-server.c +4 -4
@@ -41,7 +41,7 @@ static int l2cap_sock = -1, unix_sock = -1;* l2cap and unix sockets over which discovery and registration clients * access us respectively */ -static int init_server (uint16_t mtu,int master,int compat) +static int init_server (uint16_t mtu,int central,int compat) {struct l2cap_options opts;struct sockaddr_l2 l2addr;
@@ -71,7 +71,7 @@ static int init_server(uint16_t mtu, int master, int compat)return -1 ; } -if (master) { +if (central) {int opt =L2CAP_LM_MASTER ;if (setsockopt (l2cap_sock,SOL_L2CAP ,L2CAP_LM , &opt,sizeof (opt)) <0 ) {error ("setsockopt: %s" ,strerror (errno));
@@ -218,12 +218,12 @@ static gboolean io_accept_event(GIOChannel *chan, GIOCondition cond, gpointer daint start_sdp_server (uint16_t mtu,uint32_t flags) {int compat = flags &SDP_SERVER_COMPAT ; -int master = flags &SDP_SERVER_MASTER ; +int central = flags &SDP_SERVER_CENTRAL ;GIOChannel *io;info ("Starting SDP server" ); -if (init_server (mtu, master, compat) <0 ) { +if (init_server (mtu, central, compat) <0 ) {error ("Server initialization failed" );return -1 ; }
src/sdpd.h +1 -1
@@ -59,7 +59,7 @@ uint32_t sdp_next_handle(void);uint32_t sdp_get_time (void );#define SDP_SERVER_COMPAT (1 << 0) -#define SDP_SERVER_MASTER (1 << 1) +#define SDP_SERVER_CENTRAL (1 << 1)int start_sdp_server (uint16_t mtu,uint32_t flags);void stop_sdp_server (void );
src/shared/ad.c +4 -4
@@ -959,7 +959,7 @@ void bt_ad_clear_flags(struct bt_ad *ad) data_destroy); } -static uint8_t type_blacklist[] = { +static uint8_t type_reject_list[] = {BT_AD_FLAGS ,BT_AD_UUID16_SOME ,BT_AD_UUID16_ALL ,
@@ -976,7 +976,7 @@ static uint8_t type_blacklist[] = {BT_AD_DEVICE_ID ,BT_AD_SMP_TK ,BT_AD_SMP_OOB_FLAGS , -BT_AD_SLAVE_CONN_INTERVAL , +BT_AD_PERIPHERAL_CONN_INTERVAL ,BT_AD_SOLICIT16 ,BT_AD_SOLICIT128 , BT_AD_SERVICE_DATA16,
@@ -1012,8 +1012,8 @@ bool bt_ad_add_data(struct bt_ad *ad, uint8_t type, void *data, size_t len)if (len > (BT_AD_MAX_DATA_LEN -2 ))return false; -for (i =0 ; i <sizeof (type_blacklist); i++) { -if (type == type_blacklist[i]) +for (i =0 ; i <sizeof (type_reject_list); i++) { +if (type == type_reject_list[i])return false; }
src/shared/ad.h +1 -1
@@ -32,7 +32,7 @@#define BT_AD_DEVICE_ID 0x10#define BT_AD_SMP_TK 0x10#define BT_AD_SMP_OOB_FLAGS 0x11 -#define BT_AD_SLAVE_CONN_INTERVAL 0x12 +#define BT_AD_PERIPHERAL_CONN_INTERVAL 0x12#define BT_AD_SOLICIT16 0x14#define BT_AD_SOLICIT128 0x15#define BT_AD_SERVICE_DATA16 0x16
src/shared/hfp.c +2 -2
@@ -721,7 +721,7 @@ bool hfp_gw_send_result(struct hfp_gw *hfp, enum hfp_result result)case HFP_RESULT_BUSY :case HFP_RESULT_NO_ANSWER :case HFP_RESULT_DELAYED : -case HFP_RESULT_BLACKLISTED : +case HFP_RESULT_REJECTED :case HFP_RESULT_CME_ERROR :case HFP_RESULT_NO_DIALTONE :case HFP_RESULT_CONNECT :
@@ -1018,7 +1018,7 @@ static bool is_response(const char *prefix, enum hfp_result *result, }if (strcmp (prefix,"BLACKLISTED" ) ==0 ) { - *result =HFP_RESULT_BLACKLISTED ; + *result =HFP_RESULT_REJECTED ; *cme_err =0 ;return true; }
src/shared/hfp.h +1 -1
@@ -20,7 +20,7 @@ enum hfp_result {HFP_RESULT_BUSY =7 ,HFP_RESULT_NO_ANSWER =8 ,HFP_RESULT_DELAYED =9 , -HFP_RESULT_BLACKLISTED =10 , +HFP_RESULT_REJECTED =10 , HFP_RESULT_CME_ERROR = 11, };
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 9/12 client: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
Use "parent" to describe dbus hierarchy.
---
(no changes since v1)
client/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
client/main.c +3 -3
@@ -365,19 +365,19 @@ static void print_uuids(GDBusProxy *proxy) } } -static gboolean device_is_child (GDBusProxy *device,GDBusProxy *master) +static gboolean device_is_child (GDBusProxy *device,GDBusProxy *parent) {DBusMessageIter iter;const char *adapter, *path; -if (!master) +if (!parent)return FALSE;if (g_dbus_proxy_get_property (device,"Adapter" , &iter) == FALSE)return FALSE;dbus_message_iter_get_basic (&iter, &adapter); - path =g_dbus_proxy_get_path (master); + path =g_dbus_proxy_get_path (parent);if (!strcmp (path, adapter))return TRUE;
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 10/12 mesh: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
According to
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
"flooding", "accept list", and "reject list" are the preferred terms.
---
(no changes since v1)
mesh/net-keys.c | 38 +++++++++++++++++++------------------- mesh/net-keys.h | 8 ++++---- mesh/net.h | 4 ++-- 3 files changed, 25 insertions(+), 25 deletions(-)
mesh/net-keys.c +19 -19
@@ -45,7 +45,7 @@ struct net_key {uint16_t beacon_enables;uint8_t friend_key;uint8_t nid; -uint8_t master[16 ]; +uint8_t flooding[16 ];uint8_t encrypt[16 ];uint8_t privacy[16 ];uint8_t beacon[16 ];
@@ -53,7 +53,7 @@ struct net_key { };static struct l_queue *keys =NULL ; -static uint32_t last_master_id =0 ; +static uint32_t last_flooding_id =0 ;/* To avoid re-decrypting same packet for multiple nodes, cache and check */ static uint8_t cache_pkt[29 ];
@@ -63,11 +63,11 @@ static size_t cache_plainlen;static uint32_t cache_id;static uint32_t cache_iv_index; -static bool match_master (const void *a,const void *b) +static bool match_flooding (const void *a,const void *b) {const struct net_key *key = a; -return (memcmp (key->master, b,sizeof (key->master)) ==0 ); +return (memcmp (key->flooding, b,sizeof (key->flooding)) ==0 ); }static bool match_id (const void *a,const void *b)
@@ -87,9 +87,9 @@ static bool match_network(const void *a, const void *b) }/* Key added from Provisioning, NetKey Add or NetKey update */ -uint32_t net_key_add (const uint8_t master[16 ]) +uint32_t net_key_add (const uint8_t flooding[16 ]) { -struct net_key *key =l_queue_find (keys, match_master, master); +struct net_key *key =l_queue_find (keys, match_flooding, flooding);uint8_t p[] = {0 };bool result;
@@ -102,22 +102,22 @@ uint32_t net_key_add(const uint8_t master[16]) keys =l_queue_new (); key = l_new(struct net_key, 1); -memcpy (key->master, master,16 ); +memcpy (key->flooding, flooding,16 ); key->ref_cnt++; - result =mesh_crypto_k2 (master, p,sizeof (p), &key->nid, key->encrypt, + result =mesh_crypto_k2 (flooding, p,sizeof (p), &key->nid, key->encrypt, key->privacy);if (!result) goto fail; - result =mesh_crypto_k3 (master, key->network); + result =mesh_crypto_k3 (flooding, key->network);if (!result) goto fail; - result =mesh_crypto_nkbk (master, key->beacon); + result =mesh_crypto_nkbk (flooding, key->beacon);if (!result) goto fail; - key->id = ++last_master_id; + key->id = ++last_flooding_id;l_queue_push_tail (keys, key);return key->id;
@@ -126,11 +126,11 @@ fail:return 0 ; } -uint32_t net_key_frnd_add (uint32_t master_id,uint16_t lpn,uint16_t frnd, +uint32_t net_key_frnd_add (uint32_t flooding_id,uint16_t lpn,uint16_t frnd,uint16_t lp_cnt,uint16_t fn_cnt) {const struct net_key *key =l_queue_find (keys, match_id, -L_UINT_TO_PTR (master_id)); +L_UINT_TO_PTR (flooding_id));struct net_key *frnd_key;uint8_t p[9 ] = {0x01 };bool result;
@@ -145,7 +145,7 @@ uint32_t net_key_frnd_add(uint32_t master_id, uint16_t lpn, uint16_t frnd,l_put_be16 (lp_cnt, p +5 );l_put_be16 (fn_cnt, p +7 ); - result =mesh_crypto_k2 (key->master, p,sizeof (p), &frnd_key->nid, + result =mesh_crypto_k2 (key->flooding, p,sizeof (p), &frnd_key->nid, frnd_key->encrypt, frnd_key->privacy);if (!result) {
@@ -155,7 +155,7 @@ uint32_t net_key_frnd_add(uint32_t master_id, uint16_t lpn, uint16_t frnd, frnd_key->friend_key = true; frnd_key->ref_cnt++; - frnd_key->id = ++last_master_id; + frnd_key->id = ++last_flooding_id;l_queue_push_head (keys, frnd_key);return frnd_key->id;
@@ -174,22 +174,22 @@ void net_key_unref(uint32_t id) } } -bool net_key_confirm (uint32_t id,const uint8_t master[16 ]) +bool net_key_confirm (uint32_t id,const uint8_t flooding[16 ]) {struct net_key *key =l_queue_find (keys, match_id,L_UINT_TO_PTR (id));if (key) -return memcmp (key->master, master,sizeof (key->master)) ==0 ; +return !memcmp (key->flooding, flooding,sizeof (key->flooding));return false; } -bool net_key_retrieve (uint32_t id,uint8_t *master) +bool net_key_retrieve (uint32_t id,uint8_t *flooding) {struct net_key *key =l_queue_find (keys, match_id,L_UINT_TO_PTR (id));if (key) { -memcpy (master, key->master,sizeof (key->master)); +memcpy (flooding, key->flooding,sizeof (key->flooding));return true; }
mesh/net-keys.h +4 -4
@@ -13,10 +13,10 @@#define IV_INDEX_UPDATE 0x02void net_key_cleanup (void ); -bool net_key_confirm (uint32_t id,const uint8_t master[16 ]); -bool net_key_retrieve (uint32_t id,uint8_t *master); -uint32_t net_key_add (const uint8_t master[16 ]); -uint32_t net_key_frnd_add (uint32_t master_id,uint16_t lpn,uint16_t frnd, +bool net_key_confirm (uint32_t id,const uint8_t flooding[16 ]); +bool net_key_retrieve (uint32_t id,uint8_t *flooding); +uint32_t net_key_add (const uint8_t flooding[16 ]); +uint32_t net_key_frnd_add (uint32_t flooding_id,uint16_t lpn,uint16_t frnd,uint16_t lp_cnt,uint16_t fn_cnt);void net_key_unref (uint32_t id); uint32_t net_key_decrypt(uint32_t iv_index, const uint8_t *pkt, size_t len,
mesh/net.h +2 -2
@@ -86,8 +86,8 @@ struct mesh_node;#define PROXY_OP_FILTER_STATUS 0x03/* Proxy Filter Defines */ -#define PROXY_FILTER_WHITELIST 0x00 -#define PROXY_FILTER_BLACKLIST 0x01 +#define PROXY_FILTER_ACCEPT_LIST 0x00 +#define PROXY_FILTER_REJECT_LIST 0x01/* Network Tranport Opcodes */ #define NET_OP_SEG_ACKNOWLEDGE 0x00
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 11/12 unit/mesh: Inclusive language changes
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
According to
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
"flooding" is the preferred term.
---
(no changes since v1)
unit/test-mesh-crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
unit/test-mesh-crypto.c +2 -2
@@ -111,7 +111,7 @@ static const struct mesh_crypto_test s8_1_2 = { };static const struct mesh_crypto_test s8_1_3 = { - .name ="8.1.3 k2 function (master)" , + .name ="8.1.3 k2 function (flooding)" , .net_key ="f7a2a44f8e8a8029064f173ddc1e2b00" , .p ="00" , .nid ="7f" ,
@@ -159,7 +159,7 @@ static const struct mesh_crypto_test s8_2_1 = { };static const struct mesh_crypto_test s8_2_2 = { - .name ="8.2.2 Encryption and privacy keys (Master)" , + .name ="8.2.2 Encryption and privacy keys (flooding)" , .net_key ="7dd7364cd842ad18c17c2b820c84c3d6" , .p ="00" , .nid ="68" ,
Signature · 1 line
2.33.0.153.gba50c8fa24-goog
PATCH v4 12/12 doc: Inclusive language update
In reply to Archie PusakaFrom: Archie Pusaka <[email protected]>
Update the docs to reflect the changes for the other inclusive language updates.
---
(no changes since v2)
Changes in v2:
* Merging several patches from the same directory into one
doc/mesh-api.txt | 2 +- doc/mgmt-api.txt | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
doc/mesh-api.txt +1 -1
@@ -585,7 +585,7 @@ Methods: org.bluez.mesh.Error.InvalidArguments void SetKeyPhase(uint16 net_index, uint8 phase) - This method is used to set the master key update phase of the + This method is used to set the flooding key update phase of the given subnet. When finalizing the procedure, it is important to CompleteAppKeyUpdate() on all app keys that have been updated during the procedure prior to setting phase 3.
doc/mgmt-api.txt +3 -3
@@ -855,7 +855,7 @@ Load Long Term Keys Command Address (6 Octets) Address_Type (1 Octet) Key_Type (1 Octet) - Master (1 Octet) + Central (1 Octet) Encryption_Size (1 Octet) Encryption_Diversifier (2 Octets) Random_Number (8 Octets)
@@ -4019,7 +4019,7 @@ New Long Term Key Event Address (6 Octets) Address_Type (1 Octet) Key_Type (1 Octet) - Master (1 Octet) + Central (1 Octet) Encryption Size (1 Octet) Enc. Diversifier (2 Octets) Random Number (8 Octets)
@@ -4459,7 +4459,7 @@ New Signature Resolving Key Event } This event indicates that a new signature resolving key has been - generated for either the master or slave device. + generated for either the central or peripheral device. The Store_Hint parameter indicates whether the host is expected to store the key persistently or not.
Signature · 1 line
2.33.0.153.gba50c8fa24-goog