Skip to contentSkip to conversation

linux-next: build failure after merge of the cxl tree

PATCH Stephen Rothwell 2 participants 2 messages Sep 6, 2021 – Sep 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the cxl tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/nvdimm/label.c:750:32: error: 'uuid_to_nvdimm_cclass' defined but not used [-Werror=unused-function]
750 | static enum nvdimm_claim_class uuid_to_nvdimm_cclass(uuid_t *uuid)

      |                                ^~~~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors

Caused by commit

d68bc4b2338b ("libnvdimm/labels: Add address-abstraction uuid definitions")

Exposed by commit

3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")

I have applied the following patch for today.

From: Stephen Rothwell <[email protected]>
Date: Mon, 6 Sep 2021 14:14:52 +1000
Subject: [PATCH] cxl: mark unused function as such

---
 drivers/nvdimm/label.c | 1 +
 1 file changed, 1 insertion(+)
drivers/nvdimm/label.c +1 -0
index 7abeb1233404..175db14c7694 100644
@@ -747,6 +747,7 @@ static enum nvdimm_claim_class guid_to_nvdimm_cclass(guid_t *guid)
 }
 
 /* CXL labels store UUIDs instead of GUIDs for the same data */
+__maybe_unused
 static enum nvdimm_claim_class uuid_to_nvdimm_cclass(uuid_t *uuid)
 {
 	if (uuid_equal(uuid, &nvdimm_btt_uuid))
Signature · 5 lines
2.32.0

-- 
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 21 lines · Stephen Rothwell

Hi all,

After merging the cxl tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/nvdimm/label.c:750:32: error: 'uuid_to_nvdimm_cclass' defined but not used [-Werror=unused-function]
750 | static enum nvdimm_claim_class uuid_to_nvdimm_cclass(uuid_t *uuid)

      |                                ^~~~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors

Caused by commit

d68bc4b2338b ("libnvdimm/labels: Add address-abstraction uuid definitions")

Exposed by commit

3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")

I have applied the following patch for today.

Quoted 9 lines

From: Stephen Rothwell <[email protected]>
Date: Mon, 6 Sep 2021 14:14:52 +1000
Subject: [PATCH] cxl: mark unused function as such

---
 drivers/nvdimm/label.c | 1 +
 1 file changed, 1 insertion(+)

Thanks for that Stephen. I'll just back this patch out and retry for v5.16, it's not super critical.