vduse: missing error code in vduse_init()
Subsystems (2)
PATCH 1/1 vduse: missing error code in vduse_init()
This should return -ENOMEM if alloc_workqueue() fails. Currently it returns success.
Fixes b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vdpa/vdpa_user/vduse_dev.c +3 -1
@@ -1593,8 +1593,10 @@ static int vduse_init(void) vduse_irq_wq =alloc_workqueue ("vduse-irq" ,WQ_HIGHPRI |WQ_SYSFS |WQ_UNBOUND ,0 ); -if (!vduse_irq_wq) +if (!vduse_irq_wq) { + ret = -ENOMEM ; goto err_wq; + } ret =vduse_domain_init ();if (ret)
Signature · 1 line
2.20.1
Quoted 10 lines · Dan Carpenter
This should return
-ENOMEMifalloc_workqueue()fails. Currently it returns success.Fixes b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")Signed-off-by Dan Carpenter <[email protected]>--- drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Thank you for the fix.
Reviewed-by Xie Yongji <[email protected]>
Quoted 27 lines · Dan Carpenter
This should return
-ENOMEMifalloc_workqueue()fails. Currently it returns success.Fixes b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")Signed-off-by Dan Carpenter <[email protected]>--- drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/vdpa/vdpa_user/vduse_dev.c +3
-2@@ -1593,8 +1593,10 @@ static int vduse_init(void) vduse_irq_wq =alloc_workqueue ("vduse-irq" ,WQ_HIGHPRI |WQ_SYSFS |WQ_UNBOUND ,0 ); -if (!vduse_irq_wq) +if (!vduse_irq_wq) { + ret = -ENOMEM ; goto err_wq; + } ret =vduse_domain_init ();if (ret) --
Quoted 2 lines
2.20.1
Acked-by Jason Wang <[email protected]>