tpm/tpm_i2c_infineon: Fix init endian vendor check
Subsystems (2)
PATCH 1/1 tpm/tpm_i2c_infineon: Fix init endian vendor check
On my embedded system I use this tpm infineon chip via I2C. My system is a MIPS architecture and therefore works in big endian mode.
The problem is that the chip type is not recognised, because the vendor ID is incorrectly stored in memory.
By converting the vendor ID with ie32_to_cpus() to the correct format, the TPM chip is recognised by the driver and works as expected.
--- drivers/char/tpm/tpm_i2c_infineon.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/char/tpm/tpm_i2c_infineon.c +2 -0
@@ -638,6 +638,8 @@ static int tpm_tis_i2c_init(struct device *dev) goto out_release; } +le32_to_cpus (&vendor); +if (vendor ==TPM_TIS_I2C_DID_VID_9645 ) { tpm_dev.chip_type =SLB9645 ; }else if (vendor ==TPM_TIS_I2C_DID_VID_9635 ) {
Signature · 1 line
2.20.1
Jason Gunthorpe
reviewerQuoted 6 lines · Florian Eckert
On my embedded system I use this tpm infineon chip via I2C. My system is a MIPS architecture and therefore works in big endian mode.
The problem is that the chip type is not recognised, because the vendor ID is incorrectly stored in memory.
Quoted 7 lines
By converting the vendor ID with
ie32_to_cpus()to the correct format, the TPM chip is recognised by the driver and works as expected.Signed-off-by Florian Eckert <[email protected]>--- drivers/char/tpm/tpm_i2c_infineon.c | 2 ++ 1 file changed, 2 insertions(+)
vendor should be marked as a __le32 and so forth
Jason
Quoted 9 lines
Quoted 7 lines
By converting the vendor ID with
ie32_to_cpus()to the correct format, the TPM chip is recognised by the driver and works as expected.Signed-off-by Florian Eckert <[email protected]>--- drivers/char/tpm/tpm_i2c_infineon.c | 2 ++ 1 file changed, 2 insertions(+)vendor should be marked as a
__le32and so forth
Thanks for your feedback. I will push a v2.
Quoted 2 lines
Jason