Skip to contentSkip to conversation

ASoC: qcom: lpass-platform: Reset irq clear reg post handling interrupts

PATCH In review Srinivasa Rao Mandadapu 2 participants 3 messages Sep 8, 2021 – Sep 9, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: qcom: lpass-platform: Reset irq clear reg post handling interrupts

Update interrupt clear register with reset value after addressing all interrupts. This is to fix playback or capture hanging issue in simultaneous playback and capture usecase.

Fixes 4f629e4b8705f ("ASoC: qcom: Add ability to handle interrupts per dma channel")

---
Changes since v1:
-- Update comments Header information with fixes tag

 sound/soc/qcom/lpass-platform.c | 6 ++++++
 1 file changed, 6 insertions(+)
sound/soc/qcom/lpass-platform.c +6 -0
index f9df76d37858..1a0a4b0b1a03 100644
@@ -749,6 +749,12 @@ static irqreturn_t lpass_platform_lpaif_irq(int irq, void *data)
 		}
 	}
 
+	rv = regmap_write(drvdata->lpaif_map, LPAIF_IRQCLEAR_REG(v, LPAIF_IRQ_PORT_HOST), 0x0);
+	if (rv) {
+		pr_err("error writing to irqstat reg: %d\n", rv);
+		return IRQ_NONE;
+	}
+
 	return IRQ_HANDLED;
 }
 
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw
Quoted 3 lines · Srinivasa Rao Mandadapu

Update interrupt clear register with reset value after addressing all interrupts. This is to fix playback or capture hanging issue in simultaneous playback and capture usecase.

Could explain bit more about the issue.
Specifically which interrupt and which ports is this issue seen.

Quoted 16 lines
Fixes 4f629e4b8705f ("ASoC: qcom: Add ability to handle interrupts per dma channel")

---
Changes since v1:
-- Update comments Header information with fixes tag

  sound/soc/qcom/lpass-platform.c | 6 ++++++
  1 file changed, 6 insertions(+)
sound/soc/qcom/lpass-platform.c +0 -0
index f9df76d37858..1a0a4b0b1a03 100644

sound/soc/qcom/lpass-platform.c static irqreturn_t lpass_platform_lpaif_irq(int irq, void *data) · line 752

Quoted 4 lines
sound/soc/qcom/lpass-platform.c +1 -0
@@ -749,6 +749,12 @@ static irqreturn_t lpass_platform_lpaif_irq(int irq, void *data)
  		}
  	}
 
+	rv = regmap_write(drvdata->lpaif_map, LPAIF_IRQCLEAR_REG(v, LPAIF_IRQ_PORT_HOST), 0x0);

Writing 1 to a bit of this register will clear the corresponding latched interrupt. So I don't really understand how writing 0 is really helping here?

Do you have this patch in your tree?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/qcom/lpass-cpu.c?h=v5.14&id=6a7f5bd6185e1c86256d5e52c3bb7a4d390d6e19

--srini

Quoted 9 lines
sound/soc/qcom/lpass-platform.c +5 -0
+	if (rv) {
+		pr_err("error writing to irqstat reg: %d\n", rv);
+		return IRQ_NONE;
+	}
+
  	return IRQ_HANDLED;
  }
 
#2 lore raw

Thanks for Your time Srini!!

Quoted 9 lines · Srinivas Kandagatla
Quoted 3 lines · Srinivasa Rao Mandadapu

Update interrupt clear register with reset value after addressing all interrupts. This is to fix playback or capture hanging issue in simultaneous playback and capture usecase.

Could explain bit more about the issue.
Specifically which interrupt and which ports is this issue seen.

The test case is repeated test of simultaneous playback and capture on audio jack. i.e. 10 sec playback and 10 secs Capture.

i.e. sequence is Capture --> Playback, Capture -> Playback

In interrupt handler reading IRQ status reg and processing all the bits in loop. By the time loop ends in handler,

another capture interrupt is raised and it's never getting cleared and whole test case is getting hanged.

Quoted 12 lines
Quoted 12 lines
Fixes 4f629e4b8705f ("ASoC: qcom: Add ability to handle interrupts per dma channel")

---
Changes since v1:
     -- Update comments Header information with fixes tag

  sound/soc/qcom/lpass-platform.c | 6 ++++++

  1 file changed, 6 insertions(+)
Quoted 11 lines

sound/soc/qcom/lpass-platform.c static irqreturn_t lpass_platform_lpaif_irq(int · line 752

Quoted 9 lines
sound/soc/qcom/lpass-platform.c +0 -0
index f9df76d37858..1a0a4b0b1a03 100644
@@ -749,6 +749,12 @@ static irqreturn_t lpass_platform_lpaif_irq(int 
 irq, void *data)
           }
       }
   +    rv = regmap_write(drvdata->lpaif_map, LPAIF_IRQCLEAR_REG(v, LPAIF_IRQ_PORT_HOST), 0x0);

Writing 1 to a bit of this register will clear the corresponding latched interrupt. So I don't really understand how writing 0 is really helping here?

Yes. Your point is valid. But use-case passed with below patch and this change. will revert this change and check again with only below patch .

https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/ <https://www.google.com/url?q=https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/&sa=D&usg=AOvVaw3VEq8XuEI8cJkNpAxTm3d2>

Quoted 5 lines

Do you have this patch in your tree?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/qcom/lpass-cpu.c?h=v5.14&id=6a7f5bd6185e1c86256d5e52c3bb7a4d390d6e19

yes. This patch is available.

Quoted 10 lines

--srini

Quoted 8 lines
sound/soc/qcom/lpass-platform.c +5 -0
+    if (rv) {
+        pr_err("error writing to irqstat reg: %d\n", rv);
+        return IRQ_NONE;
+    }
+
       return IRQ_HANDLED;
   }
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.