dt-bindings: usb/qcom,dwc3: add ipq4019 compatible
Subsystems (3)
PATCH 1/2 dt-bindings: usb/qcom,dwc3: add ipq4019 compatible
Prequisite for getting rid of another warnings when building ipq4019.
--- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +1 -0
@@ -13,6 +13,7 @@ properties: compatible: items: - enum: + - qcom,ipq4019-dwc3 - qcom,msm8996-dwc3 - qcom,msm8998-dwc3 - qcom,sc7180-dwc3
Signature · 1 line
2.33.0
PATCH 2/2 ARM: dts: qcom: ipq4019: add dwc3 arch spec compatible
To be compilant with qcom,dwc3 definition
- add compatible
- rename dwc3@ to usb@
No functional changes intended.
--- arch/arm/boot/dts/qcom-ipq4019.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/qcom-ipq4019.dtsi +4 -4
@@ -637,7 +637,7 @@ usb3_hs_phy: hsphy@a6000 { }; usb3: usb3@8af8800 { - compatible = "qcom,dwc3"; + compatible = "qcom,ipq4019-dwc3", "qcom,dwc3"; reg = <0x8af8800 0x100>; #address-cells = <1>; #size-cells = <1>;
@@ -648,7 +648,7 @@ usb3: usb3@8af8800 { ranges; status = "disabled"; - dwc3@8a00000 { + usb@8a00000 { compatible = "snps,dwc3"; reg = <0x8a00000 0xf8000>; interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
@@ -669,7 +669,7 @@ usb2_hs_phy: hsphy@a8000 { }; usb2: usb2@60f8800 { - compatible = "qcom,dwc3"; + compatible = "qcom,ipq4019-dwc3", "qcom,dwc3"; reg = <0x60f8800 0x100>; #address-cells = <1>; #size-cells = <1>;
@@ -680,7 +680,7 @@ usb2: usb2@60f8800 { ranges; status = "disabled"; - dwc3@6000000 { + usb@6000000 { compatible = "snps,dwc3"; reg = <0x6000000 0xf8000>; interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.33.0
Re: [PATCH 2/2] ARM: dts: qcom: ipq4019: add dwc3 arch spec compatible
Quoted 25 lines · David Heidelberg
To be compilant with qcom,dwc3 definition
- add compatible
- rename dwc3@ to usb@No functional changes intended.
Signed-off-by David Heidelberg <[email protected]>--- arch/arm/boot/dts/qcom-ipq4019.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/qcom-ipq4019.dtsi +1
-1@@ -637,7 +637,7 @@ usb3_hs_phy: hsphy@a6000 { }; usb3: usb3@8af8800 { - compatible = "qcom,dwc3"; + compatible = "qcom,ipq4019-dwc3", "qcom,dwc3"; reg = <0x8af8800 0x100>; #address-cells = <1>; #size-cells = <1>;
arch/arm/boot/dts/qcom-ipq4019.dtsi usb3: usb3@8af8800 { · line 651
Quoted 5 lines
arch/arm/boot/dts/qcom-ipq4019.dtsi +1
-1@@ -648,7 +648,7 @@ usb3: usb3@8af8800 { ranges; status = "disabled"; - dwc3@8a00000 { + usb@8a00000 {
As noted in a recent discussion, this causes the UDC name exposed in sysfs to change. So even though it's contradicting the binding let's keep it unchanged for now.
The compatible part looks good though, so can you please respin this patch with that part only?
Thanks,
Bjorn
Quoted 24 lines
arch/arm/boot/dts/qcom-ipq4019.dtsi +2
-2compatible = "snps,dwc3"; reg = <0x8a00000 0xf8000>; interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;@@ -669,7 +669,7 @@ usb2_hs_phy: hsphy@a8000 { }; usb2: usb2@60f8800 { - compatible = "qcom,dwc3"; + compatible = "qcom,ipq4019-dwc3", "qcom,dwc3"; reg = <0x60f8800 0x100>; #address-cells = <1>; #size-cells = <1>;@@ -680,7 +680,7 @@ usb2: usb2@60f8800 { ranges; status = "disabled"; - dwc3@6000000 { + usb@6000000 { compatible = "snps,dwc3"; reg = <0x6000000 0xf8000>; interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerQuoted 22 lines · David Heidelberg
Prequisite for getting rid of another warnings when building ipq4019.
Signed-off-by David Heidelberg <[email protected]>--- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +1
-0@@ -13,6 +13,7 @@ properties: compatible: items: - enum: + - qcom,ipq4019-dwc3 - qcom,msm8996-dwc3 - qcom,msm8998-dwc3 - qcom,sc7180-dwc3Signature · 1 line
2.33.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Quoted 7 lines · David Heidelberg
Prequisite for getting rid of another warnings when building ipq4019.
Signed-off-by David Heidelberg <[email protected]>--- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 + 1 file changed, 1 insertion(+)