fs/ntfs3: Fix a memory leak on object opts
Subsystems (2)
PATCH 1/1 fs/ntfs3: Fix a memory leak on object opts
From: Colin Ian King <[email protected]>
Currently a failed allocation on sbi->upcase will cause an exit via the label free_sbi causing a memory leak on object opts. Fix this by re-ordering the exit paths free_opts and free_sbi so that kfree's occur in the reverse allocation order.
Addresses-Coverity: ("Resource leak")
--- fs/ntfs3/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ntfs3/super.c +2 -2
@@ -1450,10 +1450,10 @@ static int ntfs_init_fs_context(struct fs_context *fc) fc->ops = &ntfs_context_ops;return 0 ; -free_opts: -kfree (opts); free_sbi:kfree (sbi); +free_opts: +kfree (opts);return -ENOMEM ; }
Signature · 1 line
2.32.0
Quoted 11 lines · Colin King
From: Colin Ian King <[email protected]>
Currently a failed allocation on
sbi->upcasewill cause an exit via the labelfree_sbicausing a memory leak on object opts. Fix this by re-ordering the exit pathsfree_optsandfree_sbiso that kfree's occur in the reverse allocation order.Addresses-Coverity: ("Resource leak")
Fixes 27fac77707a1 ("fs/ntfs3: Init spi more in init_fs_context than fill_super")Signed-off-by Colin Ian King <[email protected]>---
Thanks Colin.
Quoted 23 lines
fs/ntfs3/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/ntfs3/super.c +2
-2@@ -1450,10 +1450,10 @@ static int ntfs_init_fs_context(struct fs_context *fc) fc->ops = &ntfs_context_ops;return 0 ; -free_opts: -kfree (opts); free_sbi:kfree (sbi); +free_opts: +kfree (opts);return -ENOMEM ; }Signature · 1 line
2.32.0
Konstantin Komarov
maintainerQuoted 37 lines · Kari Argillander
Quoted 11 lines · Colin King
From: Colin Ian King <[email protected]>
Currently a failed allocation on
sbi->upcasewill cause an exit via the labelfree_sbicausing a memory leak on object opts. Fix this by re-ordering the exit pathsfree_optsandfree_sbiso that kfree's occur in the reverse allocation order.Addresses-Coverity: ("Resource leak")
Fixes 27fac77707a1 ("fs/ntfs3: Init spi more in init_fs_context than fill_super")Signed-off-by Colin Ian King <[email protected]>---
Thanks Colin.
Reviewed-by Kari Argillander <[email protected]>Quoted 20 lines
fs/ntfs3/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/ntfs3/super.c +2
-2@@ -1450,10 +1450,10 @@ static int ntfs_init_fs_context(struct fs_context *fc) fc->ops = &ntfs_context_ops;return 0 ; -free_opts: -kfree (opts); free_sbi:kfree (sbi); +free_opts: +kfree (opts);return -ENOMEM ; }
Quoted 3 lines
Quoted 3 lines
Signature · 1 line
2.32.0
Hi, Colin, Kari!
Thanks for work - applied!