Add support for IDO-SBC2D06-V1B-22W
Subsystems (3)
Romain Perier
maintainercover Add support for IDO-SBC2D06-V1B-22W
IDO-SOM2D01 is an ultra-small SOM module based on SigmaStar SSD201/SSD202 SoC (ARM Cortex A7 core). The module integrates WIFI, NAND and PM circuits on a PCB area of 2.95CM x 2.95CM. The SoC integrates 128 MB of DDR3 on-chip.
IDO-SBC2D06-V1B-22W is an dual-ethernet SBC powered by a IDO-SOM2D01, that embeds a MicroSD card slot, 4-lane MIPI DSI connector for 4-inch RGB565 display or 7-inch RGB888 display, Dual 10/100M Ethernet ports, and more.
This series adds support for this SOM and this boards.
Romain Perier (4):
ARM: mstar: Mark timer with arm,cpu-registers-not-fw-configured
ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
dt-bindings: add vendor prefix for Wireless Tag
MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
.../devicetree/bindings/arm/mstar/mstar.yaml | 2 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 ++ MAINTAINERS | 1 + arch/arm/boot/dts/Makefile | 1 + ...star-infinity2m-ssd201-som2d01-common.dtsi | 21 ++++++++++++++ ...sd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts | 23 +++++++++++++++ ...ity2m-ssd202d-wirelesstag-ido-som2d01.dtsi | 28 +++++++++++++++++++ arch/arm/boot/dts/mstar-v7.dtsi | 1 + 8 files changed, 79 insertions(+) create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
Signature · 1 line
2.33.0
Romain Perier
maintainerPATCH 1/4 ARM: mstar: Mark timer with arm,cpu-registers-not-fw-configured
The vendor u-boot does not configure the arch timer correctly on MStar, let Linux do it.
--- arch/arm/boot/dts/mstar-v7.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/mstar-v7.dtsi +1 -0
@@ -39,6 +39,7 @@ arch_timer { * u-boot is broken */ clock-frequency = <6000000>; + arm,cpu-registers-not-fw-configured; }; pmu: pmu {
Signature · 1 line
2.33.0
Romain Perier
maintainerPATCH 2/4 ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
In reply to Romain PerierThe Wireless Tag IDO-SBC2D06-V1B-22W[1] is an SBC powered by SSD202D with a dual Ethernet and a connector for a 4-inch and 7-inch display. It embeds a System-On-Module IDO-SOM2D01[2] with an Mstar SSD202 SoC dual-core Cortex-A7 CPU @ 1.2Ghz , 2D GPU, 128 MB DDR3 (on-chip) and a 256MB SPI NAND flash. This commit adds basic definition for this board.
1. http://linux-chenxing.org/infinity2/ido-sbc2d06
2. http://www.wireless-tag.com/portfolio/ido-som2d01
--- .../devicetree/bindings/arm/mstar/mstar.yaml | 2 ++ arch/arm/boot/dts/Makefile | 1 + ...star-infinity2m-ssd201-som2d01-common.dtsi | 21 ++++++++++++++ ...sd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts | 23 +++++++++++++++ ...ity2m-ssd202d-wirelesstag-ido-som2d01.dtsi | 28 +++++++++++++++++++ 5 files changed, 75 insertions(+) create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
Documentation/devicetree/bindings/arm/mstar/mstar.yaml +2 -0
@@ -25,6 +25,8 @@ properties: - enum: - honestar,ssd201htv2 # Honestar SSD201_HT_V2 devkit - m5stack,unitv2 # M5Stack UnitV2 + - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01 + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W - const: mstar,infinity2m - description: infinity3 boards
arch/arm/boot/dts/Makefile +1 -0
@@ -1448,6 +1448,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \ dtb-$(CONFIG_ARCH_MILBEAUT) += milbeaut-m10v-evb.dtb dtb-$(CONFIG_ARCH_MSTARV7) += \ mstar-infinity-msc313-breadbee_crust.dtb \ + mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dtb \ mstar-infinity2m-ssd202d-ssd201htv2.dtb \ mstar-infinity2m-ssd202d-unitv2.dtb \ mstar-infinity3-msc313e-breadbee.dtb \
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi new file +21 -0
@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/ { + + reg_vcc_dram: regulator-vcc-dram { + compatible = "regulator-fixed"; + regulator-name = "vcc_dram"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + }; +}; + +&pm_uart { + status = "okay"; +};
arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts new file +23 -0
@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/dts-v1/; +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi" +#include <dt-bindings/gpio/gpio.h> + +/ { + model = "Wireless Tag IDO-SBC2D06-1VB-22W"; + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m"; + + leds { + compatible = "gpio-leds"; + sys_led { + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>; + linux,default-trigger = "heartbeat"; + }; + }; +};
arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi new file +28 -0
@@ -0,0 +1,28 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/dts-v1/; +#include "mstar-infinity2m-ssd202d.dtsi" +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi" + +/ { + model = "Wireless Tag IDO-SOM2D01 (SSD202D)"; + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m"; + + aliases { + serial0 = &pm_uart; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +®_vcc_dram { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; +};
Signature · 1 line
2.33.0
Re: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
Hi Romain,
Documentation/devicetree/bindings/arm/mstar/mstar.yaml properties: · line 29
Quoted 2 lines · Romain Perier
Documentation/devicetree/bindings/arm/mstar/mstar.yaml +2
-0+ - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01 + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
For anyone wondering why we have two strings here:
The SBC board is made up of a SoM and a board with the connectors. The SoM could be used standalone so we might as well have a compatible for it too.
We have some dtsis for the SoM but really those could be built as is to support someone using the SoM on it's own.
Quoted 1 line
+++
b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
For anyone wondering:
The som2d01 can come with an SSD201 (64MB DDR2 integrated) or SSD202D (128MB DDR3 integrated) and they need different fixed regulators for the DDR supply.
So we have a common dtsi and then override the regulator in another layer of dtsi for the SSD202D version.
Thinking about it now I think we can drop common from the file name.
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi line 9
Quoted 10 lines
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi new file +9
-0@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/ { +
Unneeded space.
Quoted 76 lines
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi new file +12
-0+ reg_vcc_dram: regulator-vcc-dram { + compatible = "regulator-fixed"; + regulator-name = "vcc_dram"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + }; +}; + +&pm_uart { + status = "okay"; +};arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts new file +23
-0@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/dts-v1/; +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi" +#include <dt-bindings/gpio/gpio.h> + +/ { + model = "Wireless Tag IDO-SBC2D06-1VB-22W"; + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m"; + + leds { + compatible = "gpio-leds"; + sys_led { + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>; + linux,default-trigger = "heartbeat"; + }; + }; +};arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi new file +28
-1@@ -0,0 +1,28 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/dts-v1/; +#include "mstar-infinity2m-ssd202d.dtsi" +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi" + +/ { + model = "Wireless Tag IDO-SOM2D01 (SSD202D)"; + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m"; + + aliases { + serial0 = &pm_uart; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +®_vcc_dram { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; +}; --
Quoted 2 lines
2.33.0
Cheers,
Daniel
Romain Perier
maintainerRe: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
Hi Daniel,
Ack, I will fix it (remove "common" from the file name and the unneeded space)
Thanks,
Romain
Quoted 121 lines · Daniel Palmer
Hi Romain,
Documentation/devicetree/bindings/arm/mstar/mstar.yaml properties: · line 29
Quoted 2 lines · Romain Perier
Documentation/devicetree/bindings/arm/mstar/mstar.yaml +2
-0+ - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01 + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22WFor anyone wondering why we have two strings here:
The SBC board is made up of a SoM and a board with the connectors. The SoM could be used standalone so we might as well have a compatible for it too.
We have some dtsis for the SoM but really those could be built as is to support someone using the SoM on it's own.Quoted 1 line
+++
b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsiFor anyone wondering:
The som2d01 can come with an SSD201 (64MB DDR2 integrated) or SSD202D (128MB DDR3 integrated) and they need different fixed regulators for the DDR supply.
So we have a common dtsi and then override the regulator in another layer of dtsi for the SSD202D version.Thinking about it now I think we can drop common from the file name.
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi line 9
Quoted 10 lines
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi new file +9
-0@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/ { +Unneeded space.
Quoted 76 lines
arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi new file +12
-0+ reg_vcc_dram: regulator-vcc-dram { + compatible = "regulator-fixed"; + regulator-name = "vcc_dram"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + }; +}; + +&pm_uart { + status = "okay"; +};arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts new file +23
-0@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/dts-v1/; +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi" +#include <dt-bindings/gpio/gpio.h> + +/ { + model = "Wireless Tag IDO-SBC2D06-1VB-22W"; + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m"; + + leds { + compatible = "gpio-leds"; + sys_led { + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>; + linux,default-trigger = "heartbeat"; + }; + }; +};arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi new file +28
-1@@ -0,0 +1,28 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright (c) 2021 thingy.jp. + * Author: Daniel Palmer <[email protected]> + * Author: Romain Perier <[email protected]> + */ + +/dts-v1/; +#include "mstar-infinity2m-ssd202d.dtsi" +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi" + +/ { + model = "Wireless Tag IDO-SOM2D01 (SSD202D)"; + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m"; + + aliases { + serial0 = &pm_uart; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +®_vcc_dram { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; +}; --Quoted 2 lines
2.33.0
Cheers,
Daniel
kernel test robot
build botRe: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
In reply to Romain PerierThank you for the patch! Yet something to improve:
Hi Romain,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on soc/for-next v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Romain-Perier/Add-support-for-IDO-SBC2D06-V1B-22W/20210911-030547 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-allyesconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f19e1d1a2916c299bd3d9bcc9b27be4986ce4f2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Romain-Perier/Add-support-for-IDO-SBC2D06-V1B-22W/20210911-030547 git checkout 4f19e1d1a2916c299bd3d9bcc9b27be4986ce4f2
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
Error: arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts:19.19-20 syntax error
>> FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botRe: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
In reply to Romain PerierThank you for the patch! Yet something to improve:
Hi Romain,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on soc/for-next v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Romain-Perier/Add-support-for-IDO-SBC2D06-V1B-22W/20210911-030547 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-allyesconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f19e1d1a2916c299bd3d9bcc9b27be4986ce4f2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Romain-Perier/Add-support-for-IDO-SBC2D06-V1B-22W/20210911-030547 git checkout 4f19e1d1a2916c299bd3d9bcc9b27be4986ce4f2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts:19.19-20 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Romain Perier
maintainerPATCH 3/4 dt-bindings: add vendor prefix for Wireless Tag
In reply to Romain PerierThis adds a vendor prefix for wireless tag boards and SOMs.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -517,6 +517,8 @@ patternProperties: description: International Business Machines (IBM) "^icplus,.*": description: IC Plus Corp. + "^wirelesstag,.*": + description: Wireless Tag (qiming yunduan) "^idt,.*": description: Integrated Device Technologies, Inc. "^ifi,.*":
Signature · 1 line
2.33.0
Re: [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag
Hi Romain,
Quoted 22 lines · Romain Perier
This adds a vendor prefix for wireless tag boards and SOMs.
Signed-off-by Romain Perier <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-1@@ -517,6 +517,8 @@ patternProperties: description: International Business Machines (IBM) "^icplus,.*": description: IC Plus Corp. + "^wirelesstag,.*": + description: Wireless Tag (qiming yunduan) "^idt,.*": description: Integrated Device Technologies, Inc. "^ifi,.*": --
Quoted 2 lines
2.33.0
This should be in alphabetical order.
Thanks,
Daniel
Re: [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag
In reply to Romain PerierHi Romain,
Sorry for sending this again. Gmail decided to switch to html email so the first version bounced from the mailing lists.
Quoted 22 lines · Romain Perier
This adds a vendor prefix for wireless tag boards and SOMs.
Signed-off-by Romain Perier <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-1@@ -517,6 +517,8 @@ patternProperties: description: International Business Machines (IBM) "^icplus,.*": description: IC Plus Corp. + "^wirelesstag,.*": + description: Wireless Tag (qiming yunduan) "^idt,.*": description: Integrated Device Technologies, Inc. "^ifi,.*": --
Quoted 2 lines
2.33.0
This should be in alphabetical order.
Also, this commit should be before adding the DT for the board I think. The prefix should be in before something that uses it.
Thanks,
Daniel
Romain Perier
maintainerRe: [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag
Hi Daniel,
Quoted 35 lines · Daniel Palmer
Hi Romain,
Sorry for sending this again. Gmail decided to switch to html email so the first version bounced from the mailing lists.Quoted 22 lines · Romain Perier
This adds a vendor prefix for wireless tag boards and SOMs.
Signed-off-by Romain Perier <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-1@@ -517,6 +517,8 @@ patternProperties: description: International Business Machines (IBM) "^icplus,.*": description: IC Plus Corp. + "^wirelesstag,.*": + description: Wireless Tag (qiming yunduan) "^idt,.*": description: Integrated Device Technologies, Inc. "^ifi,.*": --Quoted 2 lines
2.33.0
This should be in alphabetical order.
Also, this commit should be before adding the DT for the board I think. The prefix should be in before something that uses it.
Quoted 1 line
Thanks,
Ack, I will fix it.
Cheers,
Romain
Romain Perier
maintainerPATCH 4/4 MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
In reply to Romain PerierAs proposed by Daniel, I am going to help him to maintain the platform, so add myself as co-maintainer.
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -2231,6 +2231,7 @@ F: arch/arm/mach-pxa/mioa701.c ARM/MStar/Sigmastar Armv7 SoC support M: Daniel Palmer <[email protected]> +M: Romain Perier <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained W: http://linux-chenxing.org/
Signature · 1 line
2.33.0
Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
Hi Romain,
Quoted 22 lines · Romain Perier
As proposed by Daniel, I am going to help him to maintain the platform, so add myself as co-maintainer.
Signed-off-by Romain Perier <[email protected]>--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +1
-1@@ -2231,6 +2231,7 @@ F: arch/arm/mach-pxa/mioa701.c ARM/MStar/Sigmastar Armv7 SoC support M: Daniel Palmer <[email protected]> +M: Romain Perier <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained W: http://linux-chenxing.org/ --
Quoted 2 lines
2.33.0
For everyone else: For MStar/SigmaStar I have a ~350 commit backlog that makes almost everything work on these machines.
It's impossible for me to finish up working out the hardware and clean up and push patches without the whole process taking years. Romain stepped up to help out and has been pulling out patches, cleaning them up and pushing them. He deserves to be listed as a maintainer.
Cheers,
Daniel
Arnd Bergmann
maintainerRe: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
Quoted 25 lines · Daniel Palmer
Quoted 19 lines · Romain Perier
As proposed by Daniel, I am going to help him to maintain the platform, so add myself as co-maintainer.
Signed-off-by Romain Perier <[email protected]>---
MAINTAINERS +1
-1@@ -2231,6 +2231,7 @@ F: arch/arm/mach-pxa/mioa701.c ARM/MStar/Sigmastar Armv7 SoC support M: Daniel Palmer <[email protected]> +M: Romain Perier <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained W: http://linux-chenxing.org/ --Quoted 2 lines
2.33.0
Acked-by Daniel Palmer <[email protected]>
Quoted 7 lines
For everyone else: For MStar/SigmaStar I have a ~350 commit backlog that makes almost everything work on these machines.
It's impossible for me to finish up working out the hardware and clean up and push patches without the whole process taking years. Romain stepped up to help out and has been pulling out patches, cleaning them up and pushing them. He deserves to be listed as a maintainer.
Sounds good to me.
One process issue though: These emails were sent 'cc:[email protected]', so they end up in patchwork, but I'm guessing they were not actually meant for us to apply from there. I'm happy to take merge these patches (or a future version of the series) directly from patchwork if that's what you both had in mind, but for clarity please either
a) drop [email protected] from Cc for patches that are meant for review and will be part of a pull request.
or
b) put [email protected] in the 'to:' field after they have been reviewed and you want them to get merged.
Or even better, add an explicit sentence below the '---' line asking for the patches to be merged directly into the soc tree when this is what you want.
FWIW, I'd suggest merging the MAINTAINERS file change as a bugfix for 5.15, it's generally better to do these as early as possible to make sure any patches reach all the right people.
Arnd
Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
Hi Arnd,
Quoted 8 lines · Arnd Bergmann
Sounds good to me.
One process issue though: These emails were sent 'cc:[email protected]', so they end up in patchwork, but I'm guessing they were not actually meant for us to apply from there. I'm happy to take merge these patches (or a future version of the series) directly from patchwork if that's what you both had in mind, but for clarity please either
Quoted 7 lines
a) drop [email protected] from Cc for patches that are meant for review and will be part of a pull request.
or
b) put [email protected] in the 'to:' field after they have been reviewed and you want them to get merged.
Noted for the future. Until now we haven't done pull requests so having the patches go into the soc patchwork made sense but from now on we'll send pull requests when needed to you and Olof for the ARM specific bits. Which I don't think there will be much aside from dts stuff.
Quoted 3 lines
Or even better, add an explicit sentence below the '---' line asking for the patches to be merged directly into the soc tree when this is what you want.
Noted.
Quoted 3 lines
FWIW, I'd suggest merging the
MAINTAINERSfile change as a bugfix for 5.15, it's generally better to do these as early as possible to make sure any patches reach all the right people.
That makes sense.
Would it be possible for you to merge that single commit for me? Seems like that would be easier than me creating a fixes branch for a single commit, sending you a PR, finding out I still don't actually know how to do PR properly.. :)
If it's a hassle I'll do the PR though.
Cheers,
Daniel
Arnd Bergmann
maintainerRe: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
Quoted 8 lines · Daniel Palmer
Quoted 3 lines · Arnd Bergmann
FWIW, I'd suggest merging the
MAINTAINERSfile change as a bugfix for 5.15, it's generally better to do these as early as possible to make sure any patches reach all the right people.That makes sense.
Would it be possible for you to merge that single commit for me?
Done, merged into arm/fixes.
Quoted 4 lines
Seems like that would be easier than me creating a fixes branch for a single commit, sending you a PR, finding out I still don't actually know how to do PR properly.. :)
If it's a hassle I'll do the PR though.
If you only have one or two patches, sending that patch to [email protected] is usually the easiest way anyway, unless there is a reason to keep the branch description separate from the patch description in the git log.
Arnd
Romain Perier
maintainerRe: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
Hi,
Thank you very much and sorry for the wrong inclusion of [email protected], it's noted for the next time.
Regards,
Romain
Quoted 23 lines · Arnd Bergmann
Quoted 8 lines · Daniel Palmer
Quoted 3 lines · Arnd Bergmann
FWIW, I'd suggest merging the
MAINTAINERSfile change as a bugfix for 5.15, it's generally better to do these as early as possible to make sure any patches reach all the right people.That makes sense.
Would it be possible for you to merge that single commit for me?Done, merged into arm/fixes.
Quoted 4 lines
Seems like that would be easier than me creating a fixes branch for a single commit, sending you a PR, finding out I still don't actually know how to do PR properly.. :)
If it's a hassle I'll do the PR though.If you only have one or two patches, sending that patch to [email protected] is usually the easiest way anyway, unless there is a reason to keep the branch description separate from the patch description in the git log.
Arnd