media: atomisp: fix control reaches end of non-void function error
Subsystems (4)
PATCH 1/1 media: atomisp: fix control reaches end of non-void function error
Fix the following build error with -Werror=return-type enabled. Fix input_system_configure_channel_sensor() to return status when control reaches the end.
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
1649 | }
--- .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c +1 -0
@@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(default :return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED ; } +return status; }// Test flags and set structure.
Signature · 1 line
2.30.2
Quoted 10 lines · Shuah Khan
Fix the following build error with -Werror=return-type enabled. Fix
input_system_configure_channel_sensor()to return status when control reaches the end.
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.odrivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
1649 | }Signed-off-by Shuah Khan <[email protected]>
Hi Shuah,
You're the third person to send this patch recently but it was fixed on Aug 2 in staging-next in commit 05344a1d2ea7 ("media: atomisp: restore missing 'return' statement"). What tree are you working against? It seems like it needs to be backported somewhere.
regards,
dan carpenter
Quoted 10 lines · Dan Carpenter
Quoted 9 lines · Shuah Khan
Fix the following build error with -Werror=return-type enabled. Fix
input_system_configure_channel_sensor()to return status when control reaches the end.
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.odrivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
1649 | }
Quoted 9 lines
Quoted 1 line
Signed-off-by Shuah Khan <[email protected]>Hi Shuah,
You're the third person to send this patch recently but it was fixed on Aug 2 in staging-next in commit
05344a1d2ea7("media: atomisp: restore missing 'return' statement"). What tree are you working against? It seems like it needs to be backported somewhere.
I am working on Linux 5.15 - should have checked staging next though before sending the patch :)
thanks,
-- Shuah