Skip to contentSkip to conversation

Add SIMATIC IOT2050 board support

PATCH Superseded Jan Kiszka 3 participants 16 messages Aug 3, 2021 – Sep 13, 2021

Subsystems (3)

v7 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

v7 cover Add SIMATIC IOT2050 board support

This is the baseline support for the SIMATIC IOT2050 devices.

Changes in v7:
- rebased
- registered board doc with index

Changes in v6:
- rebased
- converted board README to docs/board/siemens/iot2050.rst

Changes in v5:
- rebased
- use DEFAULT_LINUX_BOOT_ENV from ti_armv7_common.h, rather than home-grown values
- avoids misaligned kernel load address
- no longer exposes issue around LMB reservations

Changes in v4:
- rebased
- make rtd-wdt firmware a "loadable" inside U-Boot proper fit image, avoiding controversial embedding as object
- improved mmc1 removal from boot_targets
- fixed various build issues

Changes in v3:
- rebased
- addressed several checkpatch warnings
- a few #ifdef -> IS_ENABLED conversions
- comment marker for SPDK identifier in .S file
- trailing whitespaces
- factored out rti_wdt_load_fw (less #ifdef)

Changes in v2:
- rebased
- sync with upstream-accepted DT
- add boot switch
- include watchdog support

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

A staging tree for complete IOT2050 support can be found at [1]. Full image integration is available via [2].

Jan

[1] https://github.com/siemens/u-boot/commits/jan/iot2050
[2] https://github.com/siemens/meta-iot2050

Jan Kiszka (5):
arm: dts: Add IOT2050 device tree files
board: siemens: Add support for SIMATIC IOT2050 devices
arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry
watchdog: rti_wdt: Add support for loading firmware
iot2050: Enable watchdog support, but do not auto-start it

 arch/arm/dts/Makefile                         |   7 +-
 arch/arm/dts/k3-am65-iot2050-boot-image.dtsi  | 121 ++++
 .../dts/k3-am65-iot2050-common-u-boot.dtsi    | 103 +++
 arch/arm/dts/k3-am65-iot2050-common.dtsi      | 655 ++++++++++++++++++
 arch/arm/dts/k3-am65-iot2050-spl.dts          |  16 +
 arch/arm/dts/k3-am65-mcu.dtsi                 |   9 +
 arch/arm/dts/k3-am6528-iot2050-basic.dts      |  67 ++
 arch/arm/dts/k3-am6548-iot2050-advanced.dts   |  66 ++
 arch/arm/mach-k3/Kconfig                      |   1 +
 board/siemens/iot2050/Kconfig                 |  32 +
 board/siemens/iot2050/MAINTAINERS             |   9 +
 board/siemens/iot2050/Makefile                |  10 +
 board/siemens/iot2050/board.c                 | 284 ++++++++
 board/siemens/iot2050/config.mk               |   8 +
 configs/iot2050_defconfig                     | 138 ++++
 doc/board/index.rst                           |   1 +
 doc/board/siemens/index.rst                   |   9 +
 doc/board/siemens/iot2050.rst                 |  76 ++
 drivers/watchdog/Kconfig                      |  20 +
 drivers/watchdog/rti_wdt.c                    |  88 +++
 include/configs/iot2050.h                     |  62 ++
 21 files changed, 1781 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
 create mode 100644 arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
 create mode 100644 arch/arm/dts/k3-am65-iot2050-common.dtsi
 create mode 100644 arch/arm/dts/k3-am65-iot2050-spl.dts
 create mode 100644 arch/arm/dts/k3-am6528-iot2050-basic.dts
 create mode 100644 arch/arm/dts/k3-am6548-iot2050-advanced.dts
 create mode 100644 board/siemens/iot2050/Kconfig
 create mode 100644 board/siemens/iot2050/MAINTAINERS
 create mode 100644 board/siemens/iot2050/Makefile
 create mode 100644 board/siemens/iot2050/board.c
 create mode 100644 board/siemens/iot2050/config.mk
 create mode 100644 configs/iot2050_defconfig
 create mode 100644 doc/board/siemens/index.rst
 create mode 100644 doc/board/siemens/iot2050.rst
 create mode 100644 include/configs/iot2050.h
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v7 1/5 arm: dts: Add IOT2050 device tree files

From: Jan Kiszka <[email protected]>

Prepares for the addition of the IOT2050 board which is based on the TI AM65x. The board comes in two variants, Basic and Advanced, so there are separate dts files. Furthermore, the SPL has its own device tree.

Based on original board support by Le Jin, Gao Nian and Chao Zeng.

---
 arch/arm/dts/Makefile                         |   7 +-
 arch/arm/dts/k3-am65-iot2050-boot-image.dtsi  | 105 +++
 .../dts/k3-am65-iot2050-common-u-boot.dtsi    | 103 +++
 arch/arm/dts/k3-am65-iot2050-common.dtsi      | 655 ++++++++++++++++++
 arch/arm/dts/k3-am65-iot2050-spl.dts          |  16 +
 arch/arm/dts/k3-am6528-iot2050-basic.dts      |  67 ++
 arch/arm/dts/k3-am6548-iot2050-advanced.dts   |  66 ++
 7 files changed, 1018 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
 create mode 100644 arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
 create mode 100644 arch/arm/dts/k3-am65-iot2050-common.dtsi
 create mode 100644 arch/arm/dts/k3-am65-iot2050-spl.dts
 create mode 100644 arch/arm/dts/k3-am6528-iot2050-basic.dts
 create mode 100644 arch/arm/dts/k3-am6548-iot2050-advanced.dts
arch/arm/dts/Makefile +6 -1
index 537c96bf5b..08aa3c09f8 100644
@@ -1084,7 +1084,12 @@ dtb-$(CONFIG_STM32MP15x) += \
 	stm32mp15xx-dhcom-picoitx.dtb \
 	stm32mp15xx-dhcor-avenger96.dtb
 
-dtb-$(CONFIG_SOC_K3_AM6) += k3-am654-base-board.dtb k3-am654-r5-base-board.dtb
+dtb-$(CONFIG_SOC_K3_AM6) += \
+	k3-am654-base-board.dtb \
+	k3-am654-r5-base-board.dtb \
+	k3-am65-iot2050-spl.dtb \
+	k3-am6528-iot2050-basic.dtb \
+	k3-am6548-iot2050-advanced.dtb
 dtb-$(CONFIG_SOC_K3_J721E) += k3-j721e-common-proc-board.dtb \
 			      k3-j721e-r5-common-proc-board.dtb \
 			      k3-j7200-common-proc-board.dtb \
arch/arm/dts/k3-am65-iot2050-boot-image.dtsi new file +105 -0

105 lines not on this page · raw message

arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi new file +103 -0

103 lines not on this page · raw message

arch/arm/dts/k3-am65-iot2050-common.dtsi new file +655 -0

655 lines not on this page · raw message

arch/arm/dts/k3-am65-iot2050-spl.dts new file +16 -0
new file mode 100644
index 0000000000..b6bd148fd3
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) Siemens AG, 2018-2021
+ *
+ * Authors:
+ *   Jan Kiszka <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "k3-am65-iot2050-common-u-boot.dtsi"
+
+/ {
+	compatible = "siemens,iot2050", "ti,am654";
+	model = "Siemens IOT2050";
+};
arch/arm/dts/k3-am6528-iot2050-basic.dts new file +67 -0

67 lines not on this page · raw message

arch/arm/dts/k3-am6548-iot2050-advanced.dts new file +66 -0

66 lines not on this page · raw message

Signature · 1 line
2.31.1
author
#2 lore raw

PATCH v7 2/5 board: siemens: Add support for SIMATIC IOT2050 devices

In reply to Jan Kiszka

From: Jan Kiszka <[email protected]>

This adds support for the IOT2050 Basic and Advanced devices. The Basic used the dual-core AM6528 GP processor, the Advanced one the AM6548 HS quad-core version.

Both variants are booted via a Siemens-provided FSBL that runs on the R5 cores. Consequently, U-Boot support is targeting the A53 cores. U-Boot SPL, ATF and TEE have to reside in SPI flash.

Full integration into a bootable image can be found on
https://github.com/siemens/meta-iot2050

Based on original board support by Le Jin, Gao Nian and Chao Zeng.

---
 arch/arm/mach-k3/Kconfig          |   1 +
 board/siemens/iot2050/Kconfig     |  32 ++++
 board/siemens/iot2050/MAINTAINERS |   9 +
 board/siemens/iot2050/Makefile    |  10 ++
 board/siemens/iot2050/board.c     | 284 ++++++++++++++++++++++++++++++
 board/siemens/iot2050/config.mk   |   8 +
 configs/iot2050_defconfig         | 132 ++++++++++++++
 doc/board/index.rst               |   1 +
 doc/board/siemens/index.rst       |   9 +
 doc/board/siemens/iot2050.rst     |  76 ++++++++
 include/configs/iot2050.h         |  62 +++++++
 11 files changed, 624 insertions(+)
 create mode 100644 board/siemens/iot2050/Kconfig
 create mode 100644 board/siemens/iot2050/MAINTAINERS
 create mode 100644 board/siemens/iot2050/Makefile
 create mode 100644 board/siemens/iot2050/board.c
 create mode 100644 board/siemens/iot2050/config.mk
 create mode 100644 configs/iot2050_defconfig
 create mode 100644 doc/board/siemens/index.rst
 create mode 100644 doc/board/siemens/iot2050.rst
 create mode 100644 include/configs/iot2050.h
arch/arm/mach-k3/Kconfig +1 -0
index fa8d134b42..526f5f8b76 100644
@@ -168,4 +168,5 @@ config K3_DM_FW
 source "board/ti/am65x/Kconfig"
 source "board/ti/am64x/Kconfig"
 source "board/ti/j721e/Kconfig"
+source "board/siemens/iot2050/Kconfig"
 endif
board/siemens/iot2050/Kconfig new file +32 -0
new file mode 100644
index 0000000000..8f634c172c
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) Siemens AG, 2018-2021
+#
+# Authors:
+#   Le Jin <[email protected]>
+#   Jan Kiszka <[email protected]>
+
+config TARGET_IOT2050_A53
+	bool "IOT2050 running on A53"
+	select ARM64
+	select SOC_K3_AM6
+	select BOARD_LATE_INIT
+	select SYS_DISABLE_DCACHE_OPS
+	select BINMAN
+
+if TARGET_IOT2050_A53
+
+config SYS_BOARD
+	default "iot2050"
+
+config SYS_VENDOR
+	default "siemens"
+
+config SYS_CONFIG_NAME
+	default "iot2050"
+
+config IOT2050_BOOT_SWITCH
+	bool "Disable eMMC boot via USER button (Advanced version only)"
+	default y
+
+endif
board/siemens/iot2050/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..1b525356c2
@@ -0,0 +1,9 @@
+IOT2050 BOARD
+M:	Le Jin <[email protected]>
+M:	Jan Kiszka <[email protected]>
+S:	Maintained
+F:	board/siemens/iot2050/
+F:	include/configs/iot2050.h
+F:	configs/iot2050_defconfig
+F:	arch/arm/dts/iot2050-*
+F:	doc/board/siemens/iot2050.rst
board/siemens/iot2050/Makefile new file +10 -0
new file mode 100644
index 0000000000..619594ab8e
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Makefile for Siemens IOT2050 board
+# Copyright (c) Siemens AG, 2018-2021
+#
+# Authors:
+#   Le Jin <[email protected]>
+#
+
+obj-y += board.o
board/siemens/iot2050/board.c new file +284 -0

284 lines not on this page · raw message

board/siemens/iot2050/config.mk new file +8 -0
new file mode 100644
index 0000000000..267ec76c4e
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) Siemens AG, 2020-2021
+#
+# Authors:
+#   Jan Kiszka <[email protected]>
+
+flash.bin: all
configs/iot2050_defconfig new file +132 -0

132 lines not on this page · raw message

doc/board/index.rst +1 -0
index 9e90978891..9baa01e519 100644
@@ -22,6 +22,7 @@ Board-specific doc
    openpiton/index
    qualcomm/index
    rockchip/index
+   siemens/index
    sifive/index
    sipeed/index
    socionext/index
doc/board/siemens/index.rst new file +9 -0
new file mode 100644
index 0000000000..082936ea7e
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Siemens
+=======
+
+.. toctree::
+   :maxdepth: 2
+
+   iot2050
doc/board/siemens/iot2050.rst new file +76 -0

76 lines not on this page · raw message

include/configs/iot2050.h new file +62 -0

62 lines not on this page · raw message

Signature · 1 line
2.31.1
author
#3 lore raw

PATCH v7 3/5 arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry

In reply to Jan Kiszka

From: Jan Kiszka <[email protected]>

Add the DT entry for a watchdog based on RTI1. It requires additional firmware on the MCU R5F cores to handle the expiry, e.g.
https://github.com/siemens/k3-rti-wdt. As this firmware will also lock the power domain to protect it against premature shutdown, mark it shared.

Aligns us to the kernel's DT in this regard.

---
 arch/arm/dts/k3-am65-mcu.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/dts/k3-am65-mcu.dtsi +9 -0
index 7454c8cec0..903796bf7d 100644
@@ -308,4 +308,13 @@
 			ti,loczrama = <1>;
 		};
 	};
+
+	mcu_rti1: rti@40610000 {
+		compatible = "ti,j7-rti-wdt";
+		reg = <0x0 0x40610000 0x0 0x100>;
+		clocks = <&k3_clks 135 0>;
+		power-domains = <&k3_pds 135 TI_SCI_PD_SHARED>;
+		assigned-clocks = <&k3_clks 135 0>;
+		assigned-clock-parents = <&k3_clks 135 4>;
+	};
 };
Signature · 1 line
2.31.1
author
#4 lore raw

PATCH v7 4/5 watchdog: rti_wdt: Add support for loading firmware

In reply to Jan Kiszka

From: Jan Kiszka <[email protected]>

To avoid the need of extra boot scripting on AM65x for loading a watchdog firmware, add the required rproc init and loading logic for the first R5F core to the watchdog start handler. In case the R5F cluster is in lock-step mode, also initialize the second core. The firmware itself is embedded into U-Boot binary to ease access to it and ensure it is properly hashed in case of secure boot.

One possible firmware source is https://github.com/siemens/k3-rti-wdt.

The board is responsible for providing the firmware as additional loadable via the U-Boot fit image. The driver will pick up its location from /fit-images/k3-rti-wdt-firmware then.

---
 drivers/watchdog/Kconfig   | 20 +++++++++
 drivers/watchdog/rti_wdt.c | 88 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 108 insertions(+)
drivers/watchdog/Kconfig +20 -0
index f0ff2612a6..1a1fddfe9f 100644
@@ -209,6 +209,26 @@ config WDT_K3_RTI
 	  Say Y here if you want to include support for the K3 watchdog
 	  timer (RTI module) available in the K3 generation of processors.
 
+if WDT_K3_RTI
+
+config WDT_K3_RTI_LOAD_FW
+	bool "Load watchdog firmware"
+	depends on REMOTEPROC
+	help
+	  Automatically load the specified firmware image into the MCU R5F
+	  core 0. On the AM65x, this firmware is supposed to handle the expiry
+	  of the watchdog timer, typically by resetting the system.
+
+config WDT_K3_RTI_FW_FILE
+	string "Watchdog firmware image file"
+	default "k3-rti-wdt.fw"
+	depends on WDT_K3_RTI_LOAD_FW
+	help
+	  Firmware image to be embedded into U-Boot and loaded on watchdog
+	  start.
+
+endif
+
 config WDT_SANDBOX
 	bool "Enable Watchdog Timer support for Sandbox"
 	depends on SANDBOX && WDT
drivers/watchdog/rti_wdt.c +88 -0

109 lines not on this page · raw message

Signature · 1 line
2.31.1
author
#5 lore raw

PATCH v7 5/5 iot2050: Enable watchdog support, but do not auto-start it

In reply to Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

---
 arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 16 ++++++++++++++++
 configs/iot2050_defconfig                    |  6 ++++++
 2 files changed, 22 insertions(+)
arch/arm/dts/k3-am65-iot2050-boot-image.dtsi +16 -0
index 61745c6c23..8e3f1709e9 100644
@@ -59,6 +59,16 @@
 						filename = "arch/arm/dts/k3-am6548-iot2050-advanced.dtb";
 					};
 				};
+
+#ifdef CONFIG_WDT_K3_RTI_FW_FILE
+				k3-rti-wdt-firmware {
+					type = "blob";
+					load = <0x82000000>;
+					blob {
+						filename = CONFIG_WDT_K3_RTI_FW_FILE;
+					};
+				};
+#endif
 			};
 
 			configurations {
@@ -68,12 +78,18 @@
 					description = "iot2050-basic";
 					firmware = "u-boot";
 					fdt = "fdt-iot2050-basic";
+#ifdef CONFIG_WDT_K3_RTI_FW_FILE
+					loadables = "k3-rti-wdt-firmware";
+#endif
 				};
 
 				conf-iot2050-advanced {
 					description = "iot2050-advanced";
 					firmware = "u-boot";
 					fdt = "fdt-iot2050-advanced";
+#ifdef CONFIG_WDT_K3_RTI_FW_FILE
+					loadables = "k3-rti-wdt-firmware";
+#endif
 				};
 			};
 		};
configs/iot2050_defconfig +6 -0
index 6af8971aa5..b30483f73b 100644
@@ -51,6 +51,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_PCI=y
 CONFIG_CMD_REMOTEPROC=y
 CONFIG_CMD_USB=y
+CONFIG_CMD_WDT=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
 # CONFIG_ISO_PARTITION is not set
@@ -129,4 +130,9 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
 CONFIG_USB_KEYBOARD=y
+# CONFIG_WATCHDOG is not set
+# CONFIG_WATCHDOG_AUTOSTART is not set
+CONFIG_WDT=y
+CONFIG_WDT_K3_RTI=y
+CONFIG_WDT_K3_RTI_LOAD_FW=y
 CONFIG_OF_LIBFDT_OVERLAY=y
Signature · 1 line
2.31.1
#6 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050') +(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2

    0    0    1 /1              iot2050

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

Signature · 1 line
Tom
author
#7 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
#8 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 20 lines · Jan Kiszka
Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 7 lines
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use /dev/null in that case and try and make it clear it won't boot. K3 isn't a good example here, but I think sunxi uses binman and handles this same class of problem?

Signature · 1 line
Tom
author
#9 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 31 lines · Tom Rini
Quoted 20 lines · Jan Kiszka
Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 7 lines
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 8 lines
Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use /dev/null in that case and try and make it clear it won't boot. K3 isn't a good example here, but I think sunxi uses binman and handles this same class of problem?

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for that image, but even reading the code gives no clue yet how to achieve that. Yet another binman mystery.

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
#10 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 41 lines · Jan Kiszka
Quoted 31 lines · Tom Rini
Quoted 20 lines · Jan Kiszka
Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 7 lines
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 8 lines
Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use /dev/null in that case and try and make it clear it won't boot. K3 isn't a good example here, but I think sunxi uses binman and handles this same class of problem?

Quoted 5 lines

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for that image, but even reading the code gives no clue yet how to achieve that. Yet another binman mystery.

You might also need a new file in tools/binman/etype/ ? Also, it will have a non-zero exit status still, but with a value of 101 which we check for and know that's "binary blob missing" and so OK to allow CI to pass on.

Signature · 1 line
Tom
author
#11 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 48 lines · Tom Rini
Quoted 41 lines · Jan Kiszka
Quoted 31 lines · Tom Rini
Quoted 20 lines · Jan Kiszka
Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 7 lines
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 8 lines
Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use /dev/null in that case and try and make it clear it won't boot. K3 isn't a good example here, but I think sunxi uses binman and handles this same class of problem?

Quoted 5 lines

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for that image, but even reading the code gives no clue yet how to achieve that. Yet another binman mystery.

Quoted 5 lines

You might also need a new file in tools/binman/etype/ ? Also, it will have a non-zero exit status still, but with a value of 101 which we check for and know that's "binary blob missing" and so OK to allow CI to pass on.

Err, that doesn't sound like binman is making my life easier. Why can't a I simple do something like

	k3-rti-wdt-firmware {
		type = "blob";
		load = <0x82000000>;
		blob {
			filename = CONFIG_WDT_K3_RTI_FW_FILE;
			missing-msg = "k3-rti-wdt-firmware";
			allow_missing;
		};
	};

and be done?

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
#12 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 68 lines · Jan Kiszka
Quoted 48 lines · Tom Rini
Quoted 41 lines · Jan Kiszka
Quoted 31 lines · Tom Rini
Quoted 20 lines · Jan Kiszka
Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 7 lines
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 8 lines
Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use /dev/null in that case and try and make it clear it won't boot. K3 isn't a good example here, but I think sunxi uses binman and handles this same class of problem?

Quoted 5 lines

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for that image, but even reading the code gives no clue yet how to achieve that. Yet another binman mystery.

Quoted 5 lines

You might also need a new file in tools/binman/etype/ ? Also, it will have a non-zero exit status still, but with a value of 101 which we check for and know that's "binary blob missing" and so OK to allow CI to pass on.

Err, that doesn't sound like binman is making my life easier. Why can't a I simple do something like

	k3-rti-wdt-firmware {
		type = "blob";
		load = <0x82000000>;
		blob {
			filename = CONFIG_WDT_K3_RTI_FW_FILE;
			missing-msg = "k3-rti-wdt-firmware";
			allow_missing;
		};
	};
Quoted 1 line

and be done?

Sounds like a good idea, and I'm not quite sure what's missing to go from where we are today to there. I might be missing something myself.

Signature · 1 line
Tom
#13 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 82 lines · Tom Rini
Quoted 10 lines · Jan Kiszka
Quoted 9 lines · Tom Rini
Quoted 8 lines · Jan Kiszka
Quoted 7 lines · Tom Rini
Quoted 6 lines · Jan Kiszka
Quoted 5 lines · Tom Rini
Quoted 3 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not

enforce

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines

that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary

is non-functional

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might

be non-functional

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input

path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
(quoted diff) +2 -0
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050

And needs to be handled like ATF/OPTEE/etc where CI can build but

throw

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even

have

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 2 lines

support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use

/dev/null

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

in that case and try and make it clear it won't boot. K3 isn't a

good

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

example here, but I think sunxi uses binman and handles this same

class

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

of problem?

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for

that

Quoted 1 line
Quoted 1 line
Quoted 1 line

image, but even reading the code gives no clue yet how to achieve

that.

Quoted 5 lines
Quoted 5 lines
Quoted 1 line

Yet another binman mystery.

You might also need a new file in tools/binman/etype/ ? Also, it will have a non-zero exit status still, but with a value of 101 which we check for and know that's "binary blob missing" and so OK to allow CI

to

Quoted 16 lines
Quoted 2 lines

pass on.

Err, that doesn't sound like binman is making my life easier. Why can't a I simple do something like

      k3-rti-wdt-firmware {
              type = "blob";
              load = <0x82000000>;
              blob {
                      filename = CONFIG_WDT_K3_RTI_FW_FILE;
                      missing-msg = "k3-rti-wdt-firmware";
                      allow_missing;
              };
      };
Quoted 5 lines
Quoted 1 line

and be done?

Sounds like a good idea, and I'm not quite sure what's missing to go from where we are today to there. I might be missing something myself.

If that entry is located in a DT for U-Boot consumption why not, but in the DT that is associated to a platform that is passed to the OS, that sounds like a practice to avoid as this does not describe hardware. Thinking compatibility, is the filename/filepath really OS independent ?

Quoted 4 lines

--
Tom

Signature · 3 lines
François-Frédéric Ozog | *Director Business Development*
T: +33.67221.6485
[email protected] | Skype: ffozog
#14 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

Quoted 86 lines · François Ozog
Quoted 84 lines · Tom Rini
Quoted 10 lines · Jan Kiszka
Quoted 9 lines · Tom Rini
Quoted 8 lines · Jan Kiszka
Quoted 7 lines · Tom Rini
Quoted 6 lines · Jan Kiszka
Quoted 5 lines · Tom Rini
Quoted 3 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not

enforce

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines

that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary

is non-functional

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might

be non-functional

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input

path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
(quoted diff) +2 -0
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050

And needs to be handled like ATF/OPTEE/etc where CI can build but

throw

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even

have

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 2 lines

support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use

/dev/null

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

in that case and try and make it clear it won't boot. K3 isn't a

good

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

example here, but I think sunxi uses binman and handles this same

class

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

of problem?

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for

that

Quoted 1 line
Quoted 1 line
Quoted 1 line

image, but even reading the code gives no clue yet how to achieve

that.

Quoted 5 lines
Quoted 5 lines
Quoted 1 line

Yet another binman mystery.

You might also need a new file in tools/binman/etype/ ? Also, it will have a non-zero exit status still, but with a value of 101 which we check for and know that's "binary blob missing" and so OK to allow CI

to

Quoted 17 lines
Quoted 2 lines

pass on.

Err, that doesn't sound like binman is making my life easier. Why can't a I simple do something like

      k3-rti-wdt-firmware {
              type = "blob";
              load = <0x82000000>;
              blob {
                      filename = CONFIG_WDT_K3_RTI_FW_FILE;
                      missing-msg = "k3-rti-wdt-firmware";
                      allow_missing;
              };
      };

and be done?

Quoted 8 lines
Quoted 3 lines

Sounds like a good idea, and I'm not quite sure what's missing to go from where we are today to there. I might be missing something myself.

If that entry is located in a DT for U-Boot consumption why not, but in the DT that is associated to a platform that is passed to the OS, that sounds like a practice to avoid as this does not describe hardware. Thinking compatibility, is the filename/filepath really OS independent ?

So, here's one of those cases where we aren't really talking about the runtime device tree so much as how we configure the build. binman is how we assemble the assorted binaries in to a functional blob for a given platform without having to write a new tool for every SoC.

Signature · 1 line
Tom
author
#15 lore raw

Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it

In reply to Tom Rini
Quoted 69 lines · Tom Rini
Quoted 68 lines · Jan Kiszka
Quoted 48 lines · Tom Rini
Quoted 41 lines · Jan Kiszka
Quoted 31 lines · Tom Rini
Quoted 20 lines · Jan Kiszka
Quoted 19 lines · Tom Rini
Quoted 6 lines · Jan Kiszka

From: Jan Kiszka <[email protected]>

This allows to use the watchdog in custom scripts but does not enforce that the OS has to support it as well.

Sorry for the late reply. This causes CI to fail:
Building current source for 1 boards (1 thread, 16 jobs per thread)
aarch64: + iot2050

(quoted diff) +5 -0
+(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional
+(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional
+(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050')
+(iot2050) make[1]: *** [all] Error 1
+(iot2050) make: *** [sub-make] Error 2
    0    0    1 /1              iot2050
Quoted 7 lines
Quoted 3 lines

And needs to be handled like ATF/OPTEE/etc where CI can build but throw a "THIS WILL NOT RUN CORRECTLY" type warning to the user.

I was about to sent an update anyway - time passed, and now we even have support for the next generation integrated from the beginning. But related upstream DT changes are not yet merged.

OK.

Quoted 8 lines
Quoted 2 lines

But back to this issue: How can CI be fed with all those required binaries? The build makes no sense in their absence.

To be clearer, CI isn't fed all of the binaries, we just use /dev/null in that case and try and make it clear it won't boot. K3 isn't a good example here, but I think sunxi uses binman and handles this same class of problem?

Quoted 5 lines

I'm seeing it additionally carrying a "missing-msg" property, but that alone (even with missing-blob-help updated) does not make the build pass. It rather seems I'm missing some "allow_missing" property for that image, but even reading the code gives no clue yet how to achieve that. Yet another binman mystery.

Quoted 5 lines

You might also need a new file in tools/binman/etype/ ? Also, it will have a non-zero exit status still, but with a value of 101 which we check for and know that's "binary blob missing" and so OK to allow CI to pass on.

Err, that doesn't sound like binman is making my life easier. Why can't a I simple do something like

	k3-rti-wdt-firmware {
		type = "blob";
		load = <0x82000000>;
		blob {
			filename = CONFIG_WDT_K3_RTI_FW_FILE;
			missing-msg = "k3-rti-wdt-firmware";
			allow_missing;
		};
	};
Quoted 5 lines
Quoted 1 line

and be done?

Sounds like a good idea, and I'm not quite sure what's missing to go from where we are today to there. I might be missing something myself.

Works now, with "blob-ext" rather than "blob". binman is actually called with --allow-missing.

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux