usb: ohci: Prefer struct_size over open coded arithmetic
Subsystems (2)
PATCH 1/1 usb: ohci: Prefer struct_size over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the struct_size() helper to do the arithmetic instead of the argument "size + count * size" in the kzalloc() function.
--- drivers/usb/host/ohci-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/host/ohci-hcd.c +1 -2
@@ -191,8 +191,7 @@ static int ohci_urb_enqueue ( }/* allocate the private part of the URB */ - urb_priv =kzalloc (sizeof (urb_priv_t) + size *sizeof (struct td *), - mem_flags); + urb_priv =kzalloc (struct_size (urb_priv, td, size), mem_flags);if (!urb_priv)return -ENOMEM ;INIT_LIST_HEAD (&urb_priv->pending);
--
2.25.1
Quoted 8 lines · Len Baker
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 7 lines
So, use the
struct_size()helper to do the arithmetic instead of the argument "size + count * size" in thekzalloc()function.Signed-off-by Len Baker <[email protected]>---
Quoted 20 lines
drivers/usb/host/ohci-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/usb/host/ohci-hcd.c +1
-3@@ -191,8 +191,7 @@ static int ohci_urb_enqueue ( }/* allocate the private part of the URB */ - urb_priv =kzalloc (sizeof (urb_priv_t) + size *sizeof (struct td *), - mem_flags); + urb_priv =kzalloc (struct_size (urb_priv, td, size), mem_flags);if (!urb_priv)return -ENOMEM ;INIT_LIST_HEAD (&urb_priv->pending); --2.25.1