staging: r8188eu: remove unused functions from odm_interface.c
cover staging: r8188eu: remove unused functions from odm_interface.c
This series removes unused and/or empty functions from the file hal/odm_interface.c.
Tested on x86_64 with Inter-Tech DMG-02.
Michael Straube (18):
staging: r8188eu: remove empty ODM_ReleaseTimer()
staging: r8188eu: remove unused ODM_AcquireSpinLock()
staging: r8188eu: remove unused ODM_ReleaseSpinLock()
staging: r8188eu: remove unused ODM_FillH2CCmd()
staging: r8188eu: remove unused ODM_sleep_us()
staging: r8188eu: remove unused ODM_InitializeWorkItem()
staging: r8188eu: remove unused ODM_StartWorkItem()
staging: r8188eu: remove unused ODM_StopWorkItem()
staging: r8188eu: remove unused ODM_FreeWorkItem()
staging: r8188eu: remove unused ODM_ScheduleWorkItem()
staging: r8188eu: remove unused ODM_IsWorkItemScheduled()
staging: r8188eu: remove unused ODM_SetTimer()
staging: r8188eu: remove unused ODM_Read2Byte()
staging: r8188eu: remove unused ODM_FreeMemory()
staging: r8188eu: remove unused ODM_AllocateMemory()
staging: r8188eu: remove unused prototype ODM_InitializeTimer()
staging: r8188eu: remove unused ODM_CancelAllTimers()
staging: r8188eu: remove unused ODM_InitAllTimers()
drivers/staging/r8188eu/hal/odm.c | 17 ---- drivers/staging/r8188eu/hal/odm_interface.c | 80 ------------------- drivers/staging/r8188eu/include/odm.h | 6 -- .../staging/r8188eu/include/odm_interface.h | 45 ----------- 4 files changed, 148 deletions(-)
Signature · 1 line
2.33.0
PATCH 1/18 staging: r8188eu: remove empty ODM_ReleaseTimer()
Function ODM_ReleaseTimer() is empty and its only caller is ODM_ReleaseAllTimers(). Remove both functions.
--- drivers/staging/r8188eu/hal/odm.c | 7 ------- drivers/staging/r8188eu/hal/odm_interface.c | 4 ---- drivers/staging/r8188eu/include/odm.h | 2 -- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 4 files changed, 15 deletions(-)
drivers/staging/r8188eu/hal/odm.c +0 -7
@@ -1414,13 +1414,6 @@ void ODM_CancelAllTimers(struct odm_dm_struct *pDM_Odm)ODM_CancelTimer (pDM_Odm, &pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer); } -void ODM_ReleaseAllTimers (struct odm_dm_struct *pDM_Odm) -{ -ODM_ReleaseTimer (pDM_Odm, &pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer); - -ODM_ReleaseTimer (pDM_Odm, &pDM_Odm->FastAntTrainingTimer); -} -/* 3============================================================ */ /* 3 Tx Power Tracking */ /* 3============================================================ */
drivers/staging/r8188eu/hal/odm_interface.c +0 -4
@@ -165,10 +165,6 @@ void ODM_CancelTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer)_cancel_timer_ex (pTimer); } -void ODM_ReleaseTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer) -{ -} -/* ODM FW relative API. */ u32 ODM_FillH2CCmd(u8 *pH2CBuffer, u32 H2CBufferLen, u32 CmdNum, u32 *pElementID, u32 *pCmdLen,
drivers/staging/r8188eu/include/odm.h +0 -2
@@ -1139,8 +1139,6 @@ void ODM_InitAllTimers(struct odm_dm_struct *pDM_Odm);void ODM_CancelAllTimers (struct odm_dm_struct *pDM_Odm); -void ODM_ReleaseAllTimers (struct odm_dm_struct *pDM_Odm); -void ODM_AntselStatistics_88C (struct odm_dm_struct *pDM_Odm,u8 MacId,u32 PWDBAll,bool isCCKrate);
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -137,8 +137,6 @@ void ODM_InitializeTimer(struct odm_dm_struct *pDM_Odm,void ODM_CancelTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer); -void ODM_ReleaseTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer); -/* ODM FW relative API. */ u32 ODM_FillH2CCmd(u8 *pH2CBuffer, u32 H2CBufferLen, u32 CmdNum, u32 *pElementID, u32 *pCmdLen, u8 **pCmbBuffer,
Signature · 1 line
2.33.0
PATCH 2/18 staging: r8188eu: remove unused ODM_AcquireSpinLock()
In reply to Michael StraubeFunction ODM_AcquireSpinLock() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 4 ---- drivers/staging/r8188eu/include/odm_interface.h | 3 --- 2 files changed, 7 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -4
@@ -94,10 +94,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u }/* ODM MISC relative API. */ -void ODM_AcquireSpinLock (struct odm_dm_struct *pDM_Odm,enum RT_SPINLOCK_TYPE type) -{ -} -void ODM_ReleaseSpinLock (struct odm_dm_struct *pDM_Odm,enum RT_SPINLOCK_TYPE type) { }
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -96,9 +96,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u32 length);/* ODM MISC-spin lock relative API. */ -void ODM_AcquireSpinLock (struct odm_dm_struct *pDM_Odm, -enum RT_SPINLOCK_TYPE type); -void ODM_ReleaseSpinLock (struct odm_dm_struct *pDM_Odm,enum RT_SPINLOCK_TYPE type);
Signature · 1 line
2.33.0
PATCH 3/18 staging: r8188eu: remove unused ODM_ReleaseSpinLock()
In reply to Michael StraubeFunction ODM_ReleaseSpinLock() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 4 ---- 2 files changed, 9 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -93,11 +93,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, ureturn !memcmp (pBuf1, pBuf2, length); } -/* ODM MISC relative API. */ -void ODM_ReleaseSpinLock (struct odm_dm_struct *pDM_Odm,enum RT_SPINLOCK_TYPE type) -{ -} -/* Work item relative API. FOr MP driver only~! */ void ODM_InitializeWorkItem(struct odm_dm_struct *pDM_Odm, void *pRtWorkItem, RT_WORKITEM_CALL_BACK RtWorkItemCallback,
drivers/staging/r8188eu/include/odm_interface.h +0 -4
@@ -95,10 +95,6 @@ void ODM_FreeMemory(struct odm_dm_struct *pDM_Odm, void *pPtr, u32 length);s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length); -/* ODM MISC-spin lock relative API. */ -void ODM_ReleaseSpinLock (struct odm_dm_struct *pDM_Odm, -enum RT_SPINLOCK_TYPE type); -/* ODM MISC-workitem relative API. */ void ODM_InitializeWorkItem(struct odm_dm_struct *pDM_Odm, void *pRtWorkItem, RT_WORKITEM_CALL_BACK RtWorkItemCallback,
Signature · 1 line
2.33.0
PATCH 4/18 staging: r8188eu: remove unused ODM_FillH2CCmd()
In reply to Michael StraubeFunction ODM_FillH2CCmd() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 8 -------- drivers/staging/r8188eu/include/odm_interface.h | 5 ----- 2 files changed, 13 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -8
@@ -155,11 +155,3 @@ void ODM_CancelTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer) {_cancel_timer_ex (pTimer); } - -/* ODM FW relative API. */ -u32 ODM_FillH2CCmd (u8 *pH2CBuffer,u32 H2CBufferLen,u32 CmdNum, -u32 *pElementID,u32 *pCmdLen, -u8 **pCmbBuffer,u8 *CmdStartSeq) -{ -return true; -}
drivers/staging/r8188eu/include/odm_interface.h +0 -5
@@ -130,9 +130,4 @@ void ODM_InitializeTimer(struct odm_dm_struct *pDM_Odm,void ODM_CancelTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer); -/* ODM FW relative API. */ -u32 ODM_FillH2CCmd (u8 *pH2CBuffer,u32 H2CBufferLen,u32 CmdNum, -u32 *pElementID,u32 *pCmdLen,u8 **pCmbBuffer, -u8 *CmdStartSeq); -#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.33.0
PATCH 5/18 staging: r8188eu: remove unused ODM_sleep_us()
In reply to Michael StraubeFunction ODM_sleep_us() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 7 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -141,11 +141,6 @@ void ODM_sleep_ms(u32 ms)msleep (ms); } -void ODM_sleep_us (u32 us) -{ -rtw_usleep_os (us); -} -void ODM_SetTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer,u32 msDelay) {_set_timer (pTimer, msDelay);/* ms */
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -119,8 +119,6 @@ void ODM_delay_us(u32 us);void ODM_sleep_ms (u32 ms); -void ODM_sleep_us (u32 us); -void ODM_SetTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer,u32 msDelay);
Signature · 1 line
2.33.0
PATCH 6/18 staging: r8188eu: remove unused ODM_InitializeWorkItem()
In reply to Michael StraubeFunction ODM_InitializeWorkItem() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 4 ---- 2 files changed, 10 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -94,12 +94,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u }/* Work item relative API. FOr MP driver only~! */ -void ODM_InitializeWorkItem (struct odm_dm_struct *pDM_Odm,void *pRtWorkItem, -RT_WORKITEM_CALL_BACK RtWorkItemCallback, -void *pContext,const char *szID) -{ -} -void ODM_StartWorkItem (void *pRtWorkItem) { }
drivers/staging/r8188eu/include/odm_interface.h +0 -4
@@ -96,10 +96,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u32 length);/* ODM MISC-workitem relative API. */ -void ODM_InitializeWorkItem (struct odm_dm_struct *pDM_Odm,void *pRtWorkItem, -RT_WORKITEM_CALL_BACK RtWorkItemCallback, -void *pContext,const char *szID); -void ODM_StartWorkItem (void *pRtWorkItem);void ODM_StopWorkItem (void *pRtWorkItem);
Signature · 1 line
2.33.0
PATCH 7/18 staging: r8188eu: remove unused ODM_StartWorkItem()
In reply to Michael StraubeFunction ODM_StartWorkItem() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 4 ---- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 6 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -4
@@ -94,10 +94,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u }/* Work item relative API. FOr MP driver only~! */ -void ODM_StartWorkItem (void *pRtWorkItem) -{ -} -void ODM_StopWorkItem (void *pRtWorkItem) { }
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -96,8 +96,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u32 length);/* ODM MISC-workitem relative API. */ -void ODM_StartWorkItem (void *pRtWorkItem); -void ODM_StopWorkItem (void *pRtWorkItem);void ODM_FreeWorkItem (void *pRtWorkItem);
Signature · 1 line
2.33.0
PATCH 8/18 staging: r8188eu: remove unused ODM_StopWorkItem()
In reply to Michael StraubeFunction ODM_StopWorkItem() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 4 ---- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 6 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -4
@@ -94,10 +94,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u }/* Work item relative API. FOr MP driver only~! */ -void ODM_StopWorkItem (void *pRtWorkItem) -{ -} -void ODM_FreeWorkItem (void *pRtWorkItem) { }
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -96,8 +96,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u32 length);/* ODM MISC-workitem relative API. */ -void ODM_StopWorkItem (void *pRtWorkItem); -void ODM_FreeWorkItem (void *pRtWorkItem);void ODM_ScheduleWorkItem (void *pRtWorkItem);
Signature · 1 line
2.33.0
PATCH 9/18 staging: r8188eu: remove unused ODM_FreeWorkItem()
In reply to Michael StraubeFunction ODM_FreeWorkItem() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 4 ---- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 6 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -4
@@ -94,10 +94,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u }/* Work item relative API. FOr MP driver only~! */ -void ODM_FreeWorkItem (void *pRtWorkItem) -{ -} -void ODM_ScheduleWorkItem (void *pRtWorkItem) { }
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -96,8 +96,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u32 length);/* ODM MISC-workitem relative API. */ -void ODM_FreeWorkItem (void *pRtWorkItem); -void ODM_ScheduleWorkItem (void *pRtWorkItem);void ODM_IsWorkItemScheduled (void *pRtWorkItem);
Signature · 1 line
2.33.0
PATCH 10/18 staging: r8188eu: remove unused ODM_ScheduleWorkItem()
In reply to Michael StraubeFunction ODM_ScheduleWorkItem() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 4 ---- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 6 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -4
@@ -94,10 +94,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u }/* Work item relative API. FOr MP driver only~! */ -void ODM_ScheduleWorkItem (void *pRtWorkItem) -{ -} -void ODM_IsWorkItemScheduled (void *pRtWorkItem) { }
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -96,8 +96,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u32 length);/* ODM MISC-workitem relative API. */ -void ODM_ScheduleWorkItem (void *pRtWorkItem); -void ODM_IsWorkItemScheduled (void *pRtWorkItem);/* ODM Timer relative API. */
Signature · 1 line
2.33.0
PATCH 11/18 staging: r8188eu: remove unused ODM_IsWorkItemScheduled()
In reply to Michael StraubeFunction ODM_IsWorkItemScheduled() is unused and empty, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 3 --- 2 files changed, 8 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -93,11 +93,6 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, ureturn !memcmp (pBuf1, pBuf2, length); } -/* Work item relative API. FOr MP driver only~! */ -void ODM_IsWorkItemScheduled (void *pRtWorkItem) -{ -} -/* ODM Timer relative API. */ void ODM_StallExecution (u32 usDelay) {
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -95,9 +95,6 @@ void ODM_FreeMemory(struct odm_dm_struct *pDM_Odm, void *pPtr, u32 length);s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length); -/* ODM MISC-workitem relative API. */ -void ODM_IsWorkItemScheduled (void *pRtWorkItem); -/* ODM Timer relative API. */ void ODM_StallExecution (u32 usDelay);
Signature · 1 line
2.33.0
PATCH 12/18 staging: r8188eu: remove unused ODM_SetTimer()
In reply to Michael StraubeFunction ODM_SetTimer() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 3 --- 2 files changed, 8 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -114,11 +114,6 @@ void ODM_sleep_ms(u32 ms)msleep (ms); } -void ODM_SetTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer,u32 msDelay) -{ -_set_timer (pTimer, msDelay);/* ms */ -} -void ODM_CancelTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer) {_cancel_timer_ex (pTimer);
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -104,9 +104,6 @@ void ODM_delay_us(u32 us);void ODM_sleep_ms (u32 ms); -void ODM_SetTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer, -u32 msDelay); -void ODM_InitializeTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer,void *CallBackFunc,void *pContext,const char *szID);
Signature · 1 line
2.33.0
PATCH 13/18 staging: r8188eu: remove unused ODM_Read2Byte()
In reply to Michael StraubeFunction ODM_Read2Byte() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 8 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -10,12 +10,6 @@ u8 ODM_Read1Byte(struct odm_dm_struct *pDM_Odm, u32 RegAddr)return rtw_read8 (Adapter, RegAddr); } -u16 ODM_Read2Byte (struct odm_dm_struct *pDM_Odm,u32 RegAddr) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -return rtw_read16 (Adapter, RegAddr); -} -u32 ODM_Read4Byte (struct odm_dm_struct *pDM_Odm,u32 RegAddr) {struct adapter *Adapter = pDM_Odm->Adapter;
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -62,8 +62,6 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);u8 ODM_Read1Byte (struct odm_dm_struct *pDM_Odm,u32 RegAddr); -u16 ODM_Read2Byte (struct odm_dm_struct *pDM_Odm,u32 RegAddr); -u32 ODM_Read4Byte (struct odm_dm_struct *pDM_Odm,u32 RegAddr);void ODM_Write1Byte (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u8 Data);
Signature · 1 line
2.33.0
PATCH 14/18 staging: r8188eu: remove unused ODM_FreeMemory()
In reply to Michael StraubeFunction ODM_FreeMemory() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 1 - 2 files changed, 7 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -76,12 +76,6 @@ void ODM_AllocateMemory(struct odm_dm_struct *pDM_Odm, void **pPtr, u32 length) *pPtr =vzalloc (length); } -/* length could be ignored, used to detect memory leakage. */ -void ODM_FreeMemory (struct odm_dm_struct *pDM_Odm,void *pPtr,u32 length) -{ -vfree (pPtr); -} -s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) {return !memcmp (pBuf1, pBuf2, length);
drivers/staging/r8188eu/include/odm_interface.h +0 -1
@@ -88,7 +88,6 @@ u32 ODM_GetRFReg(struct odm_dm_struct *pDM_Odm, enum rf_radio_path eRFPath,/* Memory Relative Function. */ void ODM_AllocateMemory (struct odm_dm_struct *pDM_Odm,void **pPtr,u32 length); -void ODM_FreeMemory (struct odm_dm_struct *pDM_Odm,void *pPtr,u32 length);s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length);
Signature · 1 line
2.33.0
PATCH 15/18 staging: r8188eu: remove unused ODM_AllocateMemory()
In reply to Michael StraubeFunction ODM_AllocateMemory() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 2 files changed, 7 deletions(-)
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -71,11 +71,6 @@ u32 ODM_GetRFReg(struct odm_dm_struct *pDM_Odm, enum rf_radio_path eRFPath, u32 }/* ODM Memory relative API. */ -void ODM_AllocateMemory (struct odm_dm_struct *pDM_Odm,void **pPtr,u32 length) -{ - *pPtr =vzalloc (length); -} -s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) {return !memcmp (pBuf1, pBuf2, length);
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -87,8 +87,6 @@ u32 ODM_GetRFReg(struct odm_dm_struct *pDM_Odm, enum rf_radio_path eRFPath, u32 RegAddr, u32 BitMask);/* Memory Relative Function. */ -void ODM_AllocateMemory (struct odm_dm_struct *pDM_Odm,void **pPtr,u32 length); -s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length);
Signature · 1 line
2.33.0
PATCH 16/18 staging: r8188eu: remove unused prototype ODM_InitializeTimer()
In reply to Michael StraubeThe function prototype ODM_InitializeTimer() is not used, remove it.
--- drivers/staging/r8188eu/include/odm_interface.h | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/r8188eu/include/odm_interface.h +0 -4
@@ -99,10 +99,6 @@ void ODM_delay_us(u32 us);void ODM_sleep_ms (u32 ms); -void ODM_InitializeTimer (struct odm_dm_struct *pDM_Odm, -struct timer_list *pTimer,void *CallBackFunc, -void *pContext,const char *szID); -void ODM_CancelTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer);#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.33.0
PATCH 17/18 staging: r8188eu: remove unused ODM_CancelAllTimers()
In reply to Michael StraubeFunction ODM_CancelAllTimers() is unused and it is the only caller of function ODM_CancelTimer(). Remove both.
--- drivers/staging/r8188eu/hal/odm.c | 5 ----- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm.h | 2 -- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 4 files changed, 14 deletions(-)
drivers/staging/r8188eu/hal/odm.c +0 -5
@@ -1409,11 +1409,6 @@ void ODM_InitAllTimers(struct odm_dm_struct *pDM_Odm)timer_setup (&pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer, odm_SwAntDivChkAntSwitchCallback,0 ); } -void ODM_CancelAllTimers (struct odm_dm_struct *pDM_Odm) -{ -ODM_CancelTimer (pDM_Odm, &pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer); -} -/* 3============================================================ */ /* 3 Tx Power Tracking */ /* 3============================================================ */
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -96,8 +96,3 @@ void ODM_sleep_ms(u32 ms) {msleep (ms); } - -void ODM_CancelTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer) -{ -_cancel_timer_ex (pTimer); -}
drivers/staging/r8188eu/include/odm.h +0 -2
@@ -1137,8 +1137,6 @@ void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value);void ODM_InitAllTimers (struct odm_dm_struct *pDM_Odm); -void ODM_CancelAllTimers (struct odm_dm_struct *pDM_Odm); -void ODM_AntselStatistics_88C (struct odm_dm_struct *pDM_Odm,u8 MacId,u32 PWDBAll,bool isCCKrate);
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -99,6 +99,4 @@ void ODM_delay_us(u32 us);void ODM_sleep_ms (u32 ms); -void ODM_CancelTimer (struct odm_dm_struct *pDM_Odm,struct timer_list *pTimer); -#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.33.0
PATCH 18/18 staging: r8188eu: remove unused ODM_InitAllTimers()
In reply to Michael StraubeFunction ODM_InitAllTimers() is unused, remove it.
--- drivers/staging/r8188eu/hal/odm.c | 5 ----- drivers/staging/r8188eu/include/odm.h | 2 -- 2 files changed, 7 deletions(-)
drivers/staging/r8188eu/hal/odm.c +0 -5
@@ -1404,11 +1404,6 @@ void odm_RSSIMonitorCheckAP(struct odm_dm_struct *pDM_Odm) { } -void ODM_InitAllTimers (struct odm_dm_struct *pDM_Odm) -{ -timer_setup (&pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer, odm_SwAntDivChkAntSwitchCallback,0 ); -} -/* 3============================================================ */ /* 3 Tx Power Tracking */ /* 3============================================================ */
drivers/staging/r8188eu/include/odm.h +0 -2
@@ -1135,8 +1135,6 @@ void ODM_CmnInfoPtrArrayHook(struct odm_dm_struct *pDM_Odm,void ODM_CmnInfoUpdate (struct odm_dm_struct *pDM_Odm,u32 CmnInfo,u64 Value); -void ODM_InitAllTimers (struct odm_dm_struct *pDM_Odm); -void ODM_AntselStatistics_88C (struct odm_dm_struct *pDM_Odm,u8 MacId,u32 PWDBAll,bool isCCKrate);
Signature · 1 line
2.33.0
Thus wrote Michael Straube ([email protected]):
Quoted 25 lines
This series removes unused and/or empty functions from the file
hal/odm_interface.c.Tested on
x86_64with Inter-Tech DMG-02.Michael Straube (18):
staging: r8188eu: remove emptyODM_ReleaseTimer()
staging: r8188eu: remove unusedODM_AcquireSpinLock()
staging: r8188eu: remove unusedODM_ReleaseSpinLock()
staging: r8188eu: remove unusedODM_FillH2CCmd()
staging: r8188eu: remove unusedODM_sleep_us()
staging: r8188eu: remove unusedODM_InitializeWorkItem()
staging: r8188eu: remove unusedODM_StartWorkItem()
staging: r8188eu: remove unusedODM_StopWorkItem()
staging: r8188eu: remove unusedODM_FreeWorkItem()
staging: r8188eu: remove unusedODM_ScheduleWorkItem()
staging: r8188eu: remove unusedODM_IsWorkItemScheduled()
staging: r8188eu: remove unusedODM_SetTimer()
staging: r8188eu: remove unusedODM_Read2Byte()
staging: r8188eu: remove unusedODM_FreeMemory()
staging: r8188eu: remove unusedODM_AllocateMemory()
staging: r8188eu: remove unused prototypeODM_InitializeTimer()
staging: r8188eu: remove unusedODM_CancelAllTimers()
staging: r8188eu: remove unusedODM_InitAllTimers()
Quoted 5 lines
drivers/staging/r8188eu/hal/odm.c | 17 ---- drivers/staging/r8188eu/hal/odm_interface.c | 80 ------------------- drivers/staging/r8188eu/include/odm.h | 6 -- .../staging/r8188eu/include/odm_interface.h | 45 ----------- 4 files changed, 148 deletions(-)
Looks good to me.
for all patches.
Thanks,
Martin